From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexander Graf <agraf@suse.de>, Jan Kiszka <jan.kiszka@web.de>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Liu Ping Fan" <pingfank@linux.vnet.ibm.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer
Date: Fri, 12 Jul 2013 07:56:42 -0500 [thread overview]
Message-ID: <87ppuoc4xh.fsf@codemonkey.ws> (raw)
In-Reply-To: <A4555446-4852-488B-82BE-A250FD5622AF@suse.de>
Alexander Graf <agraf@suse.de> writes:
> On 11.07.2013, at 14:29, Alexander Graf wrote:
>
>> This patch breaks VGA on PPC as it is in master today.
>
> If I don't mark portio as little endian it works as expected. There's
> probably someone swapping things twice.
This is the correct fix. Can you please send a patch?
I/O dispatch functions take a native endian argument and when
cpu_{in,out][bwl] is called it's passed a native endian argument. There
is no need to ever byte swap.
The ISA bus is going to have data pins numbered D0..D15. There is no
concept of endianness. D0 is the LSB. How the CPU stores bytes in
memory is orthogonal to what is happening on the bus.
Regards,
Anthony Liguori
>
>
> Alex
next prev parent reply other threads:[~2013-07-12 12:56 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 6:06 [Qemu-devel] [PATCH v3 00/14] Refactor portio dispatching Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 01/14] adlib: replace register_ioport* Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 02/14] applesmc: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 03/14] wdt_ib700: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 04/14] i82374: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 05/14] prep: " Jan Kiszka
2013-06-22 6:06 ` [Qemu-devel] [PATCH v3 06/14] vt82c686: " Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 07/14] Privatize register_ioport_read/write Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 08/14] isa: implement isa_is_ioport_assigned via memory_region_find Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 09/14] vmware-vga: Accept unaligned I/O accesses Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 10/14] xen: Mark fixed platform I/O as unaligned Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer Jan Kiszka
2013-06-23 20:50 ` Hervé Poussineau
2013-06-24 6:07 ` Jan Kiszka
2013-07-11 12:29 ` Alexander Graf
2013-07-11 12:34 ` Alexander Graf
2013-07-11 12:46 ` Andreas Färber
2013-07-11 12:48 ` Alexander Graf
2013-07-11 13:28 ` Alexander Graf
2013-07-11 13:35 ` Alexander Graf
2013-07-11 22:30 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-07-11 22:32 ` Benjamin Herrenschmidt
2013-07-12 3:18 ` Alexander Graf
2013-07-12 11:35 ` Benjamin Herrenschmidt
2013-07-12 17:04 ` Hervé Poussineau
2013-07-12 19:06 ` Anthony Liguori
2013-07-12 22:59 ` Benjamin Herrenschmidt
2013-07-12 22:39 ` Benjamin Herrenschmidt
2013-07-12 17:49 ` Anthony Liguori
2013-07-12 18:26 ` Peter Maydell
2013-07-12 22:50 ` Benjamin Herrenschmidt
2013-07-12 23:10 ` Peter Maydell
2013-07-12 23:49 ` Benjamin Herrenschmidt
2013-07-15 14:01 ` Anthony Liguori
2013-07-15 14:10 ` Peter Maydell
2013-07-15 14:16 ` Benjamin Herrenschmidt
2013-07-12 22:44 ` Benjamin Herrenschmidt
2013-07-13 14:38 ` [Qemu-devel] " Paolo Bonzini
2013-07-13 15:22 ` Anthony Liguori
2013-07-13 18:11 ` Hervé Poussineau
2013-07-14 6:15 ` Paolo Bonzini
2013-07-14 13:05 ` Anthony Liguori
2013-07-14 14:58 ` Peter Maydell
2013-07-14 15:18 ` Anthony Liguori
2013-07-14 16:50 ` Peter Maydell
2013-07-16 7:18 ` Jan Kiszka
2013-07-16 7:33 ` Paolo Bonzini
2013-07-16 16:59 ` Hervé Poussineau
2013-07-16 17:12 ` Paolo Bonzini
2013-07-12 12:56 ` Anthony Liguori [this message]
2013-07-12 14:30 ` Alexander Graf
2013-07-19 11:09 ` [Qemu-devel] BUG: " Alexey Kardashevskiy
2013-07-19 12:49 ` Paolo Bonzini
2013-07-19 15:48 ` Alexey Kardashevskiy
2013-07-20 0:55 ` Alexey Kardashevskiy
2013-07-20 1:11 ` Alexey Kardashevskiy
2013-07-20 10:11 ` Paolo Bonzini
2013-07-20 20:53 ` Edgar E. Iglesias
2013-07-21 15:13 ` Hervé Poussineau
2013-07-22 10:25 ` Paolo Bonzini
2013-06-24 8:45 ` [Qemu-devel] [PATCH v4 " Jan Kiszka
2013-07-12 19:36 ` [Qemu-devel] [PATCH v3 " Anthony Liguori
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 12/14] ioport: Remove unused old dispatching services Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 13/14] vmport: Disentangle read handler type from portio Jan Kiszka
2013-06-22 6:07 ` [Qemu-devel] [PATCH v3 14/14] ioport: Move portio types to ioport.h Jan Kiszka
2013-06-23 20:45 ` [Qemu-devel] [PATCH v3 00/14] Refactor portio dispatching Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppuoc4xh.fsf@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=hpoussin@reactos.org \
--cc=jan.kiszka@web.de \
--cc=pbonzini@redhat.com \
--cc=pingfank@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.