From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Shishkin Subject: Re: [PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx Date: Wed, 14 Nov 2012 15:25:30 +0200 Message-ID: <87pq3g71v9.fsf@ashishki-desk.ger.corp.intel.com> References: <1352894137-2050-1-git-send-email-m.grzeschik@pengutronix.de> <1352894137-2050-3-git-send-email-m.grzeschik@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1352894137-2050-3-git-send-email-m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Grzeschik , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org Michael Grzeschik writes: > This driver will be used for every Freescale SoC which has this misc > memory layout to control the basic usb handling. So better name this > driver, function and struct names in a more generic way. > > Reported-by: Fabio Estevam > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx.c | 163 ++++++++++++++++++++++++++++++++++ > drivers/usb/chipidea/usbmisc_imx6q.c | 163 ---------------------------------- > 2 files changed, 163 insertions(+), 163 deletions(-) > create mode 100644 drivers/usb/chipidea/usbmisc_imx.c > delete mode 100644 drivers/usb/chipidea/usbmisc_imx6q.c Like Fabio suggested already, please use rename detection. Another thing, how do you get away with this without fixing the Makefile accordingly? Did you (at least) compile-test this patchset? Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexander.shishkin@linux.intel.com (Alexander Shishkin) Date: Wed, 14 Nov 2012 15:25:30 +0200 Subject: [PATCH 2/6] usb: chipidea: usbmisc: rename file, struct and functions to usbmisc_imx In-Reply-To: <1352894137-2050-3-git-send-email-m.grzeschik@pengutronix.de> References: <1352894137-2050-1-git-send-email-m.grzeschik@pengutronix.de> <1352894137-2050-3-git-send-email-m.grzeschik@pengutronix.de> Message-ID: <87pq3g71v9.fsf@ashishki-desk.ger.corp.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Michael Grzeschik writes: > This driver will be used for every Freescale SoC which has this misc > memory layout to control the basic usb handling. So better name this > driver, function and struct names in a more generic way. > > Reported-by: Fabio Estevam > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx.c | 163 ++++++++++++++++++++++++++++++++++ > drivers/usb/chipidea/usbmisc_imx6q.c | 163 ---------------------------------- > 2 files changed, 163 insertions(+), 163 deletions(-) > create mode 100644 drivers/usb/chipidea/usbmisc_imx.c > delete mode 100644 drivers/usb/chipidea/usbmisc_imx6q.c Like Fabio suggested already, please use rename detection. Another thing, how do you get away with this without fixing the Makefile accordingly? Did you (at least) compile-test this patchset? Regards, -- Alex