On Tue, 31 Jan 2012 10:34:38 -0800, Jeremy Huddleston wrote: > > On Jan 31, 2012, at 8:59 AM, Eric Anholt wrote: > > > On Mon, 30 Jan 2012 15:25:20 -0800, Jeremy Huddleston wrote: > >> This fixes a failure in 'make check' found by the tinderbox when trying to > >> build this code on Linux/ppc. This code is only designed to run on > >> Intel platforms, so don't even bother building it if we're not in that set. > > > > Looks reasonable to me, except it should probably be checking $target_os > > (cross-compile target) rather than $host_os (cross compile build host). > > I think you are misunderstanding the variables (or perhaps you are > following Mozilla's usage of the variables, which is wrong but > internally consistent). You're right. And that was with me looking up information on these variables before mailing last time. :(