From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] Don't build Intel DRM if $CHOST is not i?86-* or x86_64-* Date: Tue, 31 Jan 2012 13:12:16 -0800 Message-ID: <87pqdzmv9r.fsf@eliezer.anholt.net> References: <87boqgu5zf.fsf@eliezer.anholt.net> <87ehuj5l2n.fsf@eliezer.anholt.net> <5A68BEB0-7C83-4215-8A10-B5014060C764@freedesktop.org> <87fwex9mwp.fsf@eliezer.anholt.net> <8739avu7tz.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1029595368==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jeremy Huddleston Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1029595368== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 31 Jan 2012 10:34:38 -0800, Jeremy Huddleston wrote: >=20 > On Jan 31, 2012, at 8:59 AM, Eric Anholt wrote: >=20 > > On Mon, 30 Jan 2012 15:25:20 -0800, Jeremy Huddleston wrote: > >> This fixes a failure in 'make check' found by the tinderbox when tryin= g to > >> build this code on Linux/ppc. This code is only designed to run on > >> Intel platforms, so don't even bother building it if we're not in that= set. > >=20 > > Looks reasonable to me, except it should probably be checking $target_os > > (cross-compile target) rather than $host_os (cross compile build host). >=20 > I think you are misunderstanding the variables (or perhaps you are > following Mozilla's usage of the variables, which is wrong but > internally consistent). You're right. And that was with me looking up information on these variables before mailing last time. :( --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk8oWTAACgkQHUdvYGzw6vfVTACgmpTvx4/ZcC1cRlmf4Oz8Zx6v 49EAnjx8MfCQb7qQhjgTGD3gElpRAg8X =JPfX -----END PGP SIGNATURE----- --=-=-=-- --===============1029595368== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1029595368==--