From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 4/4] ASoC: soc-topology.c: remove unnecessary dai_link->platform
Date: Mon, 27 Mar 2023 23:20:08 +0000 [thread overview]
Message-ID: <87r0t9g4t4.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <5eb5c8e5-a6ad-2522-1b53-5f927a3a7d8c@linux.intel.com>
Hi Peter
Thank you for your feedback.
> > @@ -1694,11 +1694,9 @@ static int soc_tplg_fe_link_create(struct soc_tplg *tplg,
> >
> > link->cpus = &dlc[0];
> > link->codecs = &dlc[1];
> > - link->platforms = &dlc[2];
> >
> > link->num_cpus = 1;
> > link->num_codecs = 1;
> > - link->num_platforms = 1;
> >
> > link->dobj.index = tplg->index;
> > link->dobj.type = SND_SOC_DOBJ_DAI_LINK;
> > @@ -1726,8 +1724,6 @@ static int soc_tplg_fe_link_create(struct soc_tplg *tplg,
> > link->codecs->name = "snd-soc-dummy";
> > link->codecs->dai_name = "snd-soc-dummy-dai";
> >
> > - link->platforms->name = "snd-soc-dummy";
> > -
>
> I think this patch is incorrect and should be reverted (I have received
> a note from a SOF developer).
> The link->cpus->dai_name is not necessarily "snd-soc-dummy", it is set
> earlier:
> if (strlen(pcm->dai_name)) {
> link->cpus->dai_name = devm_kstrdup(tplg->dev, pcm->dai_name,
> GFP_KERNEL);
> if (!link->cpus->dai_name) {
> ret = -ENOMEM;
> goto err;
> }
> }
>
> We cannot be sure that it is the same component, in fact it is most like
> not.
But sorry, I don't understand the point.
This patch removed dummy PLATFORM which is not necessary I think,
but you are talking about CPU.
Could you please explain more detail what is the problem ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2023-03-27 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 22:53 [PATCH v2 0/4] ASoC: remove unnecessary dai_link->platform Kuninori Morimoto
2023-03-23 22:53 ` [PATCH v2 1/4] ASoC: fsl: " Kuninori Morimoto
2023-03-23 22:53 ` [PATCH v2 2/4] ASoC: atmel: " Kuninori Morimoto
2023-03-23 22:53 ` [PATCH v2 3/4] ASoC: ti: " Kuninori Morimoto
2023-03-23 22:53 ` [PATCH v2 4/4] ASoC: soc-topology.c: " Kuninori Morimoto
2023-03-27 7:12 ` Péter Ujfalusi
2023-03-27 23:20 ` Kuninori Morimoto [this message]
2023-03-28 6:49 ` Péter Ujfalusi
2023-03-29 0:20 ` Kuninori Morimoto
2023-03-24 16:37 ` [PATCH v2 0/4] ASoC: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0t9g4t4.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.