From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE04DC433EF for ; Tue, 5 Jul 2022 07:45:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229497AbiGEHp5 (ORCPT ); Tue, 5 Jul 2022 03:45:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbiGEHpy (ORCPT ); Tue, 5 Jul 2022 03:45:54 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BABC13D6A for ; Tue, 5 Jul 2022 00:45:53 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4AE2E1FF94; Tue, 5 Jul 2022 07:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657007152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FEag9uALBA30HMk0xF+XkRZffndMZupU843m2tnEhng=; b=LmXShlcc/1CNRNcnfrtr+MIjql/bLnkiUaNAmN1oKeTITPwMNGPj6geID0YKWBNwsWyF3b yLFDS+FdBM4JkaK6+joqwLPdOQ3akPxyzrEB8nUau75WHMeT7yAHvRrKiNSuEAIAmyAW9Y eztziPjeOqA4oo1i1+gL+ojbn9RvvT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657007152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FEag9uALBA30HMk0xF+XkRZffndMZupU843m2tnEhng=; b=Y4egdOKOETqNAtBllMjJwGae7YiOETLVylij3CFgfehTxeofgFzqCTEIEog836GQjnBuHX 0rVv1Ar7EjfGf9DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D3361339A; Tue, 5 Jul 2022 07:45:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id i4RVBjDsw2IJPwAAMHmgww (envelope-from ); Tue, 05 Jul 2022 07:45:52 +0000 Date: Tue, 05 Jul 2022 09:45:51 +0200 Message-ID: <87r130vw7k.wl-tiwai@suse.de> From: Takashi Iwai To: Tom Rix Cc: perex@perex.cz, tiwai@suse.com, vitalyr@opensource.cirrus.com, sbinding@opensource.cirrus.com, tanureal@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static In-Reply-To: <20220704142836.636204-1-trix@redhat.com> References: <20220704142836.636204-1-trix@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Jul 2022 16:28:36 +0200, Tom Rix wrote: > > sparse reports > sound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static? > > cs8409_cs42l42_pincfgs_no_dmic is only used by cs8409_fixups table as an > initializer for the hda_fixup element v.pins. Both are defined in the > patch_cs8408-table.c file but only cs8409_fixups is used externally in > patch_cs8409.c. So cs8409_cs42l42_pincfgs_no_dmic should have a static > storage class specifier. > > The other v.pins initializers in cs8409_fixups table, though declared > extern in patch_cs8409.h are also only used in patch_cs8409-tables.c. > So change all the v.pins initializers to static. > > Fixes: 9e7647b5070f ("ALSA: hda/cs8409: Move arrays of configuration to a new file") > Signed-off-by: Tom Rix Thanks, applied now. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC967C433EF for ; Tue, 5 Jul 2022 07:46:52 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1D3FD16E4; Tue, 5 Jul 2022 09:46:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1D3FD16E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657007210; bh=e9jdrgWcFByN9d0lAxUh7xEepgGqwyRulI8nB5yIkTQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lWD6SxD18MdSB68qHaXqZ/k2tLe+gQaFHTTAZRlbjJWjHCN9O+8/alBL1N6nuA65f fBot1Y+pYeZpWUmhMbpiEk5D4ihqhOYgmmtzGxPPxS7fPvox9Bw+3w1Qs0nSIkq8W2 aoSE2CTJLclUnrppVb0gndKx7oytOcCTgAdRpUwY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B1FA3F80153; Tue, 5 Jul 2022 09:45:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D249F8015B; Tue, 5 Jul 2022 09:45:57 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 090EBF80104 for ; Tue, 5 Jul 2022 09:45:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 090EBF80104 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="LmXShlcc"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Y4egdOKO" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4AE2E1FF94; Tue, 5 Jul 2022 07:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657007152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FEag9uALBA30HMk0xF+XkRZffndMZupU843m2tnEhng=; b=LmXShlcc/1CNRNcnfrtr+MIjql/bLnkiUaNAmN1oKeTITPwMNGPj6geID0YKWBNwsWyF3b yLFDS+FdBM4JkaK6+joqwLPdOQ3akPxyzrEB8nUau75WHMeT7yAHvRrKiNSuEAIAmyAW9Y eztziPjeOqA4oo1i1+gL+ojbn9RvvT0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657007152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FEag9uALBA30HMk0xF+XkRZffndMZupU843m2tnEhng=; b=Y4egdOKOETqNAtBllMjJwGae7YiOETLVylij3CFgfehTxeofgFzqCTEIEog836GQjnBuHX 0rVv1Ar7EjfGf9DQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D3361339A; Tue, 5 Jul 2022 07:45:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id i4RVBjDsw2IJPwAAMHmgww (envelope-from ); Tue, 05 Jul 2022 07:45:52 +0000 Date: Tue, 05 Jul 2022 09:45:51 +0200 Message-ID: <87r130vw7k.wl-tiwai@suse.de> From: Takashi Iwai To: Tom Rix Subject: Re: [PATCH] ALSA: hda/cs8409: change cs8409_fixups v.pins initializers to static In-Reply-To: <20220704142836.636204-1-trix@redhat.com> References: <20220704142836.636204-1-trix@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: sbinding@opensource.cirrus.com, tanureal@opensource.cirrus.com, vitalyr@opensource.cirrus.com, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 04 Jul 2022 16:28:36 +0200, Tom Rix wrote: > > sparse reports > sound/pci/hda/patch_cs8409-tables.c:79:25: warning: symbol 'cs8409_cs42l42_pincfgs_no_dmic' was not declared. Should it be static? > > cs8409_cs42l42_pincfgs_no_dmic is only used by cs8409_fixups table as an > initializer for the hda_fixup element v.pins. Both are defined in the > patch_cs8408-table.c file but only cs8409_fixups is used externally in > patch_cs8409.c. So cs8409_cs42l42_pincfgs_no_dmic should have a static > storage class specifier. > > The other v.pins initializers in cs8409_fixups table, though declared > extern in patch_cs8409.h are also only used in patch_cs8409-tables.c. > So change all the v.pins initializers to static. > > Fixes: 9e7647b5070f ("ALSA: hda/cs8409: Move arrays of configuration to a new file") > Signed-off-by: Tom Rix Thanks, applied now. Takashi