From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69F6DC433EF for ; Fri, 6 May 2022 11:22:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1391287AbiEFL0V (ORCPT ); Fri, 6 May 2022 07:26:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1391275AbiEFL0T (ORCPT ); Fri, 6 May 2022 07:26:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2287F554AF for ; Fri, 6 May 2022 04:22:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A63861EDB for ; Fri, 6 May 2022 11:22:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05987C385A9; Fri, 6 May 2022 11:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651836156; bh=r7OyxzyBdIaocPkug0fxzboid16Pez/XeXzUQGMJtTI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BLEH02BfilnHklMs3uFm+MHsmCjwZKr0bJRY82MrC+0L0faHTc0Gl+pCfF0rfIlaG mAfZrdjBpvCmAionKpaPa2YlX5qe3yzGHJG9T4PuaMNXyft+1Qps/6juVmkTqhXVYs Lwv5Vqmbi0Rh0Svn7dRKK9wl6nv1hscSyZjtEzHd9msuDd8geYvh5ATH71m/yj/v8X C6iLAuUE36S2A1GQmuJI6nwEzZeVYB5DFmuD+1nHMnmMl6YBbBPQetkBolYhYxtViK PV/vIeAg4ibBLLLhTb+ixN0/NPgXR9DIPrnW5d1rrDSppDYGTbNRnwnfH/JW5MkMWX OGIzvJET8P07w== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmw2b-009RbO-MY; Fri, 06 May 2022 12:22:33 +0100 Date: Fri, 06 May 2022 12:22:33 +0100 Message-ID: <87r1567vnq.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1 In-Reply-To: <20220425113706.29310-2-pali@kernel.org> References: <20220425113706.29310-1-pali@kernel.org> <20220425113706.29310-2-pali@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Apr 2022 12:37:06 +0100, Pali Roh=C3=A1r wrote: >=20 > IRQs 0 and 1 cannot be mapped, they are handled internally by this driver > and this driver does not call generic_handle_domain_irq() for these IRQs. > So do not allow mapping these IRQs and correctly propagate error from the > .irq_map callback. >=20 > Signed-off-by: Pali Roh=C3=A1r > Cc: stable@vger.kernel.org > --- > drivers/irqchip/irq-armada-370-xp.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-ar= mada-370-xp.c > index 1120084cba09..ebd76ea1c69b 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -546,6 +546,10 @@ static struct irq_chip armada_370_xp_irq_chip =3D { > static int armada_370_xp_mpic_irq_map(struct irq_domain *h, > unsigned int virq, irq_hw_number_t hw) > { > + /* IRQs 0 and 1 cannot be mapped, they are handled internally */ > + if (hw <=3D 1) > + return -EINVAL; > + > armada_370_xp_irq_mask(irq_get_irq_data(virq)); > if (!is_percpu_irq(hw)) > writel(hw, per_cpu_int_base + > --=20 > 2.20.1 >=20 >=20 Given that this is completely academic and obviously doesn't affect anyone, I have removed the Cc: stable from the patch when applying it. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E122CC433F5 for ; Fri, 6 May 2022 11:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=myCxwqEtmooh5wFLwwuSQvPeikMNe02HW07cOVhGU/s=; b=CehJfvc5iTOTta WiB4pELe8xt5HzR6m0NTkntLe9x/ndELEEjwMfCuw4vfpOqLy38VSZPWXvWcX+3hxg9AR1ZwyBKxe 3Yc4sNQqM9dNRUfRI0+XpSrkfNLPwOvawkEM1IeQD+YnWQq9tGQVavW7CVAYBY2bSC3h0oJboz0t4 yMbFQWjW1veY8ddPeSnE+01eWF0AqHVFvL10pN36JPRrnjDsv1525DVRdb4EZ4ccHYLai9ikiyqLZ PdVKqcinXVaZYqrzQTV1/UpAzFI4QX1VSQArS3xG1fg+1bmjp7ItdT9qZdsY4MqAgYxCUgpaeAAPO N0MubtCOTi55mJwCUQ1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmw2k-002soV-1P; Fri, 06 May 2022 11:22:42 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmw2g-002sn8-FR for linux-arm-kernel@lists.infradead.org; Fri, 06 May 2022 11:22:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95182618A3; Fri, 6 May 2022 11:22:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05987C385A9; Fri, 6 May 2022 11:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651836156; bh=r7OyxzyBdIaocPkug0fxzboid16Pez/XeXzUQGMJtTI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BLEH02BfilnHklMs3uFm+MHsmCjwZKr0bJRY82MrC+0L0faHTc0Gl+pCfF0rfIlaG mAfZrdjBpvCmAionKpaPa2YlX5qe3yzGHJG9T4PuaMNXyft+1Qps/6juVmkTqhXVYs Lwv5Vqmbi0Rh0Svn7dRKK9wl6nv1hscSyZjtEzHd9msuDd8geYvh5ATH71m/yj/v8X C6iLAuUE36S2A1GQmuJI6nwEzZeVYB5DFmuD+1nHMnmMl6YBbBPQetkBolYhYxtViK PV/vIeAg4ibBLLLhTb+ixN0/NPgXR9DIPrnW5d1rrDSppDYGTbNRnwnfH/JW5MkMWX OGIzvJET8P07w== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmw2b-009RbO-MY; Fri, 06 May 2022 12:22:33 +0100 Date: Fri, 06 May 2022 12:22:33 +0100 Message-ID: <87r1567vnq.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1 In-Reply-To: <20220425113706.29310-2-pali@kernel.org> References: <20220425113706.29310-1-pali@kernel.org> <20220425113706.29310-2-pali@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220506_042238_591708_C40013EB X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNSBBcHIgMjAyMiAxMjozNzowNiArMDEwMCwKUGFsaSBSb2jDoXIgPHBhbGlAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4gCj4gSVJRcyAwIGFuZCAxIGNhbm5vdCBiZSBtYXBwZWQsIHRoZXkg YXJlIGhhbmRsZWQgaW50ZXJuYWxseSBieSB0aGlzIGRyaXZlcgo+IGFuZCB0aGlzIGRyaXZlciBk b2VzIG5vdCBjYWxsIGdlbmVyaWNfaGFuZGxlX2RvbWFpbl9pcnEoKSBmb3IgdGhlc2UgSVJRcy4K PiBTbyBkbyBub3QgYWxsb3cgbWFwcGluZyB0aGVzZSBJUlFzIGFuZCBjb3JyZWN0bHkgcHJvcGFn YXRlIGVycm9yIGZyb20gdGhlCj4gLmlycV9tYXAgY2FsbGJhY2suCj4gCj4gU2lnbmVkLW9mZi1i eTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVs Lm9yZwo+IC0tLQo+ICBkcml2ZXJzL2lycWNoaXAvaXJxLWFybWFkYS0zNzAteHAuYyB8IDQgKysr Kwo+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvaXJxY2hpcC9pcnEtYXJtYWRhLTM3MC14cC5jIGIvZHJpdmVycy9pcnFjaGlwL2lycS1h cm1hZGEtMzcwLXhwLmMKPiBpbmRleCAxMTIwMDg0Y2JhMDkuLmViZDc2ZWExYzY5YiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2lycWNoaXAvaXJxLWFybWFkYS0zNzAteHAuYwo+ICsrKyBiL2RyaXZl cnMvaXJxY2hpcC9pcnEtYXJtYWRhLTM3MC14cC5jCj4gQEAgLTU0Niw2ICs1NDYsMTAgQEAgc3Rh dGljIHN0cnVjdCBpcnFfY2hpcCBhcm1hZGFfMzcwX3hwX2lycV9jaGlwID0gewo+ICBzdGF0aWMg aW50IGFybWFkYV8zNzBfeHBfbXBpY19pcnFfbWFwKHN0cnVjdCBpcnFfZG9tYWluICpoLAo+ICAJ CQkJICAgICAgdW5zaWduZWQgaW50IHZpcnEsIGlycV9od19udW1iZXJfdCBodykKPiAgewo+ICsJ LyogSVJRcyAwIGFuZCAxIGNhbm5vdCBiZSBtYXBwZWQsIHRoZXkgYXJlIGhhbmRsZWQgaW50ZXJu YWxseSAqLwo+ICsJaWYgKGh3IDw9IDEpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICAJYXJt YWRhXzM3MF94cF9pcnFfbWFzayhpcnFfZ2V0X2lycV9kYXRhKHZpcnEpKTsKPiAgCWlmICghaXNf cGVyY3B1X2lycShodykpCj4gIAkJd3JpdGVsKGh3LCBwZXJfY3B1X2ludF9iYXNlICsKPiAtLSAK PiAyLjIwLjEKPiAKPiAKCkdpdmVuIHRoYXQgdGhpcyBpcyBjb21wbGV0ZWx5IGFjYWRlbWljIGFu ZCBvYnZpb3VzbHkgZG9lc24ndCBhZmZlY3QKYW55b25lLCBJIGhhdmUgcmVtb3ZlZCB0aGUgQ2M6 IHN0YWJsZSBmcm9tIHRoZSBwYXRjaCB3aGVuIGFwcGx5aW5nIGl0LgoKCU0uCgotLSAKV2l0aG91 dCBkZXZpYXRpb24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=