From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13C46C433EF for ; Fri, 25 Mar 2022 08:19:42 +0000 (UTC) Received: from localhost ([::1]:47670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXfAb-0004KI-UA for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 04:19:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXf7z-00034b-0X for qemu-devel@nongnu.org; Fri, 25 Mar 2022 04:16:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXf7v-0001x0-J3 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 04:16:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648196214; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XoOKNvjj2vWDxyF7ffnwny5Y6LqscjN6R/Mgh0N0bXE=; b=cJZEZxElorQ/IqDqXI/SzjQWeKK0l7pulVYlwpalrNu4lAJSJp2uM+OBpeRAvJL9ecBjOe RLhZ85PZ2+FNPiSrz4CafISSxkZXAXLEH8MlWWyMh0TQPX3dK5vKzYCC6euFY7GVodDESg 9z572BG1aOvVVycPlecXNqB48bXvtn8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-DcAQRyHkM3y4TZgS20owKg-1; Fri, 25 Mar 2022 04:16:53 -0400 X-MC-Unique: DcAQRyHkM3y4TZgS20owKg-1 Received: by mail-wr1-f71.google.com with SMTP id p18-20020adfba92000000b001e8f7697cc7so2444521wrg.20 for ; Fri, 25 Mar 2022 01:16:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=lwOCm9uy0SJhZBHOauUhE1KdI2YgTHt0QQdRB9YjSqU=; b=D64tQZbetFfi0WRs2/Jw9o1d99CWZLCYRLjcqC4IJlkvUFYgHiukNRe1TBKndblgp+ bbZfLfJi6TBUgel8kNMhQg5t2IdJdiSEv/RsugpxUah1pIAo1OEHqudqc9dp9r47J6bH ZjJvw6phwOuwb32Uz453Cc2oz2eGN+KtyJCbJGgM8zW9+4ID7lMxQThMNfqtzPp5xZe/ W9tGU1fsfF7h+cSsSh8YKTqww1hlFIL4YehBDrHO/ppuVRhAnpon3vTo36jkGTMya9tc JNdtKd658rhPhIrYbQjRObu/YwuJ/DNsu+7RFYAGuifG33tUzSezHY9mF9IXrPypJX5u h65A== X-Gm-Message-State: AOAM533qaU5FaAkEMVkMXb6KqE7+v78EFllUQpSboQieUVghYbfR5HcG bypIkYFQNrVxwZCQR6ExeReViCkjFtaHRHFFae21iu/v+R4/Nl6r/BeT2F16HNKURnawlG0CbfT szqShaQ/MjEa6WUc= X-Received: by 2002:a5d:584f:0:b0:204:1749:2ce7 with SMTP id i15-20020a5d584f000000b0020417492ce7mr7905364wrf.584.1648196212055; Fri, 25 Mar 2022 01:16:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZcd2ZrK65RzkNpR2Y78SKa9wneAAYU7LYVgCN85ji7GZcSkxSPymDGyILfMaSIJpFsrs3GA== X-Received: by 2002:a5d:584f:0:b0:204:1749:2ce7 with SMTP id i15-20020a5d584f000000b0020417492ce7mr7905325wrf.584.1648196211800; Fri, 25 Mar 2022 01:16:51 -0700 (PDT) Received: from localhost ([47.63.10.52]) by smtp.gmail.com with ESMTPSA id m13-20020a05600c3b0d00b0038cda9f92fasm2453441wms.0.2022.03.25.01.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 01:16:51 -0700 (PDT) From: Juan Quintela To: marcandre.lureau@redhat.com Subject: Re: [PATCH 28/32] Move CPU softfloat unions to cpu-float.h In-Reply-To: <20220323155743.1585078-29-marcandre.lureau@redhat.com> (marcandre lureau's message of "Wed, 23 Mar 2022 19:57:39 +0400") References: <20220323155743.1585078-1-marcandre.lureau@redhat.com> <20220323155743.1585078-29-marcandre.lureau@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Fri, 25 Mar 2022 09:16:50 +0100 Message-ID: <87r16qe9al.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Peter Maydell , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Yoshinori Sato , Daniel Henrique Barboza , "open list:PowerPC TCG CPUs" , Artyom Tarasenko , Thomas Huth , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , "open list:S390 TCG CPUs" , "open list:ARM TCG CPUs" , =?utf-8?Q?C=C3=A9dric?= Le Goater , Stafford Horne , David Gibson , "open list:RISC-V TCG CPUs" , Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau > > The types are no longer used in bswap.h since commit > f930224fffe ("bswap.h: Remove unused float-access functions"), there > isn't much sense in keeping it there and having a dependency on fpu/. > > Signed-off-by: Marc-Andr=C3=A9 Lureau > diff --git a/migration/vmstate-types.c b/migration/vmstate-types.c > index bf4d440308ea..e83bfccb9ecf 100644 > --- a/migration/vmstate-types.c > +++ b/migration/vmstate-types.c > @@ -11,6 +11,7 @@ > */ > =20 > #include "qemu/osdep.h" > +#include "qemu/cpu-float.h" > #include "qemu-file.h" > #include "migration.h" > #include "migration/vmstate.h" Reviewed-by: Juan Quintela I think that the rest of the patch is also correct, but as there are other maintainers involved. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nXf80-000367-DT for mharc-qemu-riscv@gnu.org; Fri, 25 Mar 2022 04:17:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXf7y-00034L-Ax for qemu-riscv@nongnu.org; Fri, 25 Mar 2022 04:16:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:20422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXf7v-0001x5-Hg for qemu-riscv@nongnu.org; Fri, 25 Mar 2022 04:16:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648196214; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XoOKNvjj2vWDxyF7ffnwny5Y6LqscjN6R/Mgh0N0bXE=; b=cJZEZxElorQ/IqDqXI/SzjQWeKK0l7pulVYlwpalrNu4lAJSJp2uM+OBpeRAvJL9ecBjOe RLhZ85PZ2+FNPiSrz4CafISSxkZXAXLEH8MlWWyMh0TQPX3dK5vKzYCC6euFY7GVodDESg 9z572BG1aOvVVycPlecXNqB48bXvtn8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-241-WzLpd6h7Nxe_3V06ZBBIsg-1; Fri, 25 Mar 2022 04:16:53 -0400 X-MC-Unique: WzLpd6h7Nxe_3V06ZBBIsg-1 Received: by mail-wr1-f70.google.com with SMTP id e10-20020adf9bca000000b002059b6ffa18so1110477wrc.14 for ; Fri, 25 Mar 2022 01:16:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version :content-transfer-encoding; bh=lwOCm9uy0SJhZBHOauUhE1KdI2YgTHt0QQdRB9YjSqU=; b=XJMc41neQGK4lsEryHNRiR/8uglrd28caLVC48EC0dCWJ9ZK6q0CVzsC/MNNSKaMlq z1qcm4d0uotwNJ06MCNS1vRjcOnfsKp7YEJv92SJhI1cnhX0FmNXynjFvvSgNUAPPUDA ckwBPRxE/YaJdi/cpRtkDnKdc8ZeCiAsH/avr9Dp/NY7PW7bueAyVgBfDsa0+7Nq8onI nNZ8edbmheN8B+iRu4tjB3bZg/bh30glCg/rT1zBsdKiwC5uLwCKIbtyxHwyCqyDlxCX JidpheVGBJN/O/lia8Qcip/7bs1k0IN1/tG7CGgZrPyb/ichPH7mxIb1h0DsQAxtLT2v bq3g== X-Gm-Message-State: AOAM530bSWKfgrgQmMxY4sL5N0/rBtV3+hk0m43tE1F9RiZzwgunMMdD M6mK7v/2nCBYuBltESb8VkT2dGd8qzzmJ4u+7wAXJqD+XDJy9c2QnLED5Y+oI/jj5xlgJ9Cfz7V vhS1Qn6nNHmL1g4A= X-Received: by 2002:a5d:584f:0:b0:204:1749:2ce7 with SMTP id i15-20020a5d584f000000b0020417492ce7mr7905362wrf.584.1648196212051; Fri, 25 Mar 2022 01:16:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZcd2ZrK65RzkNpR2Y78SKa9wneAAYU7LYVgCN85ji7GZcSkxSPymDGyILfMaSIJpFsrs3GA== X-Received: by 2002:a5d:584f:0:b0:204:1749:2ce7 with SMTP id i15-20020a5d584f000000b0020417492ce7mr7905325wrf.584.1648196211800; Fri, 25 Mar 2022 01:16:51 -0700 (PDT) Received: from localhost ([47.63.10.52]) by smtp.gmail.com with ESMTPSA id m13-20020a05600c3b0d00b0038cda9f92fasm2453441wms.0.2022.03.25.01.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Mar 2022 01:16:51 -0700 (PDT) From: Juan Quintela To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Laurent Vivier , "Edgar E. Iglesias" , Stafford Horne , =?utf-8?Q?C=C3=A9dric?= Le Goater , Daniel Henrique Barboza , David Gibson , Greg Kurz , Palmer Dabbelt , Alistair Francis , Bin Meng , Yoshinori Sato , David Hildenbrand , Cornelia Huck , Thomas Huth , Mark Cave-Ayland , Artyom Tarasenko , Bastian Koppelmann , Max Filippov , qemu-arm@nongnu.org (open list:ARM TCG CPUs), qemu-ppc@nongnu.org (open list:PowerPC TCG CPUs), qemu-riscv@nongnu.org (open list:RISC-V TCG CPUs), qemu-s390x@nongnu.org (open list:S390 TCG CPUs) Subject: Re: [PATCH 28/32] Move CPU softfloat unions to cpu-float.h In-Reply-To: <20220323155743.1585078-29-marcandre.lureau@redhat.com> (marcandre lureau's message of "Wed, 23 Mar 2022 19:57:39 +0400") References: <20220323155743.1585078-1-marcandre.lureau@redhat.com> <20220323155743.1585078-29-marcandre.lureau@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Reply-To: quintela@redhat.com Date: Fri, 25 Mar 2022 09:16:50 +0100 Message-ID: <87r16qe9al.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 08:16:58 -0000 marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau > > The types are no longer used in bswap.h since commit > f930224fffe ("bswap.h: Remove unused float-access functions"), there > isn't much sense in keeping it there and having a dependency on fpu/. > > Signed-off-by: Marc-Andr=C3=A9 Lureau > diff --git a/migration/vmstate-types.c b/migration/vmstate-types.c > index bf4d440308ea..e83bfccb9ecf 100644 > --- a/migration/vmstate-types.c > +++ b/migration/vmstate-types.c > @@ -11,6 +11,7 @@ > */ > =20 > #include "qemu/osdep.h" > +#include "qemu/cpu-float.h" > #include "qemu-file.h" > #include "migration.h" > #include "migration/vmstate.h" Reviewed-by: Juan Quintela I think that the rest of the patch is also correct, but as there are other maintainers involved.