From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PULL for-7.1 04/36] os-posix: Use qemu_log_enabled
Date: Wed, 23 Mar 2022 16:41:28 +0000 [thread overview]
Message-ID: <87r16s4o5f.fsf@linaro.org> (raw)
In-Reply-To: <20220320171135.2704502-5-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> Do not reference qemu_logfile directly;
> use the predicate provided by qemu/log.h.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2022-03-23 16:47 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 17:10 [PULL for-7.1 00/36] Logging cleanup and per-thread logfiles Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 01/36] util/log: Drop manual log buffering Richard Henderson
2022-03-23 13:54 ` Alex Bennée
2022-03-20 17:11 ` [PULL for-7.1 02/36] target/hexagon: Remove qemu_set_log in hexagon_translate_init Richard Henderson
2022-03-23 13:56 ` Alex Bennée
2022-03-20 17:11 ` [PULL for-7.1 03/36] util/log: Pass Error pointer to qemu_set_log Richard Henderson
2022-03-20 21:50 ` Philippe Mathieu-Daudé
2022-03-20 17:11 ` [PULL for-7.1 04/36] os-posix: Use qemu_log_enabled Richard Henderson
2022-03-20 21:51 ` Philippe Mathieu-Daudé
2022-03-23 16:41 ` Alex Bennée [this message]
2022-03-20 17:11 ` [PULL for-7.1 05/36] util/log: Move qemu_log_lock, qemu_log_unlock out of line Richard Henderson
2022-03-20 21:52 ` Philippe Mathieu-Daudé
2022-03-23 16:42 ` Alex Bennée
2022-03-20 17:11 ` [PULL for-7.1 06/36] util/log: Treat qemu_log_lock like trylock Richard Henderson
2022-03-23 16:43 ` Alex Bennée
2022-03-20 17:11 ` [PULL for-7.1 07/36] hw/xen: Split out xen_pv_output_msg Richard Henderson
2022-03-23 17:19 ` Alex Bennée
2022-03-20 17:11 ` [PULL for-7.1 08/36] *: Use fprintf between qemu_log_lock/unlock Richard Henderson
2022-03-23 17:22 ` Alex Bennée
2022-03-23 20:46 ` Richard Henderson
2022-03-24 14:30 ` Alex Bennée
2022-03-25 15:00 ` Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 09/36] util/log: Remove qemu_log_vprintf Richard Henderson
2022-03-23 13:32 ` Alex Bennée
2022-03-23 16:36 ` Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 10/36] tcg: Pass the locked filepointer to tcg_dump_ops Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 11/36] exec/translator: Pass the locked filepointer to disas_log hook Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 12/36] exec/log: Remove log_disas and log_target_disas Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 13/36] accel/tcg: Use cpu_dump_state between qemu_log_lock/unlock Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 14/36] target/nios2: Remove log_cpu_state from reset Richard Henderson
2022-03-20 21:54 ` Philippe Mathieu-Daudé
2022-03-20 17:11 ` [PULL for-7.1 15/36] util/log: Use qemu_log_lock/unlock in qemu_log Richard Henderson
2022-03-23 17:28 ` Alex Bennée
2022-03-20 17:11 ` [PULL for-7.1 16/36] util/log: Remove qemu_log_flush Richard Henderson
2022-03-20 21:55 ` Philippe Mathieu-Daudé
2022-03-20 17:11 ` [PULL for-7.1 17/36] util/log: Drop call to setvbuf Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 18/36] bsd-user: Expand log_page_dump inline Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 19/36] linux-user: " Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 20/36] tests/unit: Do not reference QemuLogFile directly Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 21/36] include/exec/log: " Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 22/36] include/qemu/log: Move entire implementation out-of-line Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 23/36] sysemu/os-win32: Test for and use _lock_file/_unlock_file Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 24/36] util/log: Introduce qemu_set_log_filename_flags Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 25/36] bsd-user: Use qemu_set_log_filename_flags Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 26/36] linux-user: " Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 27/36] softmmu: " Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 28/36] util/log: Remove qemu_log_close Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 29/36] util/log: Rename logfilename to global_filename Richard Henderson
2022-03-20 21:59 ` Philippe Mathieu-Daudé
2022-03-20 17:11 ` [PULL for-7.1 30/36] util/log: Rename qemu_logfile to global_file Richard Henderson
2022-03-20 22:00 ` Philippe Mathieu-Daudé
2022-03-20 17:11 ` [PULL for-7.1 31/36] util/log: Rename qemu_logfile_mutex to global_mutex Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 32/36] util/log: Hoist the eval of is_daemonized in qemu_set_log_internal Richard Henderson
2022-03-20 21:58 ` Philippe Mathieu-Daudé
2022-03-20 17:11 ` [PULL for-7.1 33/36] util/log: Combine two logfile closes Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 34/36] util/log: Rename QemuLogFile to RCUCloseFILE Richard Henderson
2022-03-20 21:58 ` Philippe Mathieu-Daudé
2022-03-20 17:11 ` [PULL for-7.1 35/36] util/log: Limit RCUCloseFILE to file closing Richard Henderson
2022-03-20 17:11 ` [PULL for-7.1 36/36] util/log: Support per-thread log files Richard Henderson
2022-03-20 17:14 ` [PULL for-7.1 00/36] Logging cleanup and per-thread logfiles Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16s4o5f.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.