* [Buildroot] [PATCH 1/1] package/oprofile: drop custom install rules
@ 2022-03-07 22:33 Fabrice Fontaine
2022-03-08 12:46 ` Peter Korsgaard
2022-03-17 20:57 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-03-07 22:33 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Drop custom install rules which have added since commit
676797d57f33fbe9d5adc81932847154ebd1ce93. Indeed, they result in a
broken installation. Especially, they are trying to "guess" what must
be installed based on BR2_ARCH but oprofile has its own logic. For
example, goldmont microarchitecture files must be installed in i386
directory even if this architecture is 64 bits:
https://sourceforge.net/p/oprofile/oprofile/ci/0ad5a9e6af86a88e1dd41180f45bc48b646eba6a
This will result in the following runtime failure:
oprofile: could not open unit mask description file /usr/share/oprofile//i386/goldmont/unit_masks
Unable to find info for event cpu_clk_unhalted
Fixes:
- https://bugs.buildroot.org/show_bug.cgi?id=14641
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/oprofile/oprofile.mk | 41 ------------------------------------
1 file changed, 41 deletions(-)
diff --git a/package/oprofile/oprofile.mk b/package/oprofile/oprofile.mk
index 85bc4efa9b..265d6ebd18 100644
--- a/package/oprofile/oprofile.mk
+++ b/package/oprofile/oprofile.mk
@@ -14,51 +14,10 @@ OPROFILE_CONF_OPTS = \
--enable-gui=no \
--with-kernel=$(STAGING_DIR)/usr
-OPROFILE_BINARIES = \
- utils/ophelp pp/opannotate pp/oparchive pp/opgprof \
- pp/opreport opjitconv/opjitconv \
- utils/op-check-perfevents libabi/opimport \
- pe_counting/ocount pe_profiling/operf
-
-ifeq ($(BR2_i386),y)
-OPROFILE_ARCH = i386
-endif
-ifeq ($(BR2_mipsel),y)
-OPROFILE_ARCH = mips
-endif
-ifeq ($(BR2_powerpc),y)
-OPROFILE_ARCH = ppc
-endif
-ifeq ($(BR2_x86_64),y)
-OPROFILE_ARCH = x86-64
-endif
-ifeq ($(OPROFILE_ARCH),)
-OPROFILE_ARCH = $(BR2_ARCH)
-endif
-
OPROFILE_DEPENDENCIES = popt binutils host-pkgconf
ifeq ($(BR2_PACKAGE_LIBPFM4),y)
OPROFILE_DEPENDENCIES += libpfm4
endif
-ifeq ($(BR2_STATIC_LIBS),)
-define OPROFILE_INSTALL_SHARED_LIBRARY
- $(INSTALL) -m 755 $(@D)/libopagent/.libs/*.so* $(TARGET_DIR)/usr/lib/oprofile
-endef
-endif
-
-define OPROFILE_INSTALL_TARGET_CMDS
- $(INSTALL) -d -m 755 $(TARGET_DIR)/usr/bin
- $(INSTALL) -d -m 755 $(TARGET_DIR)/usr/share/oprofile
- $(INSTALL) -d -m 755 $(TARGET_DIR)/usr/lib/oprofile
- if [ -d $(@D)/events/$(OPROFILE_ARCH) ]; then \
- cp -dpfr $(@D)/events/$(OPROFILE_ARCH) \
- $(TARGET_DIR)/usr/share/oprofile; \
- fi
- $(INSTALL) -m 644 $(@D)/libregex/stl.pat $(TARGET_DIR)/usr/share/oprofile
- $(INSTALL) -m 755 $(addprefix $(@D)/, $(OPROFILE_BINARIES)) $(TARGET_DIR)/usr/bin
- $(OPROFILE_INSTALL_SHARED_LIBRARY)
-endef
-
$(eval $(autotools-package))
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/oprofile: drop custom install rules
2022-03-07 22:33 [Buildroot] [PATCH 1/1] package/oprofile: drop custom install rules Fabrice Fontaine
@ 2022-03-08 12:46 ` Peter Korsgaard
2022-03-17 20:57 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-03-08 12:46 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Drop custom install rules which have added since commit
> 676797d57f33fbe9d5adc81932847154ebd1ce93. Indeed, they result in a
> broken installation. Especially, they are trying to "guess" what must
> be installed based on BR2_ARCH but oprofile has its own logic. For
> example, goldmont microarchitecture files must be installed in i386
> directory even if this architecture is 64 bits:
> https://sourceforge.net/p/oprofile/oprofile/ci/0ad5a9e6af86a88e1dd41180f45bc48b646eba6a
> This will result in the following runtime failure:
> oprofile: could not open unit mask description file /usr/share/oprofile//i386/goldmont/unit_masks
> Unable to find info for event cpu_clk_unhalted
> Fixes:
> - https://bugs.buildroot.org/show_bug.cgi?id=14641
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
This might install a bit "too much", but Ok - Better than too
less. Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/oprofile: drop custom install rules
2022-03-07 22:33 [Buildroot] [PATCH 1/1] package/oprofile: drop custom install rules Fabrice Fontaine
2022-03-08 12:46 ` Peter Korsgaard
@ 2022-03-17 20:57 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-03-17 20:57 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Drop custom install rules which have added since commit
> 676797d57f33fbe9d5adc81932847154ebd1ce93. Indeed, they result in a
> broken installation. Especially, they are trying to "guess" what must
> be installed based on BR2_ARCH but oprofile has its own logic. For
> example, goldmont microarchitecture files must be installed in i386
> directory even if this architecture is 64 bits:
> https://sourceforge.net/p/oprofile/oprofile/ci/0ad5a9e6af86a88e1dd41180f45bc48b646eba6a
> This will result in the following runtime failure:
> oprofile: could not open unit mask description file
> /usr/share/oprofile//i386/goldmont/unit_masks
> Unable to find info for event cpu_clk_unhalted
> Fixes:
> - https://bugs.buildroot.org/show_bug.cgi?id=14641
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-17 20:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-07 22:33 [Buildroot] [PATCH 1/1] package/oprofile: drop custom install rules Fabrice Fontaine
2022-03-08 12:46 ` Peter Korsgaard
2022-03-17 20:57 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.