From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 779ABC433F5 for ; Sat, 9 Oct 2021 10:01:33 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB87360F70 for ; Sat, 9 Oct 2021 10:01:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB87360F70 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 80144839E6; Sat, 9 Oct 2021 10:01:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o-TnDyUeTl0O; Sat, 9 Oct 2021 10:01:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id E0DDD839CD; Sat, 9 Oct 2021 10:01:30 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id B00981BF27A for ; Sat, 9 Oct 2021 10:01:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id ACC5660B89 for ; Sat, 9 Oct 2021 10:01:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3YbP2sOhp7bq for ; Sat, 9 Oct 2021 10:01:27 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by smtp3.osuosl.org (Postfix) with ESMTPS id 63D1D60B88 for ; Sat, 9 Oct 2021 10:01:27 +0000 (UTC) Received: (Authenticated sender: peter@casa-korsgaard.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D1EA3E0002; Sat, 9 Oct 2021 10:01:23 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.92) (envelope-from ) id 1mZ9AQ-0002iV-NJ; Sat, 09 Oct 2021 12:01:22 +0200 From: Peter Korsgaard To: Arnout Vandecappelle References: <20210921205112.39176-1-petr.vorel@gmail.com> <20210930200402.GO1504958@scaer> <20211001180304.GV1504958@scaer> Date: Sat, 09 Oct 2021 12:01:22 +0200 In-Reply-To: (Arnout Vandecappelle's message of "Sun, 3 Oct 2021 11:49:24 +0200") Message-ID: <87r1cuwm8d.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [RFC PATCH 0/2] use `command -v' instead of `which' X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Yann E. MORIN" , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Arnout" == Arnout Vandecappelle writes: Hi, > From this, I actually conclude that it is indeed safer to go to > command -v, with a wrapper script that we add to $PATH to handle the > case where make tries to bypass the shell. If command is always a shell builtin and we already do the dance to find bash, how about just doing something like: $(shell $(SHELL) -c "command -v ...")? -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot