From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F790C433EF for ; Sat, 25 Sep 2021 21:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 583DC61051 for ; Sat, 25 Sep 2021 21:37:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbhIYVjG (ORCPT ); Sat, 25 Sep 2021 17:39:06 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:48740 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229993AbhIYVjF (ORCPT ); Sat, 25 Sep 2021 17:39:05 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632605848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pomYC2RreN2r1Fegwh7zApoZcyGO3FxxTvC2W51quWw=; b=DV3X8cyqLm9feMouLl0hl6IXL/8C3xFxSGPet+ZFBU38HSPov+Iywyz/cTgS/XO1DB5s66 dpJiqFpcarYXm2AVU6z3RgBBZzgcosZVJ7t/RKw7gW1FMmyj312Lph9JddFQzbLEFi9+F1 tjeQrWz6ojlD9y8qixeDEltAt1xzqo5607B7TF3ESI3CZBBTL8YXaluZa5A8LoRwJdEBt9 gJv4dcYlJ3HTre5F0I0R5p75HmVaJLOoV4mUlEQ29GQPAMfPAskw9Clxjj1Wcns5p+Bv+y daicTAdmA/8Fk7YFCKqijcpC3t+Q8yGLgmLqryXQclp2VwNxOXgyqSicVJv5zw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632605848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pomYC2RreN2r1Fegwh7zApoZcyGO3FxxTvC2W51quWw=; b=+dk6d0B8gKbC4x5WmHxGAcGDurd99AWeV90/l1woW0pVaoeX5FX8PN1zYithUUHRtWoBuD LWZjtgMGaLHXaIBg== To: Marc Zyngier , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Rob Herring , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Subject: Re: [PATCH 03/11] genirq: Export irq_set_affinity_locked() In-Reply-To: <87tui8cpwd.ffs@tglx> References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-4-f.fainelli@gmail.com> <87tui8ub87.wl-maz@kernel.org> <87tui8cpwd.ffs@tglx> Date: Sat, 25 Sep 2021 23:37:28 +0200 Message-ID: <87r1dccp5z.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On Sat, Sep 25 2021 at 23:21, Thomas Gleixner wrote: > On Sat, Sep 25 2021 at 12:48, Marc Zyngier wrote: >> On Fri, 24 Sep 2021 18:05:38 +0100, Florian Fainelli wrote: >>> } >>> +EXPORT_SYMBOL_GPL(irq_set_affinity_locked); >> >> This doesn't seem right. >> >> This driver seem to try and move interrupts on its own when the CPU >> goes down. Why can't it rely on the normal CPU hotplug infrastructure >> to do so like all the other drivers (bar some Cavium driver that does >> the same thing)? >> >> I'd rather you take this opportunity to move these drivers into the >> 21st century, so that we can kill irq_cpu_offline() and co altogether. > > I wanted to kill these callbacks years ago. Cavium has two variants of > those offline/online callbacks: > > 1) octeon_irq_cpu_offline_ciu() which is doing the same as that BCM > driver. These really can go away. Just remove the callback and > everything just works. For BCM this works today when that chip is used on ARM[64] simply because the only architecture which invokes irq_cpu_offline() is MIPS. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E625C433F5 for ; Sat, 25 Sep 2021 21:39:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32BDF60F5D for ; Sat, 25 Sep 2021 21:39:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32BDF60F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i7cRLzMPsZd54vFAS7TDkMoyjn2O/13lzY137AOaip4=; b=cOFfWi4/pzlCL2 HC/dUSeLxLERqpJmiZuAzXRb9UD5EaZbFY9HCPJ4kkEV2PE6Bg9UlOYeSPJoJdi36EuzdktdYpPF5 RCjPBH0D+cXxex3QxAZQTp6YKsPjxKhUxYkX01srDDzIKEmUXGIjCZ8IA36qxoWxBM1dElyjNemco GDQCzw1UdLEHQvD0nPhcdsG5c0hTmCEDR92WwiF9Ubv65m8OmubbwcuVnEwAUIIJq5bXfwI2Iu0V7 PsTcYxpM/38R1+FYF5JsDaWU3tM0DX51iKobXK7Xqx/D/Ge/EI+aYyHO/ud0OPtrkrzY50jsAL98L V/RdzRvxCNLs8KhQW8kA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUFMT-00HHJ0-8i; Sat, 25 Sep 2021 21:37:33 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUFMQ-00HHIO-84 for linux-arm-kernel@lists.infradead.org; Sat, 25 Sep 2021 21:37:31 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632605848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pomYC2RreN2r1Fegwh7zApoZcyGO3FxxTvC2W51quWw=; b=DV3X8cyqLm9feMouLl0hl6IXL/8C3xFxSGPet+ZFBU38HSPov+Iywyz/cTgS/XO1DB5s66 dpJiqFpcarYXm2AVU6z3RgBBZzgcosZVJ7t/RKw7gW1FMmyj312Lph9JddFQzbLEFi9+F1 tjeQrWz6ojlD9y8qixeDEltAt1xzqo5607B7TF3ESI3CZBBTL8YXaluZa5A8LoRwJdEBt9 gJv4dcYlJ3HTre5F0I0R5p75HmVaJLOoV4mUlEQ29GQPAMfPAskw9Clxjj1Wcns5p+Bv+y daicTAdmA/8Fk7YFCKqijcpC3t+Q8yGLgmLqryXQclp2VwNxOXgyqSicVJv5zw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632605848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pomYC2RreN2r1Fegwh7zApoZcyGO3FxxTvC2W51quWw=; b=+dk6d0B8gKbC4x5WmHxGAcGDurd99AWeV90/l1woW0pVaoeX5FX8PN1zYithUUHRtWoBuD LWZjtgMGaLHXaIBg== To: Marc Zyngier , Florian Fainelli Cc: linux-kernel@vger.kernel.org, Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Rob Herring , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" Subject: Re: [PATCH 03/11] genirq: Export irq_set_affinity_locked() In-Reply-To: <87tui8cpwd.ffs@tglx> References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-4-f.fainelli@gmail.com> <87tui8ub87.wl-maz@kernel.org> <87tui8cpwd.ffs@tglx> Date: Sat, 25 Sep 2021 23:37:28 +0200 Message-ID: <87r1dccp5z.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210925_143730_484473_6E719ED1 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 25 2021 at 23:21, Thomas Gleixner wrote: > On Sat, Sep 25 2021 at 12:48, Marc Zyngier wrote: >> On Fri, 24 Sep 2021 18:05:38 +0100, Florian Fainelli wrote: >>> } >>> +EXPORT_SYMBOL_GPL(irq_set_affinity_locked); >> >> This doesn't seem right. >> >> This driver seem to try and move interrupts on its own when the CPU >> goes down. Why can't it rely on the normal CPU hotplug infrastructure >> to do so like all the other drivers (bar some Cavium driver that does >> the same thing)? >> >> I'd rather you take this opportunity to move these drivers into the >> 21st century, so that we can kill irq_cpu_offline() and co altogether. > > I wanted to kill these callbacks years ago. Cavium has two variants of > those offline/online callbacks: > > 1) octeon_irq_cpu_offline_ciu() which is doing the same as that BCM > driver. These really can go away. Just remove the callback and > everything just works. For BCM this works today when that chip is used on ARM[64] simply because the only architecture which invokes irq_cpu_offline() is MIPS. Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel