From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC876C433EF for ; Thu, 16 Sep 2021 18:26:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE3A7611C4 for ; Thu, 16 Sep 2021 18:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345347AbhIPS1n (ORCPT ); Thu, 16 Sep 2021 14:27:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:39690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244880AbhIPS0y (ORCPT ); Thu, 16 Sep 2021 14:26:54 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5603F611EE; Thu, 16 Sep 2021 18:25:32 +0000 (UTC) Received: from [198.52.44.129] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mQw4g-00BEGF-8r; Thu, 16 Sep 2021 19:25:30 +0100 Date: Thu, 16 Sep 2021 19:25:27 +0100 Message-ID: <87r1dobco8.wl-maz@kernel.org> From: Marc Zyngier To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sasha Levin Subject: Re: [PATCH 5.13 345/380] KVM: arm64: vgic: move irq->get_input_level into an ops structure In-Reply-To: <20210916155815.779126002@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> <20210916155815.779126002@linuxfoundation.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 198.52.44.129 X-SA-Exim-Rcpt-To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, sashal@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Sep 2021 17:01:42 +0100, Greg Kroah-Hartman wrote: > > From: Marc Zyngier > > [ Upstream commit db75f1a33f82ad332b6e139c5960e01999969d2c ] > > We already have the option to attach a callback to an interrupt > to retrieve its pending state. As we are planning to expand this > facility, move this callback into its own data structure. > > This will limit the size of individual interrupts as the ops > structures can be shared across multiple interrupts. > > Signed-off-by: Marc Zyngier > Signed-off-by: Sasha Levin > --- > arch/arm64/kvm/arch_timer.c | 8 ++++++-- > arch/arm64/kvm/vgic/vgic.c | 14 +++++++------- > include/kvm/arm_vgic.h | 28 +++++++++++++++++----------- > 3 files changed, 30 insertions(+), 20 deletions(-) As I replied to Sasha earlier, I don't see a good reason to backport this, as it doesn't improve anything on its own. Unless there is a compelling reason to get this backported, I'd rather see it dropped. Thanks, M. -- Without deviation from the norm, progress is not possible.