All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Yuan Fang <fangyuanseu@gmail.com>, linux-usb@vger.kernel.org
Cc: Yuan Fang <yuan.fang@verisilicon.com>
Subject: Re: [PATCH] drivers/usb/dwc3: Set PHY ready after soft reset done
Date: Fri, 11 Jun 2021 16:02:37 +0300	[thread overview]
Message-ID: <87r1h8zh8y.fsf@kernel.org> (raw)
In-Reply-To: <20210611071805.9169-1-yuan.fang@verisilicon.com>

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Yuan Fang <fangyuanseu@gmail.com> writes:

> It's more safe to set PHY ready after soft reset done
>
> Let's consider a test case like this:
> I have a usb PHY which don't need SW initial before access
> it, But i have a wrong PHY clock default setting in PHY
> register which means PHY is not ready in fact.
> in dwc3_core_init, dwc3_core_get_phy will return 0 despite
> usb get PHYs with return -ENODEV, and set phys_ready=true

your PHY driver shouldn't return -ENODEV here. Why are you returning
-ENODEV? The PHY isn't ready but it _does_ exist.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]

  parent reply	other threads:[~2021-06-11 13:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11  7:18 [PATCH] drivers/usb/dwc3: Set PHY ready after soft reset done Yuan Fang
2021-06-11  7:25 ` Greg KH
2021-06-11  7:34   ` 答复: " Fang, Yuan
2021-06-11 13:02 ` Felipe Balbi [this message]
2021-06-16  2:55   ` Fang, Yuan
2021-06-29  2:42   ` Fang, Yuan
2021-09-07 11:01   ` Fang, Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1h8zh8y.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=fangyuanseu@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=yuan.fang@verisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.