All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: Caleb Connolly <caleb@connolly.tech>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Felipe Balbi <felipe.balbi@microsoft.com>
Subject: Re: [PATCH v3] arm64: boot: dts: qcom: sm8150: add SPI nodes
Date: Fri, 16 Apr 2021 18:22:44 +0300	[thread overview]
Message-ID: <87r1jameyj.fsf@kernel.org> (raw)
In-Reply-To: <0688f0cc-55f1-4450-c86a-5e661a85310b@connolly.tech>


Hi,

Caleb Connolly <caleb@connolly.tech> writes:
>> From: Felipe Balbi <felipe.balbi@microsoft.com>
>>
>> Add missing SPI nodes for SM8150.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@microsoft.com>
>> ---
>>
>> changes since v2:
>> 	- switch to new pinctrl format
>>
>> Changes since v1:
>>
>> 	- avoid modifying drive strength on i2c. No functional
>>            changes, just keeping 0x02 instead of 2
>>
>>   arch/arm64/boot/dts/qcom/sm8150.dtsi | 439 +++++++++++++++++++++++++++
>>   1 file changed, 439 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> index 7207a3689d9d..c563f381a138 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
>> @@ -602,6 +602,21 @@ i2c0: i2c@880000 {
>>   				status = "disabled";
>>   			};
>>
>> +			spi0: spi@880000 {
>> +				compatible = "qcom,geni-spi";
>> +				reg = <0 0x880000 0 0x4000>;
>> +				reg-names = "se";
>
> I don't think we need the reg-names property on any of these.

true, but it doesn't hurt either :-) I can remove, but I'll wait before
spinning another revision

> Otherwise,
>
> Reviewed-by: Caleb Connolly <caleb@connolly.tech>

Thanks

-- 
balbi

  reply	other threads:[~2021-04-16 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 10:32 [PATCH v3] arm64: boot: dts: qcom: sm8150: add SPI nodes Felipe Balbi
2021-04-16 14:40 ` Caleb Connolly
2021-04-16 15:22   ` Felipe Balbi [this message]
2021-04-16 18:47 ` Konrad Dybcio
2021-04-17 12:04 ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1jameyj.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=caleb@connolly.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=felipe.balbi@microsoft.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.