From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6CDDC43331 for ; Tue, 31 Mar 2020 13:29:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83D0D20714 for ; Tue, 31 Mar 2020 13:29:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K5DMzEBD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83D0D20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJGxY-000555-Kn for qemu-devel@archiver.kernel.org; Tue, 31 Mar 2020 09:29:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42325) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJGro-0002I5-7I for qemu-devel@nongnu.org; Tue, 31 Mar 2020 09:23:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJGrn-0006nc-2I for qemu-devel@nongnu.org; Tue, 31 Mar 2020 09:23:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:47147 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJGrm-0006nF-UX for qemu-devel@nongnu.org; Tue, 31 Mar 2020 09:23:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585661022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q9AV3zmhXly1oADjwZuu9kxsW2xfs8rViy6qV1bZpxU=; b=K5DMzEBDQXrLNNyS1HnV/RDQv0fUV7ABzYJtSKcnSkSQVnoRX2VVYErDvz7RmL9rR3+Qw1 B5NyVOiVUfOfBHH51xv/Kl3C18mrUbpvJ7K1TyDuTug6ZfCOep/8h/Jm80N8a4NMRZcTnI XLZ00xsVXqo92MMwka9uBDzrwmjbEso= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-WSZlPJq2NmafmNw_DWvElw-1; Tue, 31 Mar 2020 09:23:36 -0400 X-MC-Unique: WSZlPJq2NmafmNw_DWvElw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29FD6DBB1; Tue, 31 Mar 2020 13:23:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-69.ams2.redhat.com [10.36.112.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2A335C21B; Tue, 31 Mar 2020 13:23:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4EE0A11385E2; Tue, 31 Mar 2020 15:23:23 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code References: <20200325191830.16553-1-f4bug@amsat.org> Date: Tue, 31 Mar 2020 15:23:23 +0200 In-Reply-To: <20200325191830.16553-1-f4bug@amsat.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 25 Mar 2020 20:18:18 +0100") Message-ID: <87r1x8vet0.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , qemu-devel@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , Aleksandar Markovic , qemu-ppc@nongnu.org, Aleksandar Rikalo , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Andrew Baumann , Jean-Christophe Dubois , Palmer Dabbelt , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > This series is inspired of Peter fix: > "hw/arm/xlnx-zynqmp.c: fix some error-handling code" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691636.html > > Add a cocci script to fix the other places. > > Based-on: <20200324134947.15384-1-peter.maydell@linaro.org> I skimmed the code patches [PATCH 02-12/12], and they look like bug fixes. Other reviewers raised a few issues. I also skimmed the Coccinelle script [PATCH 01]. Peter pointed out a few things it apparently missed (e.g. in review of PATCH 06+11). Moreover, the bug pattern applies beyond object_property_set() & friends. Perhaps the script can be generalized. No reason to hold fixes. We may want to add suitable notes to the scipt, though. Can you address the reviews in a v2, so we can get the fixes into -rc1, due today? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jJGrr-0002RY-Jr for mharc-qemu-riscv@gnu.org; Tue, 31 Mar 2020 09:23:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42335) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jJGro-0002JP-MT for qemu-riscv@nongnu.org; Tue, 31 Mar 2020 09:23:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jJGrn-0006oL-E8 for qemu-riscv@nongnu.org; Tue, 31 Mar 2020 09:23:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:21794 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jJGrn-0006nn-B5 for qemu-riscv@nongnu.org; Tue, 31 Mar 2020 09:23:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585661023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q9AV3zmhXly1oADjwZuu9kxsW2xfs8rViy6qV1bZpxU=; b=T21MuzDulVjqDISWtPl73R7rEe8jSqkxIGj5686RBZtpXLL+ry9BxOKnJ8YfIA+t08va0p AENYdzLm5mlSWJPXq57InMJKLip1xTG6D6aBUWuukckHRVwYpq90E4YgBEuhQXYgMN1CqS exrIYI8XFT9NlgofbGAyxag7Hj0wDVY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-WSZlPJq2NmafmNw_DWvElw-1; Tue, 31 Mar 2020 09:23:36 -0400 X-MC-Unique: WSZlPJq2NmafmNw_DWvElw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29FD6DBB1; Tue, 31 Mar 2020 13:23:31 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-69.ams2.redhat.com [10.36.112.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E2A335C21B; Tue, 31 Mar 2020 13:23:24 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4EE0A11385E2; Tue, 31 Mar 2020 15:23:23 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Paul Burton , Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , Aleksandar Markovic , Palmer Dabbelt , Aleksandar Rikalo , Richard Henderson , Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= , Eduardo Habkost , Alistair Francis , qemu-arm@nongnu.org, David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Andrew Baumann , Jean-Christophe Dubois , qemu-ppc@nongnu.org, Paolo Bonzini , Aurelien Jarno Subject: Re: [PATCH-for-5.0 00/12] hw: Add missing error-propagation code References: <20200325191830.16553-1-f4bug@amsat.org> Date: Tue, 31 Mar 2020 15:23:23 +0200 In-Reply-To: <20200325191830.16553-1-f4bug@amsat.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 25 Mar 2020 20:18:18 +0100") Message-ID: <87r1x8vet0.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 13:23:46 -0000 Philippe Mathieu-Daud=C3=A9 writes: > This series is inspired of Peter fix: > "hw/arm/xlnx-zynqmp.c: fix some error-handling code" > https://www.mail-archive.com/qemu-devel@nongnu.org/msg691636.html > > Add a cocci script to fix the other places. > > Based-on: <20200324134947.15384-1-peter.maydell@linaro.org> I skimmed the code patches [PATCH 02-12/12], and they look like bug fixes. Other reviewers raised a few issues. I also skimmed the Coccinelle script [PATCH 01]. Peter pointed out a few things it apparently missed (e.g. in review of PATCH 06+11). Moreover, the bug pattern applies beyond object_property_set() & friends. Perhaps the script can be generalized. No reason to hold fixes. We may want to add suitable notes to the scipt, though. Can you address the reviews in a v2, so we can get the fixes into -rc1, due today?