From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B803FC10F27 for ; Mon, 9 Mar 2020 01:31:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BB562064A for ; Mon, 9 Mar 2020 01:31:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgCIBbE (ORCPT ); Sun, 8 Mar 2020 21:31:04 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:24988 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726346AbgCIBbD (ORCPT ); Sun, 8 Mar 2020 21:31:03 -0400 Date: 09 Mar 2020 10:31:01 +0900 X-IronPort-AV: E=Sophos;i="5.70,530,1574089200"; d="scan'208";a="41113966" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 09 Mar 2020 10:31:01 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 76F41400857C; Mon, 9 Mar 2020 10:31:01 +0900 (JST) Message-ID: <87r1y2wbze.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Laurent Pinchart Cc: Alex Riesen , Geert Uytterhoeven , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Rob Herring , Mark Rutland , Driver Development , Linux Media , Linux Kernel , Device Tree , Renesas SoC Subject: Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC In-Reply-To: <20200306134546.GE4878@pendragon.ideasonboard.com> References: <20200302134011.GA3717@pflmari> <20200302150706.GB3717@pflmari> <20200302160906.GC3717@pflmari> <20200305143628.GB25741@pflmari> <20200306131632.GA4878@pendragon.ideasonboard.com> <20200306134154.GD27714@pflmari> <20200306134546.GE4878@pendragon.ideasonboard.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > > > Those clocks are part of the CSI-2 protocol and also don't need to be > > > explicitly controlled. As far as I can tell from a quick check of the > > > ADV7482 documentation, only the I2S MCLK is a general-purpose clock that > > > needs to be exposed. (snip) > > Do you know, by chance, which of the snd_soc* callbacks should be used to > > implement setting of the MCLK? The one in snd_soc_component_driver or > > snd_soc_dai_driver->ops (snd_soc_dai_ops)? > > > > Or how the userspace interface looks like? Or, if there is no userspace > > interface for this, how the MCLK is supposed to be set? Through mclk-fs? > > I'm afraid my knowledge of the sound subsystem is limited. Morimoto-san > is the main developer and maintainer of Renesas sound drivers. > Morimoto-sensei, would you have an answer to that question ? :-) In my quick check, it goes to AUDIO_CLKC. If so, you can update rcar_sound::clocks. &rcar_sound { ... - /* update to */ + /* update to , + * to */ clocks = <&cpg CPG_MOD 1005>, ... <&audio_clk_a>, <&cs2000>, - <&audio_clk_c>, + <&adv748x>, <&cpg CPG_CORE CPG_AUDIO_CLK_I>; Thank you for your help !! Best regards --- Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D23C10DCE for ; Mon, 9 Mar 2020 01:36:10 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 618602064A for ; Mon, 9 Mar 2020 01:36:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 618602064A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1A5EC88172; Mon, 9 Mar 2020 01:36:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1ac2u6Klw+mQ; Mon, 9 Mar 2020 01:36:09 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 0AF4988175; Mon, 9 Mar 2020 01:36:09 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D5B581BF36A for ; Mon, 9 Mar 2020 01:36:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CA33A20502 for ; Mon, 9 Mar 2020 01:36:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mmlkKCM4l+TF for ; Mon, 9 Mar 2020 01:36:06 +0000 (UTC) X-Greylist: delayed 00:05:03 by SQLgrey-1.7.6 Received: from relmlie6.idc.renesas.com (relmlor2.renesas.com [210.160.252.172]) by silver.osuosl.org (Postfix) with ESMTP id 61E1F204BD for ; Mon, 9 Mar 2020 01:36:06 +0000 (UTC) Date: 09 Mar 2020 10:31:01 +0900 X-IronPort-AV: E=Sophos;i="5.70,530,1574089200"; d="scan'208";a="41113966" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 09 Mar 2020 10:31:01 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 76F41400857C; Mon, 9 Mar 2020 10:31:01 +0900 (JST) Message-ID: <87r1y2wbze.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Laurent Pinchart Subject: Re: [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC In-Reply-To: <20200306134546.GE4878@pendragon.ideasonboard.com> References: <20200302134011.GA3717@pflmari> <20200302150706.GB3717@pflmari> <20200302160906.GC3717@pflmari> <20200305143628.GB25741@pflmari> <20200306131632.GA4878@pendragon.ideasonboard.com> <20200306134154.GD27714@pflmari> <20200306134546.GE4878@pendragon.ideasonboard.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Driver Development , Device Tree , Kieran Bingham , Linux Kernel , Renesas SoC , Rob Herring , Geert Uytterhoeven , Hans Verkuil , Mauro Carvalho Chehab , Linux Media Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi > > > Those clocks are part of the CSI-2 protocol and also don't need to be > > > explicitly controlled. As far as I can tell from a quick check of the > > > ADV7482 documentation, only the I2S MCLK is a general-purpose clock that > > > needs to be exposed. (snip) > > Do you know, by chance, which of the snd_soc* callbacks should be used to > > implement setting of the MCLK? The one in snd_soc_component_driver or > > snd_soc_dai_driver->ops (snd_soc_dai_ops)? > > > > Or how the userspace interface looks like? Or, if there is no userspace > > interface for this, how the MCLK is supposed to be set? Through mclk-fs? > > I'm afraid my knowledge of the sound subsystem is limited. Morimoto-san > is the main developer and maintainer of Renesas sound drivers. > Morimoto-sensei, would you have an answer to that question ? :-) In my quick check, it goes to AUDIO_CLKC. If so, you can update rcar_sound::clocks. &rcar_sound { ... - /* update to */ + /* update to , + * to */ clocks = <&cpg CPG_MOD 1005>, ... <&audio_clk_a>, <&cs2000>, - <&audio_clk_c>, + <&adv748x>, <&cpg CPG_CORE CPG_AUDIO_CLK_I>; Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel