From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0DAC2D0C6 for ; Wed, 11 Dec 2019 14:05:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1066521556 for ; Wed, 11 Dec 2019 14:05:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KloWcJzx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730009AbfLKOFF (ORCPT ); Wed, 11 Dec 2019 09:05:05 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57014 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729877AbfLKOFE (ORCPT ); Wed, 11 Dec 2019 09:05:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576073104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=StIwrr6DiPVKFPlnlboJLDOKadEa6n2fz2fdl4s30Mo=; b=KloWcJzxNpTbGWkzxgV/Vlu43XIVCVxJqsWdBZfZw+OdRPsJ7ReUdcF3QLcFPf5w4QJyQ0 W1cRx9+LFLO+vDZuaiFvfLkdmEl7etOsv78thcxYgjyNpMqTTGWBJbBBKobUPuvqXCxMP3 Uz7HFopCg6RyMbUwOdfqMtL7IkRNEos= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-fTyIQK5zM8iOs85_FO1R-Q-1; Wed, 11 Dec 2019 09:05:02 -0500 Received: by mail-lf1-f72.google.com with SMTP id q16so5064384lfa.13 for ; Wed, 11 Dec 2019 06:05:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=rXYd5E3GGY67cV6y2ES2WF64lJpRnllNrekC9v/TCy0=; b=DSm9U0TQuweTNfZVOD8i8PuCQZ21icUogSs9ZYy+Elhot9YAixAZYi2Cm7xISufN24 4Qdc4eSaVkNZpHHCbMiEwbCEccWx0y7GbX+PlsRr6dZZIwNeAWG87XENuQetv4AZtezR iHLySWdYK2Rj7LsV+h0icfaKW+nYLcpaHWbcHPp+mWJjwM6B9dn9RigKWON0cf6wkciP jLJd/4R4Zzw/6XtXLOp2vgk8pvTswbigEMEnfDsW85XFR+X5cMQj1ATvM8k4PFnV40gO 9y6ooHB0dK7j4RWrapIyRVmnhbiR0/1ZDz15lIoVLy2QEINaOV4kM2hcWDONx6VwjO5j BLOw== X-Gm-Message-State: APjAAAWxg8akL9C13usKfQgwq6eBQZEfQEErh0yB+cq8z9eb+BqBm2Lm DBJzQuJOT5rFopjTenAhIl0mQNiGsBWMSqWL7vhsijsTCwl0wM5D0gYL6fVcMZK9oJ/VSwpjlrK VrRQ1kaLEtVnAwgl+Nhcs8R4FwTQ= X-Received: by 2002:a05:651c:327:: with SMTP id b7mr2168410ljp.22.1576073101107; Wed, 11 Dec 2019 06:05:01 -0800 (PST) X-Google-Smtp-Source: APXvYqxnPP5sggaD4AQ3op+KNXfSHW0erfYVnF+khRRz45HXniArvp0gpfieBpJJzB4ogPT5qbBV9A== X-Received: by 2002:a05:651c:327:: with SMTP id b7mr2168398ljp.22.1576073100955; Wed, 11 Dec 2019 06:05:00 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id z13sm1247604ljh.21.2019.12.11.06.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 06:05:00 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8623318033F; Wed, 11 Dec 2019 15:04:59 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Jens Axboe , Emmanuel Grumbach , Luca Coelho Cc: "linux-wireless\@vger.kernel.org" , Networking Subject: Re: iwlwifi warnings in 5.5-rc1 In-Reply-To: <14bbfcc8408500704c46701251546e7ff65c6fd0.camel@sipsolutions.net> References: <9727368004ceef03f72d259b0779c2cf401432e1.camel@sipsolutions.net> <878snjgs5l.fsf@toke.dk> <3420d73e667b01ec64bf0cc9da6232b41e862860.camel@sipsolutions.net> <875zingnzt.fsf@toke.dk> <14bbfcc8408500704c46701251546e7ff65c6fd0.camel@sipsolutions.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 11 Dec 2019 15:04:59 +0100 Message-ID: <87r21bez5g.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: fTyIQK5zM8iOs85_FO1R-Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > Btw, there's *another* issue. You said in the commit log: > > This patch does *not* include any mechanism to wake a throttled TXQ a= gain, > on the assumption that this will happen anyway as a side effect of wh= atever > freed the skb (most commonly a TX completion). > > Thinking about this some more, I'm not convinced that this assumption > holds. You could have been stopped due to the global limit, and now you > wake some queue but the TXQ is empty - now you should reschedule some > *other* TXQ since the global limit had kicked in, not the per-TXQ limit, > and prevented dequeuing, no? Well if you hit the global limit that means you have 24ms worth of data queued in the hardware; those should be completed in turn, and enable more to be dequeued, no? -Toke