Annaliese McDermond writes: >> On May 27, 2019, at 12:15 PM, Wolfram Sang wrote: >> >> Regardless which solution is favoured, I am going to apply this patch in >> a minute: >> >> http://patchwork.ozlabs.org/patch/1097688/ >> >> It enables this driver for ARCH_BRCMSTB. So, the solution should work >> for this as well. (I don't know any of these platforms well) > > I did some looking the other day, and I had forgotten that the RPi has 3 > of the i2c-bcm2835 devices each with their own divider that sits in their > register space. This makes me think the correct solution would be for > the divider to be controlled in the driver as was in my original patch. > Otherwise we’d have to make three different dividers in the bcm2835-clk > driver, and the i2c driver would no longer work for other platforms. Control of the divider should definitely be in the i2c driver, not in clk-bcm2835.