From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v2] i2c: bcm2835: Model Divider in CCF Date: Tue, 28 May 2019 15:25:53 -0700 Message-ID: <87r28ijjwu.fsf@anholt.net> References: <20190508071227.18609-1-nh6z@nh6z.net> <4174B26B-4E3A-4CCA-A5ED-BE62A3B5E66A@nh6z.net> <20190516075848.GA1033@kunai> <2E6EDCD1-E0B1-4859-BD75-EF411D3D4C6B@nh6z.net> <20190527191534.GD8808@kunai> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6583301510921339892==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Annaliese McDermond , Wolfram Sang Cc: Stefan Wahren , Florian Fainelli , swarren@wwwdotorg.org, NWDR Team , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org List-Id: linux-i2c@vger.kernel.org --===============6583301510921339892== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Annaliese McDermond writes: >> On May 27, 2019, at 12:15 PM, Wolfram Sang wrote: >>=20 >> Regardless which solution is favoured, I am going to apply this patch in >> a minute: >>=20 >> http://patchwork.ozlabs.org/patch/1097688/ >>=20 >> It enables this driver for ARCH_BRCMSTB. So, the solution should work >> for this as well. (I don't know any of these platforms well) > > I did some looking the other day, and I had forgotten that the RPi has 3 > of the i2c-bcm2835 devices each with their own divider that sits in their > register space. This makes me think the correct solution would be for > the divider to be controlled in the driver as was in my original patch. > Otherwise we=E2=80=99d have to make three different dividers in the bcm28= 35-clk > driver, and the i2c driver would no longer work for other platforms. Control of the divider should definitely be in the i2c driver, not in clk-bcm2835. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlzttXIACgkQtdYpNtH8 nuiAbg//X0j7M7BOUJsCvwPSJpLQIHbCOYkYw5Ei6i+7Qz0SEnTtCGPVkXkBGC3A ZtKw5mR5T114FxhJL3GS40LwcUoW6nowzgaxop06/HCGCBP6pA98JRgbWhWznXHi vCkhqBhK9gNsD+JbW8RqDQ10YovQJg6poZ9f6fehxhPl37Vts2HV70RtKaenV8FO xoo1gw1wtcapre6nA7k1wy10+7DRAD3GVlCPu7vK29+Ih9sZcYkYLHmf6leIAQUp 2qM0lZkzGcW24O0vqCFW9g2vU2PXiebLzGQVq6s0s0oV11zXjilCAgP3C0Z8hj6P +iqwQeUFFQGrzaN+okFp/O9f84caHuDF4btgboZ+zqgSvIVi5ZxWYa9EDdlnM3pK HdYb5Nqcf+0rggfhj+L5EsIr1gO8w38JUT30KigbPnYb2Ps/lRrGFvqUnY1mnUCR tE9CUa793+/j2JS9ETX1bo6yJph6JtlqIHqLq/rED0PxbPjAIRHx8dj7RsIpFuCD /Ifk2KOzF/POKktZhXS0NYw2OQZaF8CPhs/bwiRix95WQlS3oF69DG4VKmI0V+0J p6MHf1EZrGr3k23x9+poohIcEN7zpeaYA/SOULdhoKxTT7BWNRrJ9QS1gQ51wY6E tZIMOXIBzptS4GoHjeeTm00GszKJsOMJQn4TeMWbf0WW6TvjPiQ= =I88g -----END PGP SIGNATURE----- --=-=-=-- --===============6583301510921339892== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6583301510921339892==--