From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Juan Quintela <quintela@redhat.com>,
qemu-trivial@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tests: Do not use "\n" in g_test_message() strings
Date: Mon, 04 Mar 2019 08:18:25 +0100 [thread overview]
Message-ID: <87r2bncdku.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1551457277-884-1-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Fri, 1 Mar 2019 17:21:17 +0100")
Thomas Huth <thuth@redhat.com> writes:
> g_test_message() takes care of the newline on its own, so we
> should not use \n in the strings here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Without "[PATCH] tests: Remove (mostly) useless architecture checks",
the patch misses four instances of '\n', so:
Based-on: <1551456970-463-1-git-send-email-thuth@redhat.com>
next prev parent reply other threads:[~2019-03-04 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 16:21 [Qemu-devel] [PATCH] tests: Do not use "\n" in g_test_message() strings Thomas Huth
2019-03-04 7:18 ` Markus Armbruster [this message]
2019-03-05 17:25 ` Stefan Hajnoczi
2019-03-06 9:15 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2bncdku.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.