From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753065AbdFUQWS convert rfc822-to-8bit (ORCPT ); Wed, 21 Jun 2017 12:22:18 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:39725 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbdFUQWO (ORCPT ); Wed, 21 Jun 2017 12:22:14 -0400 From: Gregory CLEMENT To: Marc Zyngier , Thomas Petazzoni Cc: Thomas Gleixner , Jason Cooper , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Ian Campbell , Pawel Moll , Mark Rutland , Kumar Gala , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Nadav Haklai , Hanna Hawa , Yehuda Yitschak , Antoine Tenart , =?utf-8?Q?Miqu?= =?utf-8?Q?=C3=A8l?= Raynal Subject: Re: [PATCH v5 0/6] Add support for the ICU unit in Marvell Armada 7K/8K References: <20170621132917.14187-1-thomas.petazzoni@free-electrons.com> <20170621171809.34bcce1e@windsurf.home> Date: Wed, 21 Jun 2017 17:42:18 +0200 In-Reply-To: <20170621171809.34bcce1e@windsurf.home> (Thomas Petazzoni's message of "Wed, 21 Jun 2017 17:18:09 +0200") Message-ID: <87r2yd1h5x.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc and Thomas, On mer., juin 21 2017, Thomas Petazzoni wrote: > Hello, > > On Wed, 21 Jun 2017 16:14:21 +0100, Marc Zyngier wrote: > >> > Thomas Petazzoni (6): >> > dt-bindings: interrupt-controller: add DT binding for the Marvell GICP >> > dt-bindings: interrupt-controller: add DT binding for the Marvell ICU >> > irqchip: irq-mvebu-gicp: new driver for Marvell GICP >> > irqchip: irq-mvebu-icu: new driver for Marvell ICU >> > arm64: marvell: enable ICU and GICP drivers >> > arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K >> > >> > .../bindings/interrupt-controller/marvell,gicp.txt | 27 ++ >> > .../bindings/interrupt-controller/marvell,icu.txt | 51 ++++ >> > arch/arm64/Kconfig.platforms | 2 + >> > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 7 + >> > .../boot/dts/marvell/armada-cp110-master.dtsi | 59 +++-- >> > .../arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 55 ++-- >> > drivers/irqchip/Kconfig | 6 + >> > drivers/irqchip/Makefile | 2 + >> > drivers/irqchip/irq-mvebu-gicp.c | 279 ++++++++++++++++++++ >> > drivers/irqchip/irq-mvebu-gicp.h | 12 + >> > drivers/irqchip/irq-mvebu-icu.c | 289 +++++++++++++++++++++ >> > .../dt-bindings/interrupt-controller/mvebu-icu.h | 15 ++ >> > 12 files changed, 756 insertions(+), 48 deletions(-) >> > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,gicp.txt >> > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt >> > create mode 100644 drivers/irqchip/irq-mvebu-gicp.c >> > create mode 100644 drivers/irqchip/irq-mvebu-gicp.h >> > create mode 100644 drivers/irqchip/irq-mvebu-icu.c >> > create mode 100644 include/dt-bindings/interrupt-controller/mvebu-icu.h >> > >> >> It all looks good to me. How do we merge this? I take the first five >> patches and Gregory takes the last one? > > I think you should take the first four patches, and Grégory takes the > last two ones. But I'll let Grégory confirm. Indeed it makes more sens to merge the patch 4 through the arm-soc subsystem. Thanks, Gregory > > Once again, thanks a lot for your help on this series, it's in a much > better shape now compared to what the original submission was! > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH v5 0/6] Add support for the ICU unit in Marvell Armada 7K/8K Date: Wed, 21 Jun 2017 17:42:18 +0200 Message-ID: <87r2yd1h5x.fsf@free-electrons.com> References: <20170621132917.14187-1-thomas.petazzoni@free-electrons.com> <20170621171809.34bcce1e@windsurf.home> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170621171809.34bcce1e@windsurf.home> (Thomas Petazzoni's message of "Wed, 21 Jun 2017 17:18:09 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marc Zyngier , Thomas Petazzoni Cc: Mark Rutland , devicetree@vger.kernel.org, Yehuda Yitschak , Jason Cooper , Pawel Moll , Ian Campbell , Hanna Hawa , =?utf-8?Q?Miqu?= =?utf-8?Q?=C3=A8l?= Raynal , linux-kernel@vger.kernel.org, Nadav Haklai , Rob Herring , Andrew Lunn , Kumar Gala , Thomas Gleixner , Antoine Tenart , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org SGkgTWFyYyBhbmQgVGhvbWFzLAogCiBPbiBtZXIuLCBqdWluIDIxIDIwMTcsIFRob21hcyBQZXRh enpvbmkgPHRob21hcy5wZXRhenpvbmlAZnJlZS1lbGVjdHJvbnMuY29tPiB3cm90ZToKCj4gSGVs bG8sCj4KPiBPbiBXZWQsIDIxIEp1biAyMDE3IDE2OjE0OjIxICswMTAwLCBNYXJjIFp5bmdpZXIg d3JvdGU6Cj4KPj4gPiBUaG9tYXMgUGV0YXp6b25pICg2KToKPj4gPiAgIGR0LWJpbmRpbmdzOiBp bnRlcnJ1cHQtY29udHJvbGxlcjogYWRkIERUIGJpbmRpbmcgZm9yIHRoZSBNYXJ2ZWxsIEdJQ1AK Pj4gPiAgIGR0LWJpbmRpbmdzOiBpbnRlcnJ1cHQtY29udHJvbGxlcjogYWRkIERUIGJpbmRpbmcg Zm9yIHRoZSBNYXJ2ZWxsIElDVQo+PiA+ICAgaXJxY2hpcDogaXJxLW12ZWJ1LWdpY3A6IG5ldyBk cml2ZXIgZm9yIE1hcnZlbGwgR0lDUAo+PiA+ICAgaXJxY2hpcDogaXJxLW12ZWJ1LWljdTogbmV3 IGRyaXZlciBmb3IgTWFydmVsbCBJQ1UKPj4gPiAgIGFybTY0OiBtYXJ2ZWxsOiBlbmFibGUgSUNV IGFuZCBHSUNQIGRyaXZlcnMKPj4gPiAgIGFybTY0OiBkdHM6IG1hcnZlbGw6IGVuYWJsZSBHSUNQ IGFuZCBJQ1Ugb24gQXJtYWRhIDdLLzhLCj4+ID4gCj4+ID4gIC4uLi9iaW5kaW5ncy9pbnRlcnJ1 cHQtY29udHJvbGxlci9tYXJ2ZWxsLGdpY3AudHh0IHwgIDI3ICsrCj4+ID4gIC4uLi9iaW5kaW5n cy9pbnRlcnJ1cHQtY29udHJvbGxlci9tYXJ2ZWxsLGljdS50eHQgIHwgIDUxICsrKysKPj4gPiAg YXJjaC9hcm02NC9LY29uZmlnLnBsYXRmb3JtcyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIg Kwo+PiA+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL21hcnZlbGwvYXJtYWRhLWFwODA2LmR0c2kgICAg ICB8ICAgNyArCj4+ID4gIC4uLi9ib290L2R0cy9tYXJ2ZWxsL2FybWFkYS1jcDExMC1tYXN0ZXIu ZHRzaSAgICAgIHwgIDU5ICsrKy0tCj4+ID4gIC4uLi9hcm02NC9ib290L2R0cy9tYXJ2ZWxsL2Fy bWFkYS1jcDExMC1zbGF2ZS5kdHNpIHwgIDU1ICsrLS0KPj4gPiAgZHJpdmVycy9pcnFjaGlwL0tj b25maWcgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDYgKwo+PiA+ICBkcml2ZXJzL2ly cWNoaXAvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMiArCj4+ID4gIGRy aXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtZ2ljcC5jICAgICAgICAgICAgICAgICAgIHwgMjc5ICsr KysrKysrKysrKysrKysrKysrCj4+ID4gIGRyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtZ2ljcC5o ICAgICAgICAgICAgICAgICAgIHwgIDEyICsKPj4gPiAgZHJpdmVycy9pcnFjaGlwL2lycS1tdmVi dS1pY3UuYyAgICAgICAgICAgICAgICAgICAgfCAyODkgKysrKysrKysrKysrKysrKysrKysrCj4+ ID4gIC4uLi9kdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9tdmVidS1pY3UuaCAgIHwg IDE1ICsrCj4+ID4gIDEyIGZpbGVzIGNoYW5nZWQsIDc1NiBpbnNlcnRpb25zKCspLCA0OCBkZWxl dGlvbnMoLSkKPj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9tYXJ2ZWxsLGdpY3AudHh0Cj4+ID4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaW50ZXJy dXB0LWNvbnRyb2xsZXIvbWFydmVsbCxpY3UudHh0Cj4+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBk cml2ZXJzL2lycWNoaXAvaXJxLW12ZWJ1LWdpY3AuYwo+PiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQg ZHJpdmVycy9pcnFjaGlwL2lycS1tdmVidS1naWNwLmgKPj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvaXJxY2hpcC9pcnEtbXZlYnUtaWN1LmMKPj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGluY2x1ZGUvZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvbXZlYnUtaWN1LmgKPj4g PiAgIAo+PiAKPj4gSXQgYWxsIGxvb2tzIGdvb2QgdG8gbWUuIEhvdyBkbyB3ZSBtZXJnZSB0aGlz PyBJIHRha2UgdGhlIGZpcnN0IGZpdmUKPj4gcGF0Y2hlcyBhbmQgR3JlZ29yeSB0YWtlcyB0aGUg bGFzdCBvbmU/Cj4KPiBJIHRoaW5rIHlvdSBzaG91bGQgdGFrZSB0aGUgZmlyc3QgZm91ciBwYXRj aGVzLCBhbmQgR3LDqWdvcnkgdGFrZXMgdGhlCj4gbGFzdCB0d28gb25lcy4gQnV0IEknbGwgbGV0 IEdyw6lnb3J5IGNvbmZpcm0uCgpJbmRlZWQgaXQgbWFrZXMgbW9yZSBzZW5zIHRvIG1lcmdlIHRo ZSBwYXRjaCA0IHRocm91Z2ggdGhlIGFybS1zb2MKc3Vic3lzdGVtLgoKVGhhbmtzLAoKR3JlZ29y eQo+Cj4gT25jZSBhZ2FpbiwgdGhhbmtzIGEgbG90IGZvciB5b3VyIGhlbHAgb24gdGhpcyBzZXJp ZXMsIGl0J3MgaW4gYSBtdWNoCj4gYmV0dGVyIHNoYXBlIG5vdyBjb21wYXJlZCB0byB3aGF0IHRo ZSBvcmlnaW5hbCBzdWJtaXNzaW9uIHdhcyEKPgo+IEJlc3QgcmVnYXJkcywKPgo+IFRob21hcwo+ IC0tIAo+IFRob21hcyBQZXRhenpvbmksIENUTywgRnJlZSBFbGVjdHJvbnMKPiBFbWJlZGRlZCBM aW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCj4gaHR0cDovL2ZyZWUtZWxlY3Ryb25zLmNvbQoK LS0gCkdyZWdvcnkgQ2xlbWVudCwgRnJlZSBFbGVjdHJvbnMKS2VybmVsLCBkcml2ZXJzLCByZWFs LXRpbWUgYW5kIGVtYmVkZGVkIExpbnV4CmRldmVsb3BtZW50LCBjb25zdWx0aW5nLCB0cmFpbmlu ZyBhbmQgc3VwcG9ydC4KaHR0cDovL2ZyZWUtZWxlY3Ryb25zLmNvbQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 21 Jun 2017 17:42:18 +0200 Subject: [PATCH v5 0/6] Add support for the ICU unit in Marvell Armada 7K/8K In-Reply-To: <20170621171809.34bcce1e@windsurf.home> (Thomas Petazzoni's message of "Wed, 21 Jun 2017 17:18:09 +0200") References: <20170621132917.14187-1-thomas.petazzoni@free-electrons.com> <20170621171809.34bcce1e@windsurf.home> Message-ID: <87r2yd1h5x.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Marc and Thomas, On mer., juin 21 2017, Thomas Petazzoni wrote: > Hello, > > On Wed, 21 Jun 2017 16:14:21 +0100, Marc Zyngier wrote: > >> > Thomas Petazzoni (6): >> > dt-bindings: interrupt-controller: add DT binding for the Marvell GICP >> > dt-bindings: interrupt-controller: add DT binding for the Marvell ICU >> > irqchip: irq-mvebu-gicp: new driver for Marvell GICP >> > irqchip: irq-mvebu-icu: new driver for Marvell ICU >> > arm64: marvell: enable ICU and GICP drivers >> > arm64: dts: marvell: enable GICP and ICU on Armada 7K/8K >> > >> > .../bindings/interrupt-controller/marvell,gicp.txt | 27 ++ >> > .../bindings/interrupt-controller/marvell,icu.txt | 51 ++++ >> > arch/arm64/Kconfig.platforms | 2 + >> > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 7 + >> > .../boot/dts/marvell/armada-cp110-master.dtsi | 59 +++-- >> > .../arm64/boot/dts/marvell/armada-cp110-slave.dtsi | 55 ++-- >> > drivers/irqchip/Kconfig | 6 + >> > drivers/irqchip/Makefile | 2 + >> > drivers/irqchip/irq-mvebu-gicp.c | 279 ++++++++++++++++++++ >> > drivers/irqchip/irq-mvebu-gicp.h | 12 + >> > drivers/irqchip/irq-mvebu-icu.c | 289 +++++++++++++++++++++ >> > .../dt-bindings/interrupt-controller/mvebu-icu.h | 15 ++ >> > 12 files changed, 756 insertions(+), 48 deletions(-) >> > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,gicp.txt >> > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/marvell,icu.txt >> > create mode 100644 drivers/irqchip/irq-mvebu-gicp.c >> > create mode 100644 drivers/irqchip/irq-mvebu-gicp.h >> > create mode 100644 drivers/irqchip/irq-mvebu-icu.c >> > create mode 100644 include/dt-bindings/interrupt-controller/mvebu-icu.h >> > >> >> It all looks good to me. How do we merge this? I take the first five >> patches and Gregory takes the last one? > > I think you should take the first four patches, and Gr?gory takes the > last two ones. But I'll let Gr?gory confirm. Indeed it makes more sens to merge the patch 4 through the arm-soc subsystem. Thanks, Gregory > > Once again, thanks a lot for your help on this series, it's in a much > better shape now compared to what the original submission was! > > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com