From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:48867 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbdFBIZb (ORCPT ); Fri, 2 Jun 2017 04:25:31 -0400 From: Felipe Balbi To: Thinh Nguyen , Thinh Nguyen , "linux-usb\@vger.kernel.org" Cc: John Youn , "stable\@vger.kernel.org" Subject: Re: [PATCH 2/3] usb: dwc3: gadget: Fix early exit in set/clear ep halt In-Reply-To: <30102591E157244384E984126FC3CB4F30071006@us01wembx1.internal.synopsys.com> References: <8760icg2zx.fsf@linux.intel.com> <8737dgg2w8.fsf@linux.intel.com> <20e1cce1-d3b7-e126-88aa-b2c823cc4b8b@synopsys.com> <87o9w3cs6b.fsf@linux.intel.com> <1f5a4ed8-fa79-e644-ce34-1125023d69ba@synopsys.com> <87tw5ub1ti.fsf@linux.intel.com> <30102591E157244384E984126FC3CB4F3005E00F@us01wembx1.internal.synopsys.com> <30102591E157244384E984126FC3CB4F30071006@us01wembx1.internal.synopsys.com> Date: Fri, 02 Jun 2017 11:24:53 +0300 Message-ID: <87r2z2vlt6.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Thinh Nguyen writes: >>>>> this could be, I don't remember if I checked this or not :-) >>>>> >>>>> Really, the best way here, IMHO, would be to re-verify what's going on >>>>> with macOS and revert my orignal patch since it's, rather clearly, >>>>> wrong. >>>>> >>>> >>>> Sure. Are you going to make a revert patch or I am? >>> >>> Well, after we really know what's going on with macOS and have a better >>> fix, then who makes the revert is less important as long as problems get >>> sorted out :-) Either way is fine for me. >>> >>=20 >> Do you have any update on this issue? >>=20 > > The patch ffb80fc672c3 ("usb: dwc3: gadget: skip Set/Clear Halt when=20 > invalid") still causes a regression for us. As there hasn't any update=20 > for the macOS issue, can I submit a revert patch for this? I just came back from vacations ;-) I'll get back to this. Reverting that commit won't do any good as we'd be exchanging one regression for another. We really need to understand what's going on. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlkxINUACgkQzL64meEa mQawRw//b8eT+LCXbCeF12vN8dWqPI8nPYYPgBf7wULBu4quog392iWIprNGkh9c 2CPWOrTumv3anHTd9NOpq2sLiYFiGscgsL4MCdXd65G9HPM0BpHedoaXI+4rOcQn dnodeKW1j5+6ZHa81M8uJBUm3tOT+VApnugWPZ8UpvBAjl55DMIsF5riqd3vD/K+ KwW5HxbBOtnwLB3XGYjmqh2gRLAJkzs0y8pa4WhaXvq05M8ou5LxQG63iechK5VJ VWPfTJ8nFjqp3YtBY7iC5J21B4h+zgcBY87XHnHAx5ugjiL5s3RzTtjXa7Rkc6/e iixoZgHSXVk4JpOS+TvB4Ej0m6qE3n44rVIa82fjOTvAFY5mionzjmnjbEzfjbLL KAJZFEtnA0fLVxiCliqMc0ERGTLveoM0acUuEB4CzGdBKWV0kl6r/REHDK/X1NH2 towczcWLjH+ffo8o/oLpvuPYLci/AZqBliGjzy6nUdsOVNQcwa0vwM7NvQnItzc8 oOAXSxhflT0tHuHt1xSAQufqk24A6qEEmcqlTG9X5nO7AAcL1K7cg7D8hDOsEMN0 vI9fhgDKbt/t9DTjO7koje6qTX+MJzho4Ewh8CtQSFgur3eXp7G9jriYMFaQhAW/ X6jk4UrdSQ4ssDhU3Uu2aVq2bkCBd472jBU1S0MJKLL2CPTCGtw= =dl+F -----END PGP SIGNATURE----- --=-=-=--