From: Michael Ellerman <mpe@ellerman.id.au>
To: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Michael Bringmann <mwb@linux.vnet.ibm.com>,
paulus@samba.org, sahilmehta17@gmail.com,
jallen@linux.vnet.ibm.com, alastair@d-silva.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/hotplug-mem: Fix aa_index match bug for hotplug
Date: Wed, 31 May 2017 14:03:21 +1000 [thread overview]
Message-ID: <87r2z54qra.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <b50a28ec-ae33-82f8-eefd-0e20e15c2dfb@linux.vnet.ibm.com>
Nathan Fontenot <nfont@linux.vnet.ibm.com> writes:
> On 05/30/2017 06:41 AM, Michael Ellerman wrote:
>> Michael Bringmann <mwb@linux.vnet.ibm.com> writes:
>>> When adding or removing memory, the aa_index (affinity value) for the
>>> memblock must also be converted to match the endianness of the rest
>>> of the 'ibm,dynamic-memory' property. Otherwise, subsequent retrieval
>>> of the attribute will likely lead to non-existent nodes, followed by
>>> using the default node in the code inappropriately.
>>>
>>> Signed-off-by: Michael Bringmann <mwb@linux.vnet.ibm.com>
>>>
>>> diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/powerpc/platforms/pseries/hotplug-memory.c
>>> index e104c71..1fb162b 100644
>>> --- a/arch/powerpc/platforms/pseries/hotplug-memory.c
>>> +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c
>>> @@ -124,6 +124,7 @@ static struct property *dlpar_clone_drconf_property(struct device_node *dn)
>>> for (i = 0; i < num_lmbs; i++) {
>>> lmbs[i].base_addr = be64_to_cpu(lmbs[i].base_addr);
>>> lmbs[i].drc_index = be32_to_cpu(lmbs[i].drc_index);
>>> + lmbs[i].aa_index = be32_to_cpu(lmbs[i].aa_index);
>>> lmbs[i].flags = be32_to_cpu(lmbs[i].flags);
>>> }
>>>
>>
>> AFAICS this code was added in commit 5f97b2a0d176 ("powerpc/pseries:
>> Implement memory hotplug add in the kernel").
>>
>> So this should probably be marked:
>>
>> Fixes: 5f97b2a0d176 ("powerpc/pseries: Implement memory hotplug add in the kernel")
>>
>> And it seems like a bug we'd want fixed in stable, so:
>>
>> Cc: stable@vger.kernel.org # v4.1+
>>
>> Am I right?
>
> Yes, that is correct.
Thanks.
cheers
next prev parent reply other threads:[~2017-05-31 4:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 20:44 [PATCH] powerpc/hotplug-mem: Fix aa_index match bug for hotplug Michael Bringmann
2017-05-30 11:41 ` Michael Ellerman
2017-05-30 17:35 ` Nathan Fontenot
2017-05-31 4:03 ` Michael Ellerman [this message]
2017-06-01 13:31 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2z54qra.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=alastair@d-silva.org \
--cc=jallen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mwb@linux.vnet.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=sahilmehta17@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.