All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] scripts/qmp/qom-set: fix the value argument passed to srv.command()
Date: Tue, 16 May 2017 13:21:07 +0200	[thread overview]
Message-ID: <87r2zpm4ik.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <149373610338.5144.9635049015143453288.stgit@bahia.lan> (Greg Kurz's message of "Tue, 02 May 2017 16:41:43 +0200")

Greg Kurz <groug@kaod.org> writes:

> When invoking the script with -s, we end up passing a bogus value
> to QEMU:
>
> $ ./scripts/qmp/qom-set -s /var/tmp/qmp-sock-exp /machine.accel kvm
> {}
> $ ./scripts/qmp/qom-get -s /var/tmp/qmp-sock-exp /machine.accel
> /var/tmp/qmp-sock-exp
>
> This happens because sys.argv[2] isn't necessarily the command line
> argument that holds the value. It is sys.argv[4] when -s was also
> passed.
>
> Actually, the code already has a variable to handle that. This patch
> simply uses it.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied to qapi-next, thanks!

      parent reply	other threads:[~2017-05-16 11:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02 14:41 [Qemu-devel] [PATCH] scripts/qmp/qom-set: fix the value argument passed to srv.command() Greg Kurz
2017-05-02 19:46 ` Philippe Mathieu-Daudé
2017-05-10 15:51 ` Markus Armbruster
2017-05-16 11:21 ` Markus Armbruster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2zpm4ik.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.