All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/hiredis: fix installation logic of library
Date: Mon, 24 Apr 2017 21:23:23 +0200	[thread overview]
Message-ID: <87r30hwqxg.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170412193436.95F9C80270@busybox.osuosl.org> (Thomas Petazzoni's message of "Wed, 12 Apr 2017 21:34:12 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=96daacb720cffe1f83259462bef9d3da92925cd9
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > While testing minetest with libhiredis library, the game crached due to
 > missing libhiredis.so.0.13 library.

 > The hiredis.mk doesn't use "make install" because "make install" depends
 > on building both the shared and static libraries, which fails in
 > static-only scenarios.

 > However, the installation logic in hiredis.mk is bogus: it installs the
 > library as libhiredis.so, while its SONAME is libhiredis.so.0.13. We fix
 > this by using the same logic as the one done by the package "make
 > install" process: install the library as libhiredis.so.0.13, and create
 > libhiredis.so as a symbolic link to it.

 > While at it:

 >  - Install the library 0755, this is more common.

 >  - Do not create $(TARGET_DIR)/usr/lib, since $(INSTALL) -D will create
 >    the necessary directories for the destination path.

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > [Thomas: rework to use the same installation logic as the one from
 > hiredis "make install".]
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2017-04-24 19:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 19:34 [Buildroot] [git commit] package/hiredis: fix installation logic of library Thomas Petazzoni
2017-04-24 19:23 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r30hwqxg.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.