From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751702AbdBUPnW (ORCPT ); Tue, 21 Feb 2017 10:43:22 -0500 Received: from mga03.intel.com ([134.134.136.65]:54552 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbdBUPnK (ORCPT ); Tue, 21 Feb 2017 10:43:10 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,190,1484035200"; d="scan'208";a="1132901599" From: Felipe Balbi To: Heikki Krogerus , Greg KH Cc: Guenter Roeck , Oliver Neukum , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v17 0/3] USB Type-C Connector class In-Reply-To: <20170221142405.76299-1-heikki.krogerus@linux.intel.com> References: <20170221142405.76299-1-heikki.krogerus@linux.intel.com> Date: Tue, 21 Feb 2017 17:42:35 +0200 Message-ID: <87r32rpn2s.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Heikki Krogerus writes: > The USB Type-C class is meant to provide unified interface to the > userspace to present the USB Type-C ports in a system. > > Changes since v16: > - Using PTR_ERR_OR_ZERO macro in typec_init(). > > Changes since v15: > - "stingification" as proposed by Felipe > - Checking ARRAY_SIZE in supported_accessory_modes() as proposed by Guenter > > Changes since v14: > - Fixes proposed by Mika > - "identity" directory for all discover identity VDOs instead of "vdo" attribute > - alternate mode device names to just "svid-" > > Changes since v13: > - New API. Everything is registered separately. > > Changes since v12: > - Added prefer_role member to typec_capability structure as requested by Guenter > > Changes since v11: > - The port drivers are responsible of removing the alternate > modes (just like the documentation already said). > > Changes since v10: > - Using ATTRIBUTE_GROUPS and DEVICE_ATTR marcos everywhere > - Moved sysfs_match_string to lib/string.c > - Rationalized uevents > - Calling ida_destroy > > Changes since v9: > - Minor typec_wcove.c cleanup as proposed by Guenter Roeck. No > function affect. > > Changes since v8: > - checking sysfs_streq() result correctly in sysfs_strmatch > - fixed accessory check in supported_accessory_mode > - using "none" as the only string that can clear the preferred role > > Changes since v7: > - Removed "type" attribute from partners > - Added supports_usb_power_delivery attribute for partner and cable > > Changes since v6: > - current_vconn_role attr renamed to vconn_source (no API changes) > - Small documentation improvements proposed by Vincent Palatin > > Changes since v5: > - Only updating the roles based on driver notifications > - Added MODULE_ALIAS for the WhiskeyCove module > - Including the patch that creates the actual platform device for the > WhiskeyCove Type-C PHY in this series. > > Changes since v4: > - Remove the port lock completely > > Changes since v3: > - Documentation cleanup as proposed by Roger Quadros > - Setting partner altmodes member to NULL on removal and fixing a > warning, as proposed by Guenter Roeck > - Added the following attributes for partners and cables: > * supports_usb_power_delivery > * id_header_vdo > - "id_header_vdo" is visible only when the partner or cable supports > USB Power Delivery communication. > - Partner attribute "accessory" is hidden when the partner type is not > "Accessory". > > Changes since v2: > - Notification on role and alternate mode changes > - cleanups > > Changes since v1: > - Completely rewrote alternate mode support > - Patners, cables and cable plugs presented as devices. > > > Heikki Krogerus (3): > lib/string: add sysfs_match_string helper > usb: USB Type-C connector class > usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY Just to clarify one thing here: wherever it says "Reviewed-by: Felipe Balbi..." you could also read "Reviewed-and-Tested-by: Felipe Balbi..." as I have been running these patches for past few months to test code on Intel Joule. -- balbi