From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIczT-0007yZ-Ef
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 10:30:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIczN-00008c-5e
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 10:30:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43742)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bIczM-00008Y-Ve
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 10:30:45 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1467291213-13393-1-git-send-email-armbru@redhat.com>
	<1467291213-13393-2-git-send-email-armbru@redhat.com>
	<52f14da8-1ddc-fd17-2ddd-4eedddcec4e9@redhat.com>
Date: Thu, 30 Jun 2016 16:30:42 +0200
In-Reply-To: <52f14da8-1ddc-fd17-2ddd-4eedddcec4e9@redhat.com> (Paolo
	Bonzini's message of "Thu, 30 Jun 2016 15:27:05 +0200")
Message-ID: <87r3be3g19.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH RFC v3 1/5] tests: New make target
 check-source
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, silbe@linux.vnet.ibm.com

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 30/06/2016 14:53, Markus Armbruster wrote:
>> +bad-header-comment := /* FIXME Does not pass make check-headers$(bad-header-with-y), yet!
>> +bad-headers := $(shell cd $(SRC_PATH) && fgrep -l '$(bad-header-comment)' $(src-headers))
>> +bad-headers += $(shell fgrep -l '$(bad-header-comment)' $(gen-headers))
>> +# Headers that require -DNEED_CPU_H etc.
>> +target-header-comment := /* NOTE: May only be included into target-dependent code */
>
> Perhaps accept a "FIXME" as well here?  You don't have to use the right
> one in the patch of course.

Makes sense.

I guess the same argument could be made for the other magic comments.

>> diff --git a/target-sparc/cpu-qom.h b/target-sparc/cpu-qom.h
>> index f63af72..30d112c 100644
>> --- a/target-sparc/cpu-qom.h
>> +++ b/target-sparc/cpu-qom.h
>> @@ -17,6 +17,9 @@
>>   * License along with this library; if not, see
>>   * <http://www.gnu.org/licenses/lgpl-2.1.html>
>>   */
>> +
>> +/* NOTE: May only be included into target-dependent code */
>
> This shouldn't be true for cpu-qom.h.
>
> Perhaps
> Paolo

Here's what made me mark the header:

    $ make tests/headers/target-sparc/cpu-qom.o
    [...]
      CC    tests/headers/target-sparc/cpu-qom.o
    In file included from tests/headers/target-sparc/cpu-qom.c:14:0:
    /work/armbru/qemu/target-sparc/cpu-qom.h:28:8: error: attempt to use poisoned "TARGET_SPARC64"
     #ifdef TARGET_SPARC64
            ^
    /work/armbru/qemu/rules.mak:59: recipe for target 'tests/headers/target-sparc/cpu-qom.o' failed
    make: *** [tests/headers/target-sparc/cpu-qom.o] Error 1

Error context:

    #ifdef TARGET_SPARC64
    #define TYPE_SPARC_CPU "sparc64-cpu"
    #else
    #define TYPE_SPARC_CPU "sparc-cpu"
    #endif