From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIFlf-0002Go-Ke for qemu-devel@nongnu.org; Wed, 29 Jun 2016 09:43:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIFlb-0006L0-Vi for qemu-devel@nongnu.org; Wed, 29 Jun 2016 09:43:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIFlb-0006Kh-PT for qemu-devel@nongnu.org; Wed, 29 Jun 2016 09:42:59 -0400 From: Markus Armbruster References: <1466403224-16604-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1466403224-16604-13-git-send-email-caoj.fnst@cn.fujitsu.com> Date: Wed, 29 Jun 2016 15:42:57 +0200 In-Reply-To: <1466403224-16604-13-git-send-email-caoj.fnst@cn.fujitsu.com> (Cao jin's message of "Mon, 20 Jun 2016 14:13:43 +0800") Message-ID: <87r3bgw1pa.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 12/13] e1000e: remove unnecessary internal msi state flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: qemu-devel@nongnu.org, Dmitry Fleytman , Marcel Apfelbaum , Jason Wang , "Michael S. Tsirkin" Cao jin writes: > Internal big flag E1000E_USE_MSI is unnecessary, also is the helper > function: e1000e_init_msi(), e1000e_cleanup_msi(), so, remove them all. > > cc: Dmitry Fleytman > cc: Jason Wang > cc: Markus Armbruster > cc: Marcel Apfelbaum > cc: Michael S. Tsirkin > > Signed-off-by: Cao jin Reviewed-by: Markus Armbruster