From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj4Gl-0006wt-VJ for qemu-devel@nongnu.org; Thu, 24 Mar 2016 08:21:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aj4Gg-0006qV-23 for qemu-devel@nongnu.org; Thu, 24 Mar 2016 08:21:43 -0400 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:37298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aj4Gf-0006qD-Km for qemu-devel@nongnu.org; Thu, 24 Mar 2016 08:21:37 -0400 Received: by mail-wm0-x22a.google.com with SMTP id p65so63074966wmp.0 for ; Thu, 24 Mar 2016 05:21:37 -0700 (PDT) References: <1458815961-31979-1-git-send-email-sergey.fedorov@linaro.org> <56F3D088.4090709@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <56F3D088.4090709@redhat.com> Date: Thu, 24 Mar 2016 12:21:35 +0000 Message-ID: <87r3f0qd68.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/8] tcg: Direct block chaining clean-up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Sergey Fedorov , Richard Henderson , qemu-devel@nongnu.org, sergey.fedorov@linaro.org, Peter Crosthwaite Paolo Bonzini writes: > On 24/03/2016 11:39, sergey.fedorov@linaro.org wrote: >> From: Sergey Fedorov >> >> This series combines a set of patches which is meant to improve overall code >> structure and readability of direct block chaining mechanism. The other point >> is to make a step towards thread safety of TB chainig. >> >> The series' tree can be found in a public git repository [1]. >> >> [1] https://github.com/sergefdrv/qemu/tree/tb-chaining-cleanup > > Looks good. > > Alex, can you give it a shake? There is still time to include it in 2.6 > before soft freeze. OK then, I'll start looking after lunch ;-) > > Paolo > >> Sergey Fedorov (8): >> tcg: Clean up direct block chaining data fields >> tcg: Use uintptr_t type for jmp_list_{next|first} fields of TB >> tcg: Rearrange tb_link_page() to avoid forward declaration >> tcg: Init TB's direct jumps before making it visible >> tcg: Clarify "thread safaty" check in tb_add_jump() >> tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list() >> tcg: Extract removing of jumps to TB from tb_phys_invalidate() >> tcg: Clean up tb_jmp_unlink() >> >> include/exec/exec-all.h | 51 +++++--- >> tcg/aarch64/tcg-target.inc.c | 7 +- >> tcg/arm/tcg-target.inc.c | 8 +- >> tcg/i386/tcg-target.inc.c | 8 +- >> tcg/ia64/tcg-target.inc.c | 6 +- >> tcg/mips/tcg-target.inc.c | 8 +- >> tcg/ppc/tcg-target.inc.c | 6 +- >> tcg/s390/tcg-target.inc.c | 11 +- >> tcg/sparc/tcg-target.inc.c | 9 +- >> tcg/tcg.h | 6 +- >> tcg/tci/tcg-target.inc.c | 10 +- >> translate-all.c | 290 ++++++++++++++++++++++--------------------- >> 12 files changed, 224 insertions(+), 196 deletions(-) >> -- Alex Bennée