From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxAJ4-0003JD-QH for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:06:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxAJ1-0008JQ-Js for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:06:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxAJ1-0008JM-En for qemu-devel@nongnu.org; Fri, 13 Nov 2015 04:06:03 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D5D4EC0EF9AE for ; Fri, 13 Nov 2015 09:06:02 +0000 (UTC) From: Markus Armbruster References: <1447354243-31825-1-git-send-email-eblake@redhat.com> <1447399522.1400.71.camel@redhat.com> Date: Fri, 13 Nov 2015 10:05:59 +0100 In-Reply-To: <1447399522.1400.71.camel@redhat.com> (Gerd Hoffmann's message of "Fri, 13 Nov 2015 08:25:22 +0100") Message-ID: <87r3ju5kw8.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-2.5 v2] input: Document why x-input-send-event is still experimental List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > On Do, 2015-11-12 at 11:50 -0700, Eric Blake wrote: >> The x-input-send-event command was introduced in 2.2 with mention >> that it is experimental, but now that several releases have elapsed >> without any changes, it would be nice to document why that was done >> and should still remain experimental in 2.5. >> >> Meanwhile, our documentation states that we prefer 'lower-case', >> rather than 'CamelCase', for qapi enum values. The InputButton and >> InputAxis enums violate this convention. However, because they are >> currently used primarily for generating code that is used internally; >> and their only exposure through QMP is via the experimental >> 'x-input-send-event' command, we are free to change their spelling. >> Of course, it would be nicer to delay such a change until the same >> time we promote the command to non-experimental. Adding >> documentation will help us remember to do that rename. >> >> We have plans to tighten the qapi generator to flag instances of >> inconsistent use of naming conventions; if that lands first, it >> will just need to whitelist these exceptions until the time we >> settle on the final interface. > > Reviewed-by: Gerd Hoffmann Applied to qapi-next for 2.5, thanks!