From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753569AbbDMIgh (ORCPT ); Mon, 13 Apr 2015 04:36:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36129 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbbDMIgf (ORCPT ); Mon, 13 Apr 2015 04:36:35 -0400 From: Vitaly Kuznetsov To: Dan Carpenter Cc: "K. Y. Srinivasan" , devel@linuxdriverproject.org, Radim Krcmar , Greg Kroah-Hartman , Haiyang Zhang , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v3 03/21] Drivers: hv: kvp: move poll_channel() to hyperv_vmbus.h References: <1428568730-6030-1-git-send-email-vkuznets@redhat.com> <1428568730-6030-4-git-send-email-vkuznets@redhat.com> <20150410182742.GQ10964@mwanda> Date: Mon, 13 Apr 2015 10:36:30 +0200 In-Reply-To: <20150410182742.GQ10964@mwanda> (Dan Carpenter's message of "Fri, 10 Apr 2015 21:27:42 +0300") Message-ID: <87r3rotofl.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter writes: > On Thu, Apr 09, 2015 at 10:38:32AM +0200, Vitaly Kuznetsov wrote: >> ..., make it inline and rename it to hv_poll_channel() so it can be reused >> in other hv_util modules. >> > > The "...," is fine in the git log but I noticed recently that if you're > reading patches in a web archive then often the subject and the body are > several lines apart. > > http://marc.info/?l=linux-api&m=142856917031730&w=2 > > It's awkward to follow. > Oh, yea, I see... I'll try eliminating this practice for myself in future, but it seems many other contributors never saw their commits with '...' in a web archive as well.. > regards, > dan carpenter -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Subject: Re: [PATCH v3 03/21] Drivers: hv: kvp: move poll_channel() to hyperv_vmbus.h Date: Mon, 13 Apr 2015 10:36:30 +0200 Message-ID: <87r3rotofl.fsf@vitty.brq.redhat.com> References: <1428568730-6030-1-git-send-email-vkuznets@redhat.com> <1428568730-6030-4-git-send-email-vkuznets@redhat.com> <20150410182742.GQ10964@mwanda> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20150410182742.GQ10964@mwanda> (Dan Carpenter's message of "Fri, 10 Apr 2015 21:27:42 +0300") Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Carpenter Cc: "K. Y. Srinivasan" , devel-tBiZLqfeLfOHmIFyCCdPziST3g8Odh+X@public.gmane.org, Radim Krcmar , Greg Kroah-Hartman , Haiyang Zhang , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org Dan Carpenter writes: > On Thu, Apr 09, 2015 at 10:38:32AM +0200, Vitaly Kuznetsov wrote: >> ..., make it inline and rename it to hv_poll_channel() so it can be reused >> in other hv_util modules. >> > > The "...," is fine in the git log but I noticed recently that if you're > reading patches in a web archive then often the subject and the body are > several lines apart. > > http://marc.info/?l=linux-api&m=142856917031730&w=2 > > It's awkward to follow. > Oh, yea, I see... I'll try eliminating this practice for myself in future, but it seems many other contributors never saw their commits with '...' in a web archive as well.. > regards, > dan carpenter -- Vitaly