From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:41739 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbbCSJcr (ORCPT ); Thu, 19 Mar 2015 05:32:47 -0400 From: Kalle Valo To: Michal Kazior CC: Rajkumar Manoharan , "ath10k@lists.infradead.org" , linux-wireless Subject: Re: [PATCH] ath10k: fix htt t2h message conflicts among firmware revisions References: <1426066382-481-1-git-send-email-rmanohar@qti.qualcomm.com> <878uetl7cn.fsf@kamboji.qca.qualcomm.com> Date: Thu, 19 Mar 2015 11:32:37 +0200 In-Reply-To: (Michal Kazior's message of "Thu, 19 Mar 2015 09:40:39 +0100") Message-ID: <87r3sljpsa.fsf@kamboji.qca.qualcomm.com> (sfid-20150319_103251_207213_1DD8FD0C) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: >> When I was adding WMI_OP_VERSION, my idea was that we will add similar >> version for HTT as well once we need it. But I guess this is good enough >> for now, we can add HTT_OP_VERSION later if more changes are needed. > > Maybe it should be renamed to OP_VERSION (drop the WMI_) or BRANCH_ID > or something else? > > It's not like HTT wasn't diverging. It was. However only WMI ABI was > seeing major breakage that needed taking care of. HTT changes were > small enough and could be ignored until now. I'm a bit worried that having one id for everything will be more difficult to maintain, that's why I created WMI_OP_VERSION in the first place. IMHO it's lot cleaner codewise to have one id for WMI interface and one id for HTT (eg. HTT_OP_VERSION). What do you think? > Perhaps the rename could be accompanied by FW API bump to 5? Maybe not the rename, but yeah, something should be decided before the bump up. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YYWpE-00007v-3e for ath10k@lists.infradead.org; Thu, 19 Mar 2015 09:33:13 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: fix htt t2h message conflicts among firmware revisions References: <1426066382-481-1-git-send-email-rmanohar@qti.qualcomm.com> <878uetl7cn.fsf@kamboji.qca.qualcomm.com> Date: Thu, 19 Mar 2015 11:32:37 +0200 In-Reply-To: (Michal Kazior's message of "Thu, 19 Mar 2015 09:40:39 +0100") Message-ID: <87r3sljpsa.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: linux-wireless , Rajkumar Manoharan , "ath10k@lists.infradead.org" Michal Kazior writes: >> When I was adding WMI_OP_VERSION, my idea was that we will add similar >> version for HTT as well once we need it. But I guess this is good enough >> for now, we can add HTT_OP_VERSION later if more changes are needed. > > Maybe it should be renamed to OP_VERSION (drop the WMI_) or BRANCH_ID > or something else? > > It's not like HTT wasn't diverging. It was. However only WMI ABI was > seeing major breakage that needed taking care of. HTT changes were > small enough and could be ignored until now. I'm a bit worried that having one id for everything will be more difficult to maintain, that's why I created WMI_OP_VERSION in the first place. IMHO it's lot cleaner codewise to have one id for WMI interface and one id for HTT (eg. HTT_OP_VERSION). What do you think? > Perhaps the rename could be accompanied by FW API bump to 5? Maybe not the rename, but yeah, something should be decided before the bump up. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k