Re: Responsiveness Changes to i915 Driver

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 20 Aug 2014, "Wilde, Martin" <martin.wilde@intel.com> wrote:
> Greetings - after reviewing Chris¹s feedback below and some thought, I
> most likely do not need to add another trace message and the existing
> ³i915_flip_complete² trace message can be used.
>
> Thus the only change requested is to have the T1_T3 value printed out
> during driver init/re-init.  Here is the requested change:
>
> diff -rupN src.org/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c
> src/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c
> --- 
> src.org/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c	2014-08-14
> 14:24:45.655312785 -0700
> +++ src/third_party/kernel/3.10/drivers/gpu/drm/i915/intel_dp.c	2014-08-14
> 11:57:30.203608374 -0700
> @@ -3528,6 +3528,7 @@ intel_dp_init_panel_power_sequencer(stru
>  	intel_dp->panel_power_cycle_delay = get_delay(t11_t12);
>  #undef get_delay
>  
> +	printk(KERN_INFO "i915: eDP T3 Value: %d\n",
> intel_dp->panel_power_up_delay);

What's wrong with using the value printed on the next line? This is not
something we'll add INFO level messages for.

BR,
Jani.


>  	DRM_DEBUG_KMS("panel power up delay %d, power down delay %d, power cycle
> delay %d\n",
>  		      intel_dp->panel_power_up_delay, intel_dp->panel_power_down_delay,
>  		      intel_dp->panel_power_cycle_delay);
>
-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx