From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Date: Thu, 19 Jun 2014 00:54:03 +0000 Subject: Re: [PATCH 09/12] ASoC: rsnd: enable SRC setting via DT Message-Id: <87r42l90sz.wl%kuninori.morimoto.gx@gmail.com> List-Id: References: <87d2e6zjhf.wl%kuninori.morimoto.gx@gmail.com> <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com> <53A1A022.1020801@cogentembedded.com> In-Reply-To: <53A1A022.1020801@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: Mark Brown , Kuninori Morimoto , Linux-ALSA , Liam Girdwood , Simon , linux-sh@vger.kernel.org Hi Sergei > > @@ -640,6 +640,16 @@ static void rsnd_of_parse_src(struct platform_device *pdev, > > info->src_info = src_info; > > info->src_info_nr = nr; > > > > + i = 0; > > + for_each_child_of_node(src_node, np) { > > + src_info = info->src_info + i; > > + > > + of_property_read_u32(src_node, "convert-rate", > > Are you sure it's 'src_node' here, not 'np'? Grr.. Nice catch ! Thank you for pointing it. I will fix it in v2 Best regards --- Kuninori Morimoto From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 09/12] ASoC: rsnd: enable SRC setting via DT Date: Wed, 18 Jun 2014 17:54:03 -0700 (PDT) Message-ID: <87r42l90sz.wl%kuninori.morimoto.gx@gmail.com> References: <87d2e6zjhf.wl%kuninori.morimoto.gx@gmail.com> <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com> <53A1A022.1020801@cogentembedded.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <53A1A022.1020801@cogentembedded.com> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov Cc: Mark Brown , Kuninori Morimoto , Linux-ALSA , Liam Girdwood , Simon , linux-sh@vger.kernel.org List-Id: alsa-devel@alsa-project.org Hi Sergei > > @@ -640,6 +640,16 @@ static void rsnd_of_parse_src(struct platform_device *pdev, > > info->src_info = src_info; > > info->src_info_nr = nr; > > > > + i = 0; > > + for_each_child_of_node(src_node, np) { > > + src_info = info->src_info + i; > > + > > + of_property_read_u32(src_node, "convert-rate", > > Are you sure it's 'src_node' here, not 'np'? Grr.. Nice catch ! Thank you for pointing it. I will fix it in v2 Best regards --- Kuninori Morimoto