From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbaDXHjX (ORCPT ); Thu, 24 Apr 2014 03:39:23 -0400 Received: from ozlabs.org ([103.22.144.67]:43121 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbaDXHjU (ORCPT ); Thu, 24 Apr 2014 03:39:20 -0400 From: Rusty Russell To: madcatxster@devoid-pointer.net Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files. In-Reply-To: References: <1398137612-9714-1-git-send-email-rusty@rustcorp.com.au> <1398137612-9714-4-git-send-email-rusty@rustcorp.com.au> <9d9a3af40f8a0da293e52610524674c8.squirrel@mungewell.org> <87r44ofw1x.fsf@rustcorp.com.au> <4977a0bbe5c8625d93f771983991f30a.squirrel@mungewell.org> <87eh0nfly3.fsf@rustcorp.com.au> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Thu, 24 Apr 2014 16:44:23 +0930 Message-ID: <87r44ndws0.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org madcatxster@devoid-pointer.net writes: > On Thu Apr 24 2014 05:25:24 GMT+0200 (CEST), Rusty Russell wrote: >> simon@mungewell.org writes: >> >> simon@mungewell.org writes: >> >>> Yep I'm OK with that, however what it the recommended way to make sure >> >>> that the end user is able to send changes to this /sys portal? I asked >> >>> the >> >>> same question before regarding the led class /sys interface, but never >> >>> got >> >>> any suggestions. >> >>> >> >>> Signed-off-by: Simon Wood >> >> >> >> If you need that, we'll need to make an exception. That's one purpose >> >> of spamming everyone with these changs... >> > >> > >> > What's the right way of doing it?... I don't need to be 'special'. ;-) >> > >> > The '/sys/.../range' control allows the user to limit the rotation of the >> > gaming wheel from a maximum of 900' down to match the 'car' they >> > sim-driving. Probably not many people use it, but it probably should be >> > assigned properly. >> > >> > With gaming controllers the /dev/input/event* seem to get set >> > appropriately, but I'm not sure how this happens. >> > >> > The same /should/ also happen for all the LED class controls, I don't want >> > to have to 'sudo' just to set a LED on/off. This is currently a problem >> > for (at least) hid-lg, hid-sony and hid-steelseries. >> > Simon >> >> I think this is a udev duty. Someone needs to chmod/chown/chgrp the >> files if you want to allow a particular group/user access (I just >> checked, that works fot sysfs files). >> >> I have no idea about HID, so I don't know how you'd figure out who that >> user/group is... >> >> Cheers, >> Rusty. >> > > I'll be OK with udev rules taking care of this instead of the kernel. When are these changes supposed to land in mainline? Next merge window... Cheers, Rusty.