All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Kevin Liu <keyuan.liu@gmail.com>
Cc: linux-mmc@vger.kernel.org, pierre@ossman.eu,
	ulf.hansson@linaro.org, zgao6@marvell.com, hzhuang1@marvell.com,
	cxie4@marvell.com, prakity@marvell.com, kliu5@marvell.com
Subject: Re: [PATCH v6 09/14] mmc: sdhci-pxav3: add quirks2
Date: Sun, 25 Nov 2012 14:26:40 -0500	[thread overview]
Message-ID: <87r4nh8owf.fsf@octavius.laptop.org> (raw)
In-Reply-To: <CADz5_g+rhJzRxAOyCe3CpW+ZywcwCQVH3MU8e0Z3JAdk+JStGw@mail.gmail.com> (Kevin Liu's message of "Mon, 19 Nov 2012 10:34:00 +0800")

Hi,

On Sun, Nov 18 2012, Kevin Liu wrote:
>>> From: Kevin Liu <kliu5@marvell.com>
>>>
>>> Acked-by:  Zhangfei Gao <zhangfei.gao@marvell.com>
>>> Signed-off-by: Kevin Liu <kliu5@marvell.com>
>>> ---
>>>  drivers/mmc/host/sdhci-pxav3.c          |    2 ++
>>>  include/linux/platform_data/pxa_sdhci.h |    2 ++
>>>  2 files changed, 4 insertions(+), 0 deletions(-)
>>
>> It looks like you aren't using any of the quirks in quirks2, is that
>> right?  I'm still hoping we might be able to get rid of quirks2, so
>> I'd rather wait until you need it (or we get rid of it) before applying
>> this.
>
> My previous patch "[PATCH v6 08/14] mmc: sdhci: enhance preset value
> function" introduced a quirk SDHCI_QUIRK2_PRESET_VALUE_BROKEN, which
> aim to disable preset feature since the preset setting is fixed only
> for 200Mhz base clock on pxav3 platform. So we should disable preset
> if the base clock is other than 200Mhz.

Thanks, pushed to mmc-next for 3.8.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2012-11-25 19:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-17 11:04 mmc: sdhci: fixes and enhancements Kevin Liu
2012-10-17 11:04 ` [PATCH v6 01/14] mmc: sdhci: fix transfer mode setting bug for cmds w/o data transfer Kevin Liu
2012-10-17 11:04 ` [PATCH v6 02/14] mmc: sdhci: refine voltage support caps setting Kevin Liu
2012-10-17 11:04 ` [PATCH v6 03/14] mmc: sdhci: refine code for sd clock disable/enable in set ios Kevin Liu
2012-10-17 11:04 ` [PATCH v6 04/14] mmc: sdhci: keep the saved clock var up to date Kevin Liu
2012-10-17 11:04 ` [PATCH v6 05/14] mmc: sdhci: fix null return check of regulator_get Kevin Liu
2012-11-05 13:56   ` Chris Ball
2012-11-12  8:57     ` Kevin Liu
2012-11-13  3:00       ` Kevin Liu
2012-11-14  1:49         ` Haojian Zhuang
2012-10-17 11:04 ` [PATCH v6 06/14] mmc: sdhci-pxav3: controller can't get base clock Kevin Liu
2012-11-17 21:57   ` Chris Ball
2012-10-17 11:04 ` [PATCH v6 07/14] mmc: host: adjust uhs timing value Kevin Liu
2012-11-17 22:01   ` Chris Ball
2012-10-17 11:04 ` [PATCH v6 08/14] mmc: sdhci: enhance preset value function Kevin Liu
2012-10-17 11:04 ` [PATCH v6 09/14] mmc: sdhci-pxav3: add quirks2 Kevin Liu
2012-11-17 22:09   ` Chris Ball
2012-11-19  2:34     ` Kevin Liu
2012-11-25 19:26       ` Chris Ball [this message]
2012-10-17 11:04 ` [PATCH v6 10/14] mmc: sdhci: introduce signal_voltage_switch callback function Kevin Liu
2012-10-17 11:04 ` [PATCH v6 11/14] mmc: sdhci: fix the bug that DDR50 can't work for emmc Kevin Liu
2012-11-17 22:35   ` Chris Ball
2012-11-19  3:14     ` Kevin Liu
2012-11-19  8:57       ` Kevin Liu
2012-12-07 19:10         ` Chris Ball
2012-12-08  1:54           ` Kevin Liu
2012-12-08  3:14             ` Kevin Liu
2012-12-11 10:48               ` Kevin Liu
2012-10-17 11:04 ` [PATCH v6 12/14] mmc: sdhci-pxav3: remove set_uhs_signaling function Kevin Liu
2012-11-17 22:39   ` Chris Ball
2012-11-19 11:23     ` Kevin Liu
2012-10-17 11:04 ` [PATCH v6 13/14] mmc: sdhci: solve several vmmc/vqmmc regulator issues Kevin Liu
2012-11-17 23:02   ` Chris Ball
2012-10-17 11:04 ` [PATCH v6 14/14] mmc: sdhci: add function to get retunig timer count Kevin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4nh8owf.fsf@octavius.laptop.org \
    --to=cjb@laptop.org \
    --cc=cxie4@marvell.com \
    --cc=hzhuang1@marvell.com \
    --cc=keyuan.liu@gmail.com \
    --cc=kliu5@marvell.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=pierre@ossman.eu \
    --cc=prakity@marvell.com \
    --cc=ulf.hansson@linaro.org \
    --cc=zgao6@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.