From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8129185631 for ; Tue, 9 Apr 2024 10:04:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712657091; cv=none; b=u8TRuIxxdfoLSTwXpfWkRaARf076ULf4oDhHoouJxra2ZI6ehRbzRcW2T1aub1HIRniy7DSMtvl6q618Sxm8+4u10FIRKcJh1ns66Y8XUYf0p9mGU9OYecRtYWSK/0nkytlcrYCgFFl5dbNEyNDy1ld1vU5p5tHMCqWuY4d761Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712657091; c=relaxed/simple; bh=YGIVoqaqkmzn78vlWTEumv3CXIci03l0Ha+15dNRnaY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Ibi6N3Wt3DgwaKyj4Ar+ViOmS/lCin91QeHomtRRZ0+BfD5mQoJNh24tztAwmSkMfIx4/DkWIpHi7cLjkpwPBKRTeV/OK38TUzxEI9s9C5pNn+Ujpq7sy3cUyVCnw/gNC4dJxv31KKHTD2AwdP8Yc3AoXu/lrsm7tNKaJ9H/DGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=C6a5eYsK; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="C6a5eYsK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712657089; x=1744193089; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=YGIVoqaqkmzn78vlWTEumv3CXIci03l0Ha+15dNRnaY=; b=C6a5eYsKSE+GyxmW9Bpw5sUvx1VdDBPijtXOibFTLWZ50FWktsldPOB4 v2itzI7sCUfONQhS8yZAGPlQExTt07vkGPh71TV/rFfbSOtgRwbApSQPK mad2pfi4sW9q+41gZJ/D60djW0wwTKbCMaB7TGwTeTtwvnFHguvaA6HtE gCtc3HlvUuqhqHXmsitVSIXKnx4n4+UbUiT0tl/u2TS+vGvnPfA6is/vy LgtSuc4e1GMzutBgMjySpzUEC+JfJ2e2mh74ehmwVdxuCCI0BE0Baz8Ze vA3KfcwuHUr540/CoirSVZn/rF6tCqJ6d3lPtclRuEFTPa3uM/gAAGDlO A==; X-CSE-ConnectionGUID: DySz3S8lQheP5zg/+eE2WA== X-CSE-MsgGUID: r6iAzir7Rki77kys2o3whQ== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="11760017" X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="11760017" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 03:04:48 -0700 X-CSE-ConnectionGUID: 8btXhK/XTSuOGqbIvLqN0w== X-CSE-MsgGUID: oOTcSj4wTLKSF9UBEqAcoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="20207915" Received: from mserban-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.59.228]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 03:04:44 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Lucas De Marchi , kernel test robot , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> Date: Tue, 09 Apr 2024 13:04:42 +0300 Message-ID: <87sezu97id.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, 09 Apr 2024, Geert Uytterhoeven wrote: > The user should not need to know which helpers are needed for the driver > he is interested in. When a symbol selects another symbol, it should > just make sure the dependencies of the target symbol are met. It's really not "just make sure". This leads to perpetual illegal configurations, and duct tape fixes. Select should not be used for visible symbols or symbols with dependencies [1]. What we'd need for usability is not more abuse of select, but rather 1) warnings for selecting symbols with dependencies, and 2) a way to enable a kconfig option with all its dependencies, recursively. This is what we lack. BR, Jani. [1] Documentation/kbuild/kconfig-language.rst "reverse dependencies" -- Jani Nikula, Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71E1DC67861 for ; Tue, 9 Apr 2024 10:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sskxC5cLziuOK4xUArRaMHKmqAbanX2r/6dVc1Ty3pw=; b=EbYxqXNnxQS/r3 3uGpXgbpXarL3Je8Hyqw3AYs/92aSrLhEslfLPml8ygRVgbW7QXmB+kbsMdpyIs0+IucpSgWIfNGd 40+Q8yR5ttbwY1Hh9lQt2XNrhO4kRFVld4thj4XWvBuw7poAr2zuk/m4bSD7jVFAzhOIU4/Bt4LCP Y9ZMVDS0ghUZPne7TpQ2qhenMpFC4pygHxyf1MXwIkxUZLCbDBbI/uOYuLvebVIs5t9V0JuDTTNaJ O7cn3aAtz1JDxU1UIPgx6CfQhBGq2fqkymqMdkIPhmG2UW6010THd89V4L8/5jLbSqS/M29UPOoCt Ar8koiYseVEB+C/mHKpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8Li-00000001LXF-1WPZ; Tue, 09 Apr 2024 10:05:06 +0000 Received: from mgamail.intel.com ([198.175.65.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8LV-00000001LO7-2aQ4 for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 10:04:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712657093; x=1744193093; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=YGIVoqaqkmzn78vlWTEumv3CXIci03l0Ha+15dNRnaY=; b=dqG94fpB59AKO7FyTGJ1kZZjKHDanxnCaR0pLgH1Q8YbjOjpZVcsqXYb w/bJIckPRPW+/KJ7R2Vl8aaJ+CoRi9/TO+g0LnOrymRtepm92s5N4x3DJ dkdVgZUGt8FfYILcY2P1rihPjAck2SXcSjwU0gCxBHiNHb/vE5jcA4OuY nsNvC8Wz0Rwa1m077dUT627HaUJkMCHcq2BAFzbu5AId3Qp8dTDbXBx7d QUq9UHVQ09fI9+vq7HEMFYWFGpvDLsLSUL41qu2rGLpNMa9eU1yIohfwW KVQQMMMjPEtNkO+4RewkJSCpApKzSk0/C3aKULIfyJLjAXcAqHuqyNnDu w==; X-CSE-ConnectionGUID: 9YGql9XKTsq8f3ZoRztcBg== X-CSE-MsgGUID: SWdkHsp/Tm6N7/U5bTZNBw== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="11760022" X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="11760022" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 03:04:49 -0700 X-CSE-ConnectionGUID: 8btXhK/XTSuOGqbIvLqN0w== X-CSE-MsgGUID: oOTcSj4wTLKSF9UBEqAcoA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="20207915" Received: from mserban-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.59.228]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 03:04:44 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Lucas De Marchi , kernel test robot , linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> Date: Tue, 09 Apr 2024 13:04:42 +0300 Message-ID: <87sezu97id.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030453_858853_F134EEEC X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 09 Apr 2024, Geert Uytterhoeven wrote: > The user should not need to know which helpers are needed for the driver > he is interested in. When a symbol selects another symbol, it should > just make sure the dependencies of the target symbol are met. It's really not "just make sure". This leads to perpetual illegal configurations, and duct tape fixes. Select should not be used for visible symbols or symbols with dependencies [1]. What we'd need for usability is not more abuse of select, but rather 1) warnings for selecting symbols with dependencies, and 2) a way to enable a kconfig option with all its dependencies, recursively. This is what we lack. BR, Jani. [1] Documentation/kbuild/kconfig-language.rst "reverse dependencies" -- Jani Nikula, Intel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel