[virtio-dev] [PATCH] audio->sound

[virtio-dev] [PATCH] audio->sound

[Michael S. Tsirkin]

Spec calls the device "sound device". Make the name in the
ID section match.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/content.tex b/content.tex
index 5c66e6b..279998a 100644
--- a/content.tex
+++ b/content.tex
@@ -3014,7 +3014,7 @@ \chapter{Device Types}\label{sec:Device Types}
 \hline
 24         &   Memory device \\
 \hline
-25         &   Audio device \\
+25         &   Sound device \\
 \hline
 26         &   file system device \\
 \hline
-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio] Re: [virtio-dev] [PATCH] audio->sound

[Cornelia Huck]

On Thu, Sep 08 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:

> Spec calls the device "sound device". Make the name in the
> ID section match.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/content.tex b/content.tex
> index 5c66e6b..279998a 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -3014,7 +3014,7 @@ \chapter{Device Types}\label{sec:Device Types}
>  \hline
>  24         &   Memory device \\
>  \hline
> -25         &   Audio device \\
> +25         &   Sound device \\
>  \hline
>  26         &   file system device \\
>  \hline

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Actually, under the title "Sound device", the spec says

"The virtio sound card is a virtual audio device..."

-- should it be "virtio sound device" instead?


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that 
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 

Re: [virtio-dev] [PATCH] audio->sound

[Michael S. Tsirkin]

On Thu, Sep 08, 2022 at 11:11:40AM +0200, Cornelia Huck wrote:
> On Thu, Sep 08 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > Spec calls the device "sound device". Make the name in the
> > ID section match.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  content.tex | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/content.tex b/content.tex
> > index 5c66e6b..279998a 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -3014,7 +3014,7 @@ \chapter{Device Types}\label{sec:Device Types}
> >  \hline
> >  24         &   Memory device \\
> >  \hline
> > -25         &   Audio device \\
> > +25         &   Sound device \\
> >  \hline
> >  26         &   file system device \\
> >  \hline
> 
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> 
> Actually, under the title "Sound device", the spec says
> 
> "The virtio sound card is a virtual audio device..."
> 
> -- should it be "virtio sound device" instead?

I don't know, leave that for audio experts ;)

-- 
MST

[virtio-comment] Re: [virtio] Re: [virtio-dev] [PATCH] audio->sound

[Matti Möll]

On 08.09.22 13:09, Michael S. Tsirkin wrote:
> On Thu, Sep 08, 2022 at 11:11:40AM +0200, Cornelia Huck wrote:
>> On Thu, Sep 08 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>
>>> Spec calls the device "sound device". Make the name in the
>>> ID section match.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>>   content.tex | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/content.tex b/content.tex
>>> index 5c66e6b..279998a 100644
>>> --- a/content.tex
>>> +++ b/content.tex
>>> @@ -3014,7 +3014,7 @@ \chapter{Device Types}\label{sec:Device Types}
>>>   \hline
>>>   24         &   Memory device \\
>>>   \hline
>>> -25         &   Audio device \\
>>> +25         &   Sound device \\
>>>   \hline
>>>   26         &   file system device \\
>>>   \hline
>>
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>>
>> Actually, under the title "Sound device", the spec says
>>
>> "The virtio sound card is a virtual audio device..."
>>
>> -- should it be "virtio sound device" instead?
> 
> I don't know, leave that for audio experts ;)

I'll pretend to be one, and as far as I can remember audio is only the 
sounds in the audible range (few Hz to 20kHz) but SOUND can go below and 
above that in frequency (ultrasonic for example). It's an elaborate form 
of bike shedding if you ask me, but the 'real experts(tm)' claim that 
there's a huge difference.

As for the change, it looks fine to me. It makes the naming consistent 
across the chapters and doesn't exclude inaudible tones.

Reviewed-By: Matti Möll <Matti.Moell@opensynergy.com>

-- 
OpenSynergy GmbH

Rotherstr. 20, 10245 Berlin

Phone: +49 30 60 98 54 0 – 54

Fax:      +49 30 60 98 54 0 -99

EMail: matti.moell@opensynergy.com

www.opensynergy.com

Handelsregister/Commercial Registry: Amtsgericht Charlottenburg, HRB 108616B

Geschäftsführer/Managing Director: Regis Adjamah

This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-dev] [PATCH] audio->sound

[Michael S. Tsirkin]

On Thu, Sep 08, 2022 at 11:11:40AM +0200, Cornelia Huck wrote:
> On Thu, Sep 08 2022, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
> > Spec calls the device "sound device". Make the name in the
> > ID section match.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  content.tex | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/content.tex b/content.tex
> > index 5c66e6b..279998a 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -3014,7 +3014,7 @@ \chapter{Device Types}\label{sec:Device Types}
> >  \hline
> >  24         &   Memory device \\
> >  \hline
> > -25         &   Audio device \\
> > +25         &   Sound device \\
> >  \hline
> >  26         &   file system device \\
> >  \hline
> 
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> 
> Actually, under the title "Sound device", the spec says
> 
> "The virtio sound card is a virtual audio device..."
> 
> -- should it be "virtio sound device" instead?

This card/device thing is something Parav is interested in ;)
/me hides

-- 
MST