From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA16C433EF for ; Thu, 14 Jul 2022 09:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238016AbiGNJ1O (ORCPT ); Thu, 14 Jul 2022 05:27:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238280AbiGNJ0f (ORCPT ); Thu, 14 Jul 2022 05:26:35 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4507CF1A for ; Thu, 14 Jul 2022 02:26:09 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BBA6834B79; Thu, 14 Jul 2022 09:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657790767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2NwB9/81lvuQa67kl1UAGviK/dw5NIlEVN0/I8KZbQE=; b=xvPhEWSZ04fste5fKshzJF/7ZGkSmE+71bHdxKPCLBJ1si27tVtz+Snfo2VtPwVyY3cewk pgNHI3scJfGhFuMUckV23WoQ4ZoCZRXUQ2J+iAQDJ7k9N2Q1kF6FAvCXQrYAjrbZg10ohP xDnuUO8G/VmSMKfeAr189un9dWPufRE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657790767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2NwB9/81lvuQa67kl1UAGviK/dw5NIlEVN0/I8KZbQE=; b=V9jUYqHWe+qU+6Cu2dyQRKkQQy4Ae42RVv56byYNZK6i99jdvKiOxfuOw5g3pChogIdURU iAxEUOdKacKqjtAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D73413A61; Thu, 14 Jul 2022 09:26:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id I9SeIS/hz2K7KQAAMHmgww (envelope-from ); Thu, 14 Jul 2022 09:26:07 +0000 Date: Thu, 14 Jul 2022 11:26:07 +0200 Message-ID: <87sfn4vyds.wl-tiwai@suse.de> From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , Mark Brown , , , , Stefan Binding Subject: Re: [PATCH v8 01/14] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls In-Reply-To: <87tu7kvzav.wl-tiwai@suse.de> References: <20220630002335.366545-1-vitalyr@opensource.cirrus.com> <20220630002335.366545-2-vitalyr@opensource.cirrus.com> <87v8s0vzfv.wl-tiwai@suse.de> <87tu7kvzav.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2022 11:06:16 +0200, Takashi Iwai wrote: > > On Thu, 14 Jul 2022 11:03:16 +0200, > Takashi Iwai wrote: > > > > On Thu, 30 Jun 2022 02:23:22 +0200, > > Vitaly Rodionov wrote: > > > --- a/sound/pci/hda/Kconfig > > > +++ b/sound/pci/hda/Kconfig > > > @@ -94,6 +94,10 @@ config SND_HDA_PATCH_LOADER > > > config SND_HDA_SCODEC_CS35L41 > > > tristate > > > > > > +config SND_HDA_CS_DSP_CONTROLS > > > + tristate > > > + depends on CS_DSP > > > + > > > config SND_HDA_SCODEC_CS35L41_I2C > > > tristate "Build CS35L41 HD-audio side codec support for I2C Bus" > > > depends on I2C > > > > This change alone doesn't give anything useful, unfortunately. > > > > The above form (without prompt) is basically only to be "selected" by > > others. And when selected, the "depends" there is just ignored, so > > it's useless. > > > > That is, a proper way would be something like: > > > > config SND_HDA_CS_DSP_CONTROLS > > tristate > > > > config SND_HDA_SCODEC_CS35L41 > > .... > > select SND_HDA_CS_DSP_CONTROLS if CS_DSP > > > > ... if you want / need to enable CONFIG_SND_HDA_CS_DSP_CONTROLS > > conditionally. > > And now I see that the patch 4 has those selects (but select both > SND_HDA_CS_DSP_CONTROLS and CS_DSP). So what we need here is to drop > the superfluous "depends on CS_DSP" and mention in the description > that the Kconfig will be actually enabled in the later patch. But no need for resubmission; I fixed this locally. So I applied up to the patch 8. At patch 9, it can't build because of the lack of ASoC side change. Still waiting for *ANY* reaction from Mark... Sigh. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5605C43334 for ; Thu, 14 Jul 2022 09:27:13 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 527AE191A; Thu, 14 Jul 2022 11:26:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 527AE191A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657790831; bh=EsPngjHmPx5kbaNUHvuvhEMqm8Pe9iEt9bwYuSEks6s=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YWJWeyTYCqUBnbqt/Y8BSIwnx+b/TTYg8xAEkqvxjp9u4ATguxSSVib9rDLR4z0v9 Pt1CYOUhphs3IYLV/oJHmnTafqIqFZjx+tOCLpyflURzmhZluRb6DUoK9HDnV/Wwwd mdxUqPYFbNjgnxv6uj081KuAeCIdJr8WLkMl5Byw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A5FE2F8014E; Thu, 14 Jul 2022 11:26:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9EA4EF80165; Thu, 14 Jul 2022 11:26:18 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 877FEF8014E for ; Thu, 14 Jul 2022 11:26:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 877FEF8014E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="xvPhEWSZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="V9jUYqHW" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BBA6834B79; Thu, 14 Jul 2022 09:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657790767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2NwB9/81lvuQa67kl1UAGviK/dw5NIlEVN0/I8KZbQE=; b=xvPhEWSZ04fste5fKshzJF/7ZGkSmE+71bHdxKPCLBJ1si27tVtz+Snfo2VtPwVyY3cewk pgNHI3scJfGhFuMUckV23WoQ4ZoCZRXUQ2J+iAQDJ7k9N2Q1kF6FAvCXQrYAjrbZg10ohP xDnuUO8G/VmSMKfeAr189un9dWPufRE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657790767; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2NwB9/81lvuQa67kl1UAGviK/dw5NIlEVN0/I8KZbQE=; b=V9jUYqHWe+qU+6Cu2dyQRKkQQy4Ae42RVv56byYNZK6i99jdvKiOxfuOw5g3pChogIdURU iAxEUOdKacKqjtAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D73413A61; Thu, 14 Jul 2022 09:26:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id I9SeIS/hz2K7KQAAMHmgww (envelope-from ); Thu, 14 Jul 2022 09:26:07 +0000 Date: Thu, 14 Jul 2022 11:26:07 +0200 Message-ID: <87sfn4vyds.wl-tiwai@suse.de> From: Takashi Iwai To: Vitaly Rodionov Subject: Re: [PATCH v8 01/14] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls In-Reply-To: <87tu7kvzav.wl-tiwai@suse.de> References: <20220630002335.366545-1-vitalyr@opensource.cirrus.com> <20220630002335.366545-2-vitalyr@opensource.cirrus.com> <87v8s0vzfv.wl-tiwai@suse.de> <87tu7kvzav.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Takashi Iwai , linux-kernel@vger.kernel.org, Stefan Binding , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 14 Jul 2022 11:06:16 +0200, Takashi Iwai wrote: > > On Thu, 14 Jul 2022 11:03:16 +0200, > Takashi Iwai wrote: > > > > On Thu, 30 Jun 2022 02:23:22 +0200, > > Vitaly Rodionov wrote: > > > --- a/sound/pci/hda/Kconfig > > > +++ b/sound/pci/hda/Kconfig > > > @@ -94,6 +94,10 @@ config SND_HDA_PATCH_LOADER > > > config SND_HDA_SCODEC_CS35L41 > > > tristate > > > > > > +config SND_HDA_CS_DSP_CONTROLS > > > + tristate > > > + depends on CS_DSP > > > + > > > config SND_HDA_SCODEC_CS35L41_I2C > > > tristate "Build CS35L41 HD-audio side codec support for I2C Bus" > > > depends on I2C > > > > This change alone doesn't give anything useful, unfortunately. > > > > The above form (without prompt) is basically only to be "selected" by > > others. And when selected, the "depends" there is just ignored, so > > it's useless. > > > > That is, a proper way would be something like: > > > > config SND_HDA_CS_DSP_CONTROLS > > tristate > > > > config SND_HDA_SCODEC_CS35L41 > > .... > > select SND_HDA_CS_DSP_CONTROLS if CS_DSP > > > > ... if you want / need to enable CONFIG_SND_HDA_CS_DSP_CONTROLS > > conditionally. > > And now I see that the patch 4 has those selects (but select both > SND_HDA_CS_DSP_CONTROLS and CS_DSP). So what we need here is to drop > the superfluous "depends on CS_DSP" and mention in the description > that the Kconfig will be actually enabled in the later patch. But no need for resubmission; I fixed this locally. So I applied up to the patch 8. At patch 9, it can't build because of the lack of ASoC side change. Still waiting for *ANY* reaction from Mark... Sigh. thanks, Takashi