From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: "Leonardo Bras" <leobras@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
徐闯 <xuchuangxclwt@bytedance.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability
Date: Mon, 20 Jun 2022 17:51:03 +0200 [thread overview]
Message-ID: <87sfnzz63c.fsf@secure.mitica> (raw)
In-Reply-To: <YrCS7OTweyxcLmzE@xz-m1.local> (Peter Xu's message of "Mon, 20 Jun 2022 11:31:56 -0400")
Peter Xu <peterx@redhat.com> wrote:
> On Mon, Jun 20, 2022 at 02:39:45AM -0300, Leonardo Bras wrote:
>> When originally implemented, zero_copy_send was designed as a Migration
>> paramenter.
>>
>> But taking into account how is that supposed to work, and how
>> the difference between a capability and a parameter, it only makes sense
>> that zero-copy-send would work better as a capability.
>>
>> Taking into account how recently the change got merged, it was decided
>> that it's still time to make it right, and convert zero_copy_send into
>> a Migration capability.
>>
>> Signed-off-by: Leonardo Bras <leobras@redhat.com>
>
> I assume this is a request from Libvirt? We don't have a release yet so
> yeah probably we still have time..
>
> Acked-by: Peter Xu <peterx@redhat.com>
Livirt already have a concept of migration capabilities (bools) that
lets layered products to check/discover/etc. Putting it there instead
of one parameter makes their life much easier (i.e. more common code).
As this code hasn't been in a stable release yet, I think it is ok.
Later, Juan.
next prev parent reply other threads:[~2022-06-20 15:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 5:39 [PATCH v4 0/4] MSG_ZEROCOPY fixes & improvements Leonardo Bras
2022-06-20 5:39 ` [PATCH v4 1/4] QIOChannelSocket: Introduce assert and reduce ifdefs to improve readability Leonardo Bras
2022-06-20 8:47 ` Juan Quintela
2022-06-20 15:27 ` Peter Xu
2022-06-20 5:39 ` [PATCH v4 2/4] QIOChannelSocket: Fix zero-copy send so socket flush works Leonardo Bras
2022-06-20 8:48 ` Juan Quintela
2022-06-20 15:27 ` Peter Xu
2022-06-20 5:39 ` [PATCH v4 3/4] migration: zero-copy flush only at the end of bitmap scanning Leonardo Bras
2022-06-20 9:23 ` Juan Quintela
2022-06-20 15:44 ` Peter Xu
2022-06-21 3:35 ` Leonardo Brás
2022-06-21 14:51 ` Juan Quintela
2022-06-21 15:09 ` Peter Xu
2022-06-21 15:04 ` Peter Xu
2022-06-21 3:26 ` Leonardo Brás
2022-06-20 5:39 ` [PATCH v4 4/4] migration: Change zero_copy_send from migration parameter to migration capability Leonardo Bras
2022-06-20 5:46 ` Leonardo Bras Soares Passos
2022-06-20 9:34 ` Juan Quintela
2022-06-20 15:31 ` Peter Xu
2022-06-20 15:51 ` Juan Quintela [this message]
2022-06-21 12:34 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfnzz63c.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xuchuangxclwt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.