From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54457C433F5 for ; Tue, 29 Mar 2022 15:56:42 +0000 (UTC) Received: from localhost ([::1]:33112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZED3-00027h-8w for qemu-devel@archiver.kernel.org; Tue, 29 Mar 2022 11:56:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZEBa-00010U-CE for qemu-devel@nongnu.org; Tue, 29 Mar 2022 11:55:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:43325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZEBY-0004cv-GV for qemu-devel@nongnu.org; Tue, 29 Mar 2022 11:55:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648569307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xVrDcU7kpZNDlnArFr/AV+pv8bx/AeOo6pq8gF6Ckng=; b=bcB8MFFGZum1w48YlDRIIqsomMWR1z2DAssL6V62YXyjr9mw73FKurcVrIZewdIIR3rEWW 3WUb2H56BpcB8vEbvhIXB41UmmFSjBmEVlZJor2Cp1iCIQ1HTZlGnDVT78v7FCRiF/AnSB TuNq02Q682Te+iwoXjT+edZCjjTE/9A= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-kBvw22e9MWmtUKTjzsXIZg-1; Tue, 29 Mar 2022 11:55:05 -0400 X-MC-Unique: kBvw22e9MWmtUKTjzsXIZg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 89D4F1C068C3 for ; Tue, 29 Mar 2022 15:55:05 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 64EDA464DE2; Tue, 29 Mar 2022 15:55:05 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 44DEF21E691D; Tue, 29 Mar 2022 17:55:04 +0200 (CEST) From: Markus Armbruster To: Victor Toso Subject: Re: [PATCH v3 12/14] qapi: ui examples: add missing @websocket member References: <20220328140604.41484-1-victortoso@redhat.com> <20220328140604.41484-13-victortoso@redhat.com> Date: Tue, 29 Mar 2022 17:55:04 +0200 In-Reply-To: <20220328140604.41484-13-victortoso@redhat.com> (Victor Toso's message of "Mon, 28 Mar 2022 16:06:02 +0200") Message-ID: <87sfr0zrc7.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Victor Toso writes: > The examples were missing mandatory member @websocket. Provide it. > > Signed-off-by: Victor Toso > Reviewed-by: John Snow > --- > qapi/ui.json | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/qapi/ui.json b/qapi/ui.json > index 664da9e462..a810ed680c 100644 > --- a/qapi/ui.json > +++ b/qapi/ui.json > @@ -710,10 +710,10 @@ > # > # <- { "event": "VNC_CONNECTED", > # "data": { > -# "server": { "auth": "sasl", "family": "ipv4", > +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, > # "service": "5901", "host": "0.0.0.0" }, > # "client": { "family": "ipv4", "service": "58425", > -# "host": "127.0.0.1" } }, > +# "host": "127.0.0.1", "websocket": false } }, > # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } > # > ## > @@ -738,9 +738,9 @@ > # > # <- { "event": "VNC_INITIALIZED", > # "data": { > -# "server": { "auth": "sasl", "family": "ipv4", > +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, > # "service": "5901", "host": "0.0.0.0"}, > -# "client": { "family": "ipv4", "service": "46089", > +# "client": { "family": "ipv4", "service": "46089", "websocket": false, > # "host": "127.0.0.1", "sasl_username": "luiz" } }, > # "timestamp": { "seconds": 1263475302, "microseconds": 150772 } } > # > @@ -765,9 +765,9 @@ > # > # <- { "event": "VNC_DISCONNECTED", > # "data": { > -# "server": { "auth": "sasl", "family": "ipv4", > +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, > # "service": "5901", "host": "0.0.0.0" }, > -# "client": { "family": "ipv4", "service": "58425", > +# "client": { "family": "ipv4", "service": "58425", "websocket": false, > # "host": "127.0.0.1", "sasl_username": "luiz" } }, > # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } > # Reviewed-by: Markus Armbruster