From: Daniel Axtens <dja@axtens.net>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Neuling <mikey@neuling.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
kernel-janitors@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select
Date: Fri, 20 Aug 2021 08:39:45 +1000 [thread overview]
Message-ID: <87sfz59hzi.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <20210819113954.17515-2-lukas.bulwahn@gmail.com>
Hi Lukas,
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index e45644657d49..ff581d70f20c 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER
> config KVM_BOOK3S_64_HANDLER
> bool
> select KVM_BOOK3S_HANDLER
> - select PPC_DAWR_FORCE_ENABLE
I looked at some of the history here. It looks like this select was left
over from an earlier version of the patch series that added PPC_DAWR: v2
of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4
that new symbol had disappeared but the select had not.
v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/
v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/
The rest of the patch reasoning makes sense to me: DAWR support will be
selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try
to select it again anyway.
Reviewed-by: Daniel Axtens <dja@axtens.net>
Kind regards,
Daniel
>
> config KVM_BOOK3S_PR_POSSIBLE
> bool
> --
> 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Axtens <dja@axtens.net>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Neuling <mikey@neuling.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select
Date: Fri, 20 Aug 2021 08:39:45 +1000 [thread overview]
Message-ID: <87sfz59hzi.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <20210819113954.17515-2-lukas.bulwahn@gmail.com>
Hi Lukas,
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index e45644657d49..ff581d70f20c 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER
> config KVM_BOOK3S_64_HANDLER
> bool
> select KVM_BOOK3S_HANDLER
> - select PPC_DAWR_FORCE_ENABLE
I looked at some of the history here. It looks like this select was left
over from an earlier version of the patch series that added PPC_DAWR: v2
of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4
that new symbol had disappeared but the select had not.
v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/
v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/
The rest of the patch reasoning makes sense to me: DAWR support will be
selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try
to select it again anyway.
Reviewed-by: Daniel Axtens <dja@axtens.net>
Kind regards,
Daniel
>
> config KVM_BOOK3S_PR_POSSIBLE
> bool
> --
> 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Axtens <dja@axtens.net>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Neuling <mikey@neuling.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
kernel-janitors@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select
Date: Thu, 19 Aug 2021 22:39:45 +0000 [thread overview]
Message-ID: <87sfz59hzi.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <20210819113954.17515-2-lukas.bulwahn@gmail.com>
Hi Lukas,
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index e45644657d49..ff581d70f20c 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER
> config KVM_BOOK3S_64_HANDLER
> bool
> select KVM_BOOK3S_HANDLER
> - select PPC_DAWR_FORCE_ENABLE
I looked at some of the history here. It looks like this select was left
over from an earlier version of the patch series that added PPC_DAWR: v2
of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4
that new symbol had disappeared but the select had not.
v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/
v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/
The rest of the patch reasoning makes sense to me: DAWR support will be
selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try
to select it again anyway.
Reviewed-by: Daniel Axtens <dja@axtens.net>
Kind regards,
Daniel
>
> config KVM_BOOK3S_PR_POSSIBLE
> bool
> --
> 2.26.2
next prev parent reply other threads:[~2021-08-19 22:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 11:39 [PATCH v2 0/2] Kconfig symbol fixes on powerpc Lukas Bulwahn
2021-08-19 11:39 ` Lukas Bulwahn
2021-08-19 11:39 ` Lukas Bulwahn
2021-08-19 11:39 ` [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select Lukas Bulwahn
2021-08-19 11:39 ` Lukas Bulwahn
2021-08-19 11:39 ` Lukas Bulwahn
2021-08-19 22:39 ` Daniel Axtens [this message]
2021-08-19 22:39 ` Daniel Axtens
2021-08-19 22:39 ` Daniel Axtens
2021-08-19 11:39 ` [PATCH v2 2/2] powerpc: rectify selection to ARCH_ENABLE_SPLIT_PMD_PTLOCK Lukas Bulwahn
2021-08-19 11:39 ` Lukas Bulwahn
2021-08-19 11:39 ` Lukas Bulwahn
2021-08-20 0:03 ` Daniel Axtens
2021-08-20 0:03 ` Daniel Axtens
2021-08-20 0:03 ` Daniel Axtens
2021-08-20 4:25 ` Michael Ellerman
2021-08-20 4:25 ` Michael Ellerman
2021-08-20 4:25 ` Michael Ellerman
2021-08-19 11:50 ` [PATCH v2 0/2] Kconfig symbol fixes on powerpc Christophe Leroy
2021-08-19 11:50 ` Christophe Leroy
2021-08-19 11:50 ` Christophe Leroy
2021-08-27 13:15 ` Michael Ellerman
2021-08-27 13:15 ` Michael Ellerman
2021-08-27 13:15 ` Michael Ellerman
2021-08-27 13:28 ` Michael Ellerman
2021-08-27 13:28 ` Michael Ellerman
2021-08-27 13:28 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfz59hzi.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=anshuman.khandual@arm.com \
--cc=benh@kernel.crashing.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas.bulwahn@gmail.com \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.