From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A11C4320E for ; Thu, 19 Aug 2021 22:39:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE70860462 for ; Thu, 19 Aug 2021 22:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236808AbhHSWk1 (ORCPT ); Thu, 19 Aug 2021 18:40:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236583AbhHSWk0 (ORCPT ); Thu, 19 Aug 2021 18:40:26 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38AF4C06175F for ; Thu, 19 Aug 2021 15:39:49 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id e7so7280017pgk.2 for ; Thu, 19 Aug 2021 15:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=WX/qJVOnuFAI2moIv6OF4lqewvc4NdGxWkCdYilIaS4=; b=dIr051qis+9TSdlqlxkVlLOVanqfmbLXpUhEciivJ12h+asK6W8Lb8B1xQ5SOFx0ed hBWa5vXbV5b1XLr52yfjhKR12+utTBNZO8Ms6rSiPQtoDnQJGUQfsRj1N9qnjRpMnSko tbJ3maAALuUqpegMFAmcYb5xUkx8ZNp9IKaEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=WX/qJVOnuFAI2moIv6OF4lqewvc4NdGxWkCdYilIaS4=; b=Jmga5+Wi08kGU7dmmAtZNEA0TTtTdSDiXRxhzOL2YjO4nwh+MkTgtp45N78LCN0Pi5 KjW+h7vqpeY5o+XQwjxf/qzkq0gp/iAeHp5FjEuhmoX2RoOZH/UHWUF370niF/1bJrUl ihhr7VTREBUPLCG8/RoXD4vNA4C46X6NyC8faHr+ZBwM/6q/gOzB8KDzIV8mHED3ViuH QKrj8jemPe7SaHP6ul/0ZVm1l8d7E3qMxkT4Y3zeXwFiI431u+PeKCQlXAq16rEw4JXF eaftxxmeM5JGyxJ9Nq1s6/Hml6HXPMGBxzzsQAbSAKMDaj1WsgnXdepyfIxqfo5LyYF/ 5pQA== X-Gm-Message-State: AOAM531Zt9WvpippCsimidztrxgoWL19O3NCahWSPf/0HM8EEzRvrPwQ wEOlwHcx7kd1SQJdEzRla3jBcg== X-Google-Smtp-Source: ABdhPJydtoDgmtfFU7iCvzmfD+6LAiNa/sBr8PkQ4fFuCRed3yo4/Qn+wZAYqYuVMFMYpSUN+dNGhA== X-Received: by 2002:aa7:8e56:0:b029:3cd:c2ec:6c1c with SMTP id d22-20020aa78e560000b02903cdc2ec6c1cmr16390211pfr.80.1629412788706; Thu, 19 Aug 2021 15:39:48 -0700 (PDT) Received: from localhost ([2001:4479:e000:e400:3a83:f47e:d5a3:378a]) by smtp.gmail.com with ESMTPSA id x69sm4639869pfc.59.2021.08.19.15.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 15:39:48 -0700 (PDT) From: Daniel Axtens To: Lukas Bulwahn , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Michael Neuling , Anshuman Khandual , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Lukas Bulwahn , kernel-janitors@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select In-Reply-To: <20210819113954.17515-2-lukas.bulwahn@gmail.com> References: <20210819113954.17515-1-lukas.bulwahn@gmail.com> <20210819113954.17515-2-lukas.bulwahn@gmail.com> Date: Fri, 20 Aug 2021 08:39:45 +1000 Message-ID: <87sfz59hzi.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukas, > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > index e45644657d49..ff581d70f20c 100644 > --- a/arch/powerpc/kvm/Kconfig > +++ b/arch/powerpc/kvm/Kconfig > @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER > config KVM_BOOK3S_64_HANDLER > bool > select KVM_BOOK3S_HANDLER > - select PPC_DAWR_FORCE_ENABLE I looked at some of the history here. It looks like this select was left over from an earlier version of the patch series that added PPC_DAWR: v2 of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4 that new symbol had disappeared but the select had not. v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/ v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/ The rest of the patch reasoning makes sense to me: DAWR support will be selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try to select it again anyway. Reviewed-by: Daniel Axtens Kind regards, Daniel > > config KVM_BOOK3S_PR_POSSIBLE > bool > -- > 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AFA9C4338F for ; Thu, 19 Aug 2021 22:40:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9DED46109E for ; Thu, 19 Aug 2021 22:40:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9DED46109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GrKVD1Dz6z3cXV for ; Fri, 20 Aug 2021 08:40:36 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.a=rsa-sha256 header.s=google header.b=dIr051qi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=axtens.net (client-ip=2607:f8b0:4864:20::52a; helo=mail-pg1-x52a.google.com; envelope-from=dja@axtens.net; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=axtens.net header.i=@axtens.net header.a=rsa-sha256 header.s=google header.b=dIr051qi; dkim-atps=neutral Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GrKTR6gf2z307T for ; Fri, 20 Aug 2021 08:39:53 +1000 (AEST) Received: by mail-pg1-x52a.google.com with SMTP id w8so7296490pgf.5 for ; Thu, 19 Aug 2021 15:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=WX/qJVOnuFAI2moIv6OF4lqewvc4NdGxWkCdYilIaS4=; b=dIr051qis+9TSdlqlxkVlLOVanqfmbLXpUhEciivJ12h+asK6W8Lb8B1xQ5SOFx0ed hBWa5vXbV5b1XLr52yfjhKR12+utTBNZO8Ms6rSiPQtoDnQJGUQfsRj1N9qnjRpMnSko tbJ3maAALuUqpegMFAmcYb5xUkx8ZNp9IKaEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=WX/qJVOnuFAI2moIv6OF4lqewvc4NdGxWkCdYilIaS4=; b=YiHD271kShfqwSOIJm8QDmY9EYTCYynXYrs3xHEBfAfbA6I40ARk2lO28Gk27xhoHD R4DwwlPj9oKXJB1JxDa3QgrgZtNf+8SjFclswDqU2yIX7yuMf6UhgSt6Jl0QygSbF1lK W3XP5CHTMIIS5HzkKV+2NBixeJ0mvq5+ODrxrKZUmJxk/zpf4SM84irRgXUfCHOT6Lsa 8951OGH5Qm9eYQq0GvDJRIeofCW7GyqEXK31DfA8N4TffJv/zUY995o9Dw4kWRDRG3uj AIT/ez1iMTod2wg0UNgcfXe+/QRwjoNY5eY4W/g7z4l4AHehzmbV3kJvih93NBiL3I6M HOYA== X-Gm-Message-State: AOAM5325UaR1NnWzq4jVHNc4EC2xu3k2WkhKJP8sk5z7N8tRJiWq5yRo EHxWlBA5OISNBusaH3iLT7XSSA== X-Google-Smtp-Source: ABdhPJydtoDgmtfFU7iCvzmfD+6LAiNa/sBr8PkQ4fFuCRed3yo4/Qn+wZAYqYuVMFMYpSUN+dNGhA== X-Received: by 2002:aa7:8e56:0:b029:3cd:c2ec:6c1c with SMTP id d22-20020aa78e560000b02903cdc2ec6c1cmr16390211pfr.80.1629412788706; Thu, 19 Aug 2021 15:39:48 -0700 (PDT) Received: from localhost ([2001:4479:e000:e400:3a83:f47e:d5a3:378a]) by smtp.gmail.com with ESMTPSA id x69sm4639869pfc.59.2021.08.19.15.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 15:39:48 -0700 (PDT) From: Daniel Axtens To: Lukas Bulwahn , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Michael Neuling , Anshuman Khandual , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select In-Reply-To: <20210819113954.17515-2-lukas.bulwahn@gmail.com> References: <20210819113954.17515-1-lukas.bulwahn@gmail.com> <20210819113954.17515-2-lukas.bulwahn@gmail.com> Date: Fri, 20 Aug 2021 08:39:45 +1000 Message-ID: <87sfz59hzi.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lukas Bulwahn , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Lukas, > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > index e45644657d49..ff581d70f20c 100644 > --- a/arch/powerpc/kvm/Kconfig > +++ b/arch/powerpc/kvm/Kconfig > @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER > config KVM_BOOK3S_64_HANDLER > bool > select KVM_BOOK3S_HANDLER > - select PPC_DAWR_FORCE_ENABLE I looked at some of the history here. It looks like this select was left over from an earlier version of the patch series that added PPC_DAWR: v2 of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4 that new symbol had disappeared but the select had not. v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/ v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/ The rest of the patch reasoning makes sense to me: DAWR support will be selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try to select it again anyway. Reviewed-by: Daniel Axtens Kind regards, Daniel > > config KVM_BOOK3S_PR_POSSIBLE > bool > -- > 2.26.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Axtens Date: Thu, 19 Aug 2021 22:39:45 +0000 Subject: Re: [PATCH v2 1/2] powerpc: kvm: remove obsolete and unneeded select Message-Id: <87sfz59hzi.fsf@dja-thinkpad.axtens.net> List-Id: References: <20210819113954.17515-1-lukas.bulwahn@gmail.com> <20210819113954.17515-2-lukas.bulwahn@gmail.com> In-Reply-To: <20210819113954.17515-2-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lukas Bulwahn , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Michael Neuling , Anshuman Khandual , kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Lukas Bulwahn , kernel-janitors@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Hi Lukas, > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > index e45644657d49..ff581d70f20c 100644 > --- a/arch/powerpc/kvm/Kconfig > +++ b/arch/powerpc/kvm/Kconfig > @@ -38,7 +38,6 @@ config KVM_BOOK3S_32_HANDLER > config KVM_BOOK3S_64_HANDLER > bool > select KVM_BOOK3S_HANDLER > - select PPC_DAWR_FORCE_ENABLE I looked at some of the history here. It looks like this select was left over from an earlier version of the patch series that added PPC_DAWR: v2 of the series has a new symbol PPC_DAWR_FORCE_ENABLE but by version 4 that new symbol had disappeared but the select had not. v2: https://lore.kernel.org/linuxppc-dev/20190513071703.25243-1-mikey@neuling.org/ v5: https://lore.kernel.org/linuxppc-dev/20190604030037.9424-2-mikey@neuling.org/ The rest of the patch reasoning makes sense to me: DAWR support will be selected anyway by virtue of PPC64->PPC_DAWR so there's no need to try to select it again anyway. Reviewed-by: Daniel Axtens Kind regards, Daniel > > config KVM_BOOK3S_PR_POSSIBLE > bool > -- > 2.26.2