From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h
Date: Fri, 15 Jan 2021 14:28:44 +0100 [thread overview]
Message-ID: <87sg72mir7.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210104161200.15068-1-peter.maydell@linaro.org> (Peter Maydell's message of "Mon, 4 Jan 2021 16:12:00 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> The qmp-cmds.c file currently includes ui/vnc.h, which (being located
> in the ui/ directory rather than include) is really supposed to be
> for use only by the ui subsystem. In fact the function prototypes we
> need (vnc_display_password(), etc) are all declared in
> include/ui/console.h, so we can switch to including that instead.
>
> (ui/vnc.h includes include/ui/console.h, so this change strictly
> reduces the quantity of headers qmp-cmds.c pulls in.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Almost missed this one. Queued, thanks!
prev parent reply other threads:[~2021-01-15 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 16:12 [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h Peter Maydell
2021-01-04 16:30 ` Philippe Mathieu-Daudé
2021-01-04 17:13 ` Peter Maydell
2021-01-15 13:28 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg72mir7.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.