From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C429C4361B for ; Wed, 16 Dec 2020 10:32:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 590702333E for ; Wed, 16 Dec 2020 10:32:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 590702333E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpU6q-0006Xb-8Q for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 05:32:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpU5y-00064n-S3 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 05:31:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kpU5v-0000Dc-24 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 05:31:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608114700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W0zIiMRU6wBQyxYVnAFm/PSA3hukocZ/5zSTTFnYVCU=; b=ikHA0hqJb8f7MPfaxc4pZjOH51cVaZRsxQagPpQn2LdoVstYfrul4A+818l1Sr53UNS/eo DTwxkfQV+q/zQ2QGUq0mw6nVQyA8xrqG8G45lNPi3LcVl+IHQcizobkEfTU22eeHeGZFG9 MYK3iLL258KQPKdboDJJzA3EWowk/70= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-71-oELRA24uMiKH8FTLUgbMMA-1; Wed, 16 Dec 2020 05:31:38 -0500 X-MC-Unique: oELRA24uMiKH8FTLUgbMMA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9B7F800D53 for ; Wed, 16 Dec 2020 10:31:37 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-103.ams2.redhat.com [10.36.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99480177F8; Wed, 16 Dec 2020 10:31:32 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1B6C411329A5; Wed, 16 Dec 2020 11:31:31 +0100 (CET) From: Markus Armbruster To: John Snow Subject: Re: [PATCH 09/12] qapi/gen: move write method to QAPIGenC, make fname a str References: <20201214235327.1007124-1-jsnow@redhat.com> <20201214235327.1007124-10-jsnow@redhat.com> Date: Wed, 16 Dec 2020 11:31:31 +0100 In-Reply-To: <20201214235327.1007124-10-jsnow@redhat.com> (John Snow's message of "Mon, 14 Dec 2020 18:53:24 -0500") Message-ID: <87sg86qby4.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org, Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > QAPIGenC and QAPIGenH in particular depend on fname being defined, but > we have a usage of QAPIGenCCode that isn't intended to be associated > with a particular file. Which one? Hmm, it's this one: class QAPISchemaGenCommandVisitor(QAPISchemaModularCVisitor): def __init__(self, prefix: str): super().__init__( prefix, 'qapi-commands', ' * Schema-defined QAPI/QMP commands', None, __doc__) ---> self._regy = QAPIGenCCode(None) self._visited_ret_types: Dict[QAPIGenC, Set[QAPISchemaType]] = {} Let me try to get rid of it. > No problem, move the write method down to the class that actually needs > it, and keep QAPIGenCCode more abstract. > > Signed-off-by: John Snow