From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-7576-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 53AF5986080 for ; Thu, 16 Jul 2020 16:48:28 +0000 (UTC) References: <20200518203721.7625-1-ndragazis@arrikto.com> <20200518203721.7625-3-ndragazis@arrikto.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20200518203721.7625-3-ndragazis@arrikto.com> Date: Thu, 16 Jul 2020 17:48:24 +0100 Message-ID: <87sgdrv21z.fsf@linaro.org> MIME-Version: 1.0 Subject: Re: [virtio-dev] [PATCH v5 02/10] vhost-user: minor fixes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable To: Nikos Dragazis Cc: Stefan Hajnoczi , "Michael S . Tsirkin" , virtio-dev@lists.oasis-open.org List-ID: Nikos Dragazis writes: > Signed-off-by: Nikos Dragazis > Reviewed-by: Stefan Hajnoczi > --- > virtio-vhost-user.tex | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virtio-vhost-user.tex b/virtio-vhost-user.tex > index ac96dc2..13ecd41 100644 > --- a/virtio-vhost-user.tex > +++ b/virtio-vhost-user.tex > @@ -231,7 +231,7 @@ \subsubsection{Doorbell structure layout}\label{sec:D= evice Types / Vhost-user De > \end{lstlisting} > =20 > The \field{cap.offset} and \field{doorbell_off_multiplier} are taken fro= m the > -notification capability structure above, and the \field{doorbell_idx} is= the > +doorbell capability structure above, and the \field{doorbell_idx} is the > doorbell number. I think it would be helpful to add what we mean by doorbell and notification into the terminology section at the front of the document? > =20 > \devicenormative{\paragraph}{Doorbell capability}{Device Types / Vhost-u= ser Device Backend / Additional Device Resources over PCI / Doorbell capabi= lity} > @@ -260,7 +260,7 @@ \subsubsection{Notification structure layout}\label{s= ec:Device Types / Vhost-use > notification interrupts. If MSI-X is not available, bit 2 of the ISR st= atus > indicates that a notification occurred. > =20 > -The notification structure is found using the VIRTIO_PCI_CAP_DOORBELL_CF= G > +The notification structure is found using the VIRTIO_PCI_CAP_NOTIFICATIO= N_CFG > capability. > =20 > \begin{lstlisting} --=20 Alex Benn=C3=A9e --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org