All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 03/15] tests/tcg: Run timeout cmds using --foreground
Date: Wed, 17 Jun 2020 10:59:22 +0100	[thread overview]
Message-ID: <87sgeuxbb9.fsf@linaro.org> (raw)
In-Reply-To: <20200617061313.uaru24twuzqgml5j@schnipp-desktop>


Bastian Koppelmann <kbastian@mail.uni-paderborn.de> writes:

> On Tue, Jun 16, 2020 at 05:22:42PM +0100, Alex Bennée wrote:
>> 
>> Bastian Koppelmann <kbastian@mail.uni-paderborn.de> writes:
>> 
>> > when trying to run successful short tests from the Makefile timeout would no
>> > terminate. Rather it would wait until the time runs out. Excerpt from the
>> > manpage:
>> 
>> Which tests hang without this change?
>
> The TriCore tests ;).

Hmm I wonder why? All the other tests work so is this a function of
output from the test? The softmmu tests for example usually redirect
their output via a chardev device. Tests which require actual input from
the user are skipped (the semiconsole test is MANUAL only).

>
>> 
>> >
>> > --foreground
>> >     when not running timeout directly from a shell prompt,
>> >     allow COMMAND to read from the TTY and get TTY signals; in this mode, chil‐
>> >     dren of COMMAND will not be timed out
>> >
>> > Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>> > ---
>> >  tests/tcg/Makefile.target | 5 +++--
>> >  1 file changed, 3 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
>> > index b3cff3cad1..423caffa56 100644
>> > --- a/tests/tcg/Makefile.target
>> > +++ b/tests/tcg/Makefile.target
>> > @@ -40,9 +40,10 @@ quiet-command = $(if $(V),$1,$(if $(2),@printf "  %-7s %s\n" $2 $3 && $1, @$1))
>> >  
>> >  # $1 = test name, $2 = cmd, $3 = desc
>> >  ifdef CONFIG_USER_ONLY
>> > -run-test = $(call quiet-command, timeout $(TIMEOUT) $2 > $1.out,"TEST",$3)
>> > +run-test = $(call quiet-command, timeout --foreground $(TIMEOUT) $2 > $1.out \
>> > +	"TEST",$3)
>> 
>> This breaks make check-tcg due to a dropped ,
>
> Whoops
>
> Cheers,
> Bastian


-- 
Alex Bennée


  reply	other threads:[~2020-06-17 10:00 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  8:54 [PATCH v2 00/15] tests/tcg: Add TriCore tests Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 01/15] docker/tricore: Use stretch-slim as a base image Bastian Koppelmann
2020-06-04 15:41   ` Alex Bennée
2020-06-04  8:54 ` [PATCH v2 02/15] tests/tcg: Add docker_as and docker_ld cmds Bastian Koppelmann
2020-06-16 16:13   ` Alex Bennée
2020-06-04  8:54 ` [PATCH v2 03/15] tests/tcg: Run timeout cmds using --foreground Bastian Koppelmann
2020-06-16 16:22   ` Alex Bennée
2020-06-17  6:13     ` Bastian Koppelmann
2020-06-17  9:59       ` Alex Bennée [this message]
2020-06-17 10:52         ` Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 04/15] hw/tricore: Add testdevice for tests in tests/tcg/ Bastian Koppelmann
2020-06-16 17:07   ` Alex Bennée
2020-06-04  8:54 ` [PATCH v2 05/15] tests/tcg/tricore: Add build infrastructure Bastian Koppelmann
2020-06-16 17:22   ` Alex Bennée
2020-06-04  8:54 ` [PATCH v2 06/15] tests/tcg/tricore: Add macros to create tests and first test 'abs' Bastian Koppelmann
2020-06-16 17:28   ` Alex Bennée
2020-06-04  8:54 ` [PATCH v2 07/15] tests/tcg/tricore: Add bmerge test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 08/15] tests/tcg/tricore: Add clz test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 09/15] tests/tcg/tricore: Add dvstep test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 10/15] tests/tcg/tricore: Add fadd test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 11/15] tests/tcg/tricore: Add fmul test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 12/15] tests/tcg/tricore: Add ftoi test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 13/15] tests/tcg/tricore: Add madd test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 14/15] tests/tcg/tricore: Add msub test Bastian Koppelmann
2020-06-04  8:54 ` [PATCH v2 15/15] tests/tcg/tricore: Add muls test Bastian Koppelmann
2020-06-04  9:37 ` [PATCH v2 00/15] tests/tcg: Add TriCore tests no-reply
2020-06-16 17:29 ` Alex Bennée
2021-02-22  9:23 ` Thomas Huth
2021-02-23 10:25   ` Bastian Koppelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgeuxbb9.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.