From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0DCDC3815B for ; Mon, 20 Apr 2020 10:28:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C06CE206B9 for ; Mon, 20 Apr 2020 10:28:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726208AbgDTK2y convert rfc822-to-8bit (ORCPT ); Mon, 20 Apr 2020 06:28:54 -0400 Received: from mga14.intel.com ([192.55.52.115]:16088 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725865AbgDTK2x (ORCPT ); Mon, 20 Apr 2020 06:28:53 -0400 IronPort-SDR: CENwxbK1p15MvzzwW5dGlkvuJbjZ00UQ6Usu0qap1q1hDSY1AV60SHo647FSwCPYUPEnDiNhpM 9MirdJQQAY2Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 03:28:53 -0700 IronPort-SDR: nBw9rc0cJTSj1Prd6W+PnY6lodt0rR2nfxouUPx6OV+8KPmiFVeHwvzUZutezUrxz5yGCZ9ICH +B7+OdhoT1zQ== X-IronPort-AV: E=Sophos;i="5.72,406,1580803200"; d="scan'208";a="429073035" Received: from iastakh-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.63.229]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 03:28:49 -0700 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Cc: Adam Jackson , Joonas Lahtinen , Ville =?utf-8?B?U3lyasOkbMOk?= , Rodrigo Vivi , David Airlie , Daniel Vetter , Chris Wilson , Juha-Pekka Heikkila , Lee Shawn C , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam In-Reply-To: <20200413214407.1851002-1-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200413214407.1851002-1-lyude@redhat.com> Date: Mon, 20 Apr 2020 13:28:46 +0300 Message-ID: <87sggy1me9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Apr 2020, Lyude Paul wrote: > Looks like I accidentally made it so you couldn't force DPCD backlight > support on, whoops. Fix that. Thanks, pushed. BR, Jani. > > Signed-off-by: Lyude Paul > Fixes: 17f5d57915be ("drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel") > Cc: Adam Jackson > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: "Ville Syrjälä" > --- > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 4b916468540f..0722540d64ad 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -358,6 +358,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector) > */ > if (i915->vbt.backlight.type != > INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE && > + i915_modparams.enable_dpcd_backlight != 1 && > !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks, > DP_QUIRK_FORCE_DPCD_BACKLIGHT)) { > drm_info(&i915->drm, -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5ABC38A30 for ; Mon, 20 Apr 2020 10:28:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA61F206B9 for ; Mon, 20 Apr 2020 10:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA61F206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0161B6E49A; Mon, 20 Apr 2020 10:28:55 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02FF36E29A; Mon, 20 Apr 2020 10:28:53 +0000 (UTC) IronPort-SDR: gHQV3vVPmjLqfLCHFcceX84xjnZlBqFGvmsHf+2bgbp8kLbg95yPEbaTAKFDvGiahAoaWvMCyu GvH4weyBdOMw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 03:28:53 -0700 IronPort-SDR: nBw9rc0cJTSj1Prd6W+PnY6lodt0rR2nfxouUPx6OV+8KPmiFVeHwvzUZutezUrxz5yGCZ9ICH +B7+OdhoT1zQ== X-IronPort-AV: E=Sophos;i="5.72,406,1580803200"; d="scan'208";a="429073035" Received: from iastakh-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.63.229]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 03:28:49 -0700 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam In-Reply-To: <20200413214407.1851002-1-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200413214407.1851002-1-lyude@redhat.com> Date: Mon, 20 Apr 2020 13:28:46 +0300 Message-ID: <87sggy1me9.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juha-Pekka Heikkila , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Rodrigo Vivi , Lee Shawn C Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAxMyBBcHIgMjAyMCwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gTG9va3MgbGlrZSBJIGFjY2lkZW50YWxseSBtYWRlIGl0IHNvIHlvdSBjb3VsZG4ndCBmb3Jj ZSBEUENEIGJhY2tsaWdodAo+IHN1cHBvcnQgb24sIHdob29wcy4gRml4IHRoYXQuCgpUaGFua3Ms IHB1c2hlZC4KCkJSLApKYW5pLgoKCgo+Cj4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgUGF1bCA8bHl1 ZGVAcmVkaGF0LmNvbT4KPiBGaXhlczogMTdmNWQ1NzkxNWJlICgiZHJtL2k5MTU6IEZvcmNlIERQ Q0QgYmFja2xpZ2h0IG1vZGUgb24gWDEgRXh0cmVtZSAybmQgR2VuIDRLIEFNT0xFRCBwYW5lbCIp Cj4gQ2M6IEFkYW0gSmFja3NvbiA8YWpheEByZWRoYXQuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25h cy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6ICJWaWxsZSBTeXJqw6Rsw6QiIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv ZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYwo+IGluZGV4IDRiOTE2NDY4NTQwZi4uMDcyMjU0 MGQ2NGFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZHBfYXV4X2JhY2tsaWdodC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBAQCAtMzU4LDYgKzM1OCw3IEBAIGludCBpbnRlbF9k cF9hdXhfaW5pdF9iYWNrbGlnaHRfZnVuY3Moc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxf Y29ubmVjdG9yKQo+ICAJICovCj4gIAlpZiAoaTkxNS0+dmJ0LmJhY2tsaWdodC50eXBlICE9Cj4g IAkgICAgSU5URUxfQkFDS0xJR0hUX1ZFU0FfRURQX0FVWF9JTlRFUkZBQ0UgJiYKPiArCSAgICBp OTE1X21vZHBhcmFtcy5lbmFibGVfZHBjZF9iYWNrbGlnaHQgIT0gMSAmJgo+ICAJICAgICFkcm1f ZHBfaGFzX3F1aXJrKCZpbnRlbF9kcC0+ZGVzYywgaW50ZWxfZHAtPmVkaWRfcXVpcmtzLAo+ICAJ CQkgICAgICBEUF9RVUlSS19GT1JDRV9EUENEX0JBQ0tMSUdIVCkpIHsKPiAgCQlkcm1faW5mbygm aTkxNS0+ZHJtLAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBD ZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7E8C3A5A0 for ; Mon, 20 Apr 2020 10:28:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2708B206B9 for ; Mon, 20 Apr 2020 10:28:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2708B206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B66366E29A; Mon, 20 Apr 2020 10:28:54 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02FF36E29A; Mon, 20 Apr 2020 10:28:53 +0000 (UTC) IronPort-SDR: gHQV3vVPmjLqfLCHFcceX84xjnZlBqFGvmsHf+2bgbp8kLbg95yPEbaTAKFDvGiahAoaWvMCyu GvH4weyBdOMw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 03:28:53 -0700 IronPort-SDR: nBw9rc0cJTSj1Prd6W+PnY6lodt0rR2nfxouUPx6OV+8KPmiFVeHwvzUZutezUrxz5yGCZ9ICH +B7+OdhoT1zQ== X-IronPort-AV: E=Sophos;i="5.72,406,1580803200"; d="scan'208";a="429073035" Received: from iastakh-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.63.229]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 03:28:49 -0700 From: Jani Nikula To: Lyude Paul , intel-gfx@lists.freedesktop.org In-Reply-To: <20200413214407.1851002-1-lyude@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200413214407.1851002-1-lyude@redhat.com> Date: Mon, 20 Apr 2020 13:28:46 +0300 Message-ID: <87sggy1me9.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Adam Jackson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gTW9uLCAxMyBBcHIgMjAyMCwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4gd3JvdGU6 Cj4gTG9va3MgbGlrZSBJIGFjY2lkZW50YWxseSBtYWRlIGl0IHNvIHlvdSBjb3VsZG4ndCBmb3Jj ZSBEUENEIGJhY2tsaWdodAo+IHN1cHBvcnQgb24sIHdob29wcy4gRml4IHRoYXQuCgpUaGFua3Ms IHB1c2hlZC4KCkJSLApKYW5pLgoKCgo+Cj4gU2lnbmVkLW9mZi1ieTogTHl1ZGUgUGF1bCA8bHl1 ZGVAcmVkaGF0LmNvbT4KPiBGaXhlczogMTdmNWQ1NzkxNWJlICgiZHJtL2k5MTU6IEZvcmNlIERQ Q0QgYmFja2xpZ2h0IG1vZGUgb24gWDEgRXh0cmVtZSAybmQgR2VuIDRLIEFNT0xFRCBwYW5lbCIp Cj4gQ2M6IEFkYW0gSmFja3NvbiA8YWpheEByZWRoYXQuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8 amFuaS5uaWt1bGFAbGludXguaW50ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25h cy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6ICJWaWxsZSBTeXJqw6Rsw6QiIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv ZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMgfCAxICsKPiAgMSBmaWxlIGNoYW5nZWQs IDEgaW5zZXJ0aW9uKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYwo+IGluZGV4IDRiOTE2NDY4NTQwZi4uMDcyMjU0 MGQ2NGFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxf ZHBfYXV4X2JhY2tsaWdodC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBAQCAtMzU4LDYgKzM1OCw3IEBAIGludCBpbnRlbF9k cF9hdXhfaW5pdF9iYWNrbGlnaHRfZnVuY3Moc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxf Y29ubmVjdG9yKQo+ICAJICovCj4gIAlpZiAoaTkxNS0+dmJ0LmJhY2tsaWdodC50eXBlICE9Cj4g IAkgICAgSU5URUxfQkFDS0xJR0hUX1ZFU0FfRURQX0FVWF9JTlRFUkZBQ0UgJiYKPiArCSAgICBp OTE1X21vZHBhcmFtcy5lbmFibGVfZHBjZF9iYWNrbGlnaHQgIT0gMSAmJgo+ICAJICAgICFkcm1f ZHBfaGFzX3F1aXJrKCZpbnRlbF9kcC0+ZGVzYywgaW50ZWxfZHAtPmVkaWRfcXVpcmtzLAo+ICAJ CQkgICAgICBEUF9RVUlSS19GT1JDRV9EUENEX0JBQ0tMSUdIVCkpIHsKPiAgCQlkcm1faW5mbygm aTkxNS0+ZHJtLAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBD ZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==