All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>,
	Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Arnd Bergmann <arnd@arndb.de>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Andrew Lutomirski <luto@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"open list\:MIPS" <linux-mips@vger.kernel.org>,
	X86 ML <x86@kernel.org>
Subject: Re: [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback
Date: Fri, 10 Jan 2020 21:56:09 +0100	[thread overview]
Message-ID: <87sgknrpxy.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CALCETrULuV5iAU3kSjMdcpV6DFGEw1z2so0DfDca6hoLB4X4cA@mail.gmail.com>

Andy Lutomirski <luto@kernel.org> writes:

> On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy
> <christophe.leroy@c-s.fr> wrote:
>>
>> In order to simplify next step which moves fallback call at arch
>> level, ensure all arches have a 32bit fallback instead of handling
>> the lack of 32bit fallback in the common code based
>> on VDSO_HAS_32BIT_FALLBACK
>
> I don't like this.  You've implemented what appear to be nonsensical
> fallbacks (the 32-bit fallback for a 64-bit vDSO build?  There's no
> such thing).
>
> How exactly does this simplify patch 2?

There is a patchset from Vincenzo which fell through the cracks which
addresses the VDS_HAS_32BIT_FALLBACK issue properly. I'm about to pick
it up. See:

 https://lore.kernel.org/lkml/20190830135902.20861-1-vincenzo.frascino@arm.com/

Thanks,

        tglx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>,
	Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Arnd Bergmann <arnd@arndb.de>, X86 ML <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:MIPS" <linux-mips@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Andrew Lutomirski <luto@kernel.org>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback
Date: Fri, 10 Jan 2020 21:56:09 +0100	[thread overview]
Message-ID: <87sgknrpxy.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CALCETrULuV5iAU3kSjMdcpV6DFGEw1z2so0DfDca6hoLB4X4cA@mail.gmail.com>

Andy Lutomirski <luto@kernel.org> writes:

> On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy
> <christophe.leroy@c-s.fr> wrote:
>>
>> In order to simplify next step which moves fallback call at arch
>> level, ensure all arches have a 32bit fallback instead of handling
>> the lack of 32bit fallback in the common code based
>> on VDSO_HAS_32BIT_FALLBACK
>
> I don't like this.  You've implemented what appear to be nonsensical
> fallbacks (the 32-bit fallback for a 64-bit vDSO build?  There's no
> such thing).
>
> How exactly does this simplify patch 2?

There is a patchset from Vincenzo which fell through the cracks which
addresses the VDS_HAS_32BIT_FALLBACK issue properly. I'm about to pick
it up. See:

 https://lore.kernel.org/lkml/20190830135902.20861-1-vincenzo.frascino@arm.com/

Thanks,

        tglx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@kernel.org>,
	Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	"open list:MIPS" <linux-mips@vger.kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Andrew Lutomirski <luto@kernel.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback
Date: Fri, 10 Jan 2020 21:56:09 +0100	[thread overview]
Message-ID: <87sgknrpxy.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CALCETrULuV5iAU3kSjMdcpV6DFGEw1z2so0DfDca6hoLB4X4cA@mail.gmail.com>

Andy Lutomirski <luto@kernel.org> writes:

> On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy
> <christophe.leroy@c-s.fr> wrote:
>>
>> In order to simplify next step which moves fallback call at arch
>> level, ensure all arches have a 32bit fallback instead of handling
>> the lack of 32bit fallback in the common code based
>> on VDSO_HAS_32BIT_FALLBACK
>
> I don't like this.  You've implemented what appear to be nonsensical
> fallbacks (the 32-bit fallback for a 64-bit vDSO build?  There's no
> such thing).
>
> How exactly does this simplify patch 2?

There is a patchset from Vincenzo which fell through the cracks which
addresses the VDS_HAS_32BIT_FALLBACK issue properly. I'm about to pick
it up. See:

 https://lore.kernel.org/lkml/20190830135902.20861-1-vincenzo.frascino@arm.com/

Thanks,

        tglx

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-10 20:56 UTC|newest]

Thread overview: 137+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23 14:31 [RFC PATCH v2 00/10] powerpc/32: switch VDSO to C implementation Christophe Leroy
2019-12-23 14:31 ` Christophe Leroy
2019-12-23 14:31 ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-24  2:07   ` Andy Lutomirski
2019-12-24  2:07     ` Andy Lutomirski
2019-12-24  2:07     ` Andy Lutomirski
2020-01-10 20:56     ` Thomas Gleixner [this message]
2020-01-10 20:56       ` Thomas Gleixner
2020-01-10 20:56       ` Thomas Gleixner
2020-01-10 21:02       ` Andy Lutomirski
2020-01-10 21:02         ` Andy Lutomirski
2020-01-10 21:02         ` Andy Lutomirski
2019-12-25  2:05   ` kbuild test robot
2019-12-25  6:01   ` kbuild test robot
2019-12-30 12:27   ` Arnd Bergmann
2019-12-30 12:27     ` Arnd Bergmann
2019-12-30 12:27     ` Arnd Bergmann
2020-01-02 11:29     ` Arnd Bergmann
2020-01-02 11:29       ` Arnd Bergmann
2020-01-02 11:29       ` Arnd Bergmann
2020-01-09 15:43       ` Christophe Leroy
2020-01-09 15:43         ` Christophe Leroy
2020-01-09 15:43         ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 02/10] lib: vdso: move call to fallback out of common code Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-24  2:24   ` Andy Lutomirski
2019-12-24  2:24     ` Andy Lutomirski
2019-12-24  2:24     ` Andy Lutomirski
2019-12-24 11:41     ` christophe leroy
2019-12-24 11:41       ` christophe leroy
2019-12-24 11:41       ` christophe leroy
2019-12-24 12:09       ` Andy Lutomirski
2019-12-24 12:09         ` Andy Lutomirski
2019-12-24 12:09         ` Andy Lutomirski
2019-12-25  2:19   ` kbuild test robot
2019-12-23 14:31 ` [RFC PATCH v2 03/10] lib: vdso: Change __cvdso_clock_gettime/getres_common() to __cvdso_clock_gettime/getres() Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 04/10] lib: vdso: get pointer to vdso data from the arch Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-24  2:27   ` Andy Lutomirski
2019-12-24  2:27     ` Andy Lutomirski
2019-12-24  2:27     ` Andy Lutomirski
2019-12-24 11:53     ` christophe leroy
2019-12-24 11:53       ` christophe leroy
2019-12-24 11:53       ` christophe leroy
2019-12-24 12:15       ` Andy Lutomirski
2019-12-24 12:15         ` Andy Lutomirski
2019-12-24 12:15         ` Andy Lutomirski
2019-12-24 12:41         ` Andy Lutomirski
2019-12-24 12:41           ` Andy Lutomirski
2019-12-24 12:41           ` Andy Lutomirski
2019-12-24 14:46         ` Segher Boessenkool
2019-12-24 14:46           ` Segher Boessenkool
2019-12-24 14:46           ` Segher Boessenkool
2019-12-23 14:31 ` [RFC PATCH v2 05/10] lib: vdso: inline do_hres() Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-24  2:29   ` Andy Lutomirski
2019-12-24  2:29     ` Andy Lutomirski
2019-12-24  2:29     ` Andy Lutomirski
2019-12-30 12:07   ` Arnd Bergmann
2019-12-30 12:07     ` Arnd Bergmann
2019-12-30 12:07     ` Arnd Bergmann
2020-01-10 21:07     ` Thomas Gleixner
2020-01-10 21:07       ` Thomas Gleixner
2020-01-10 21:07       ` Thomas Gleixner
2020-01-11  9:06       ` Christophe Leroy
2020-01-11  9:06         ` Christophe Leroy
2020-01-11  9:06         ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 06/10] lib: vdso: make do_coarse() return 0 Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 07/10] lib: vdso: don't use READ_ONCE() in __c_kernel_time() Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-24  1:58   ` Andy Lutomirski
2019-12-24  1:58     ` Andy Lutomirski
2019-12-24  1:58     ` Andy Lutomirski
2019-12-24 11:12     ` christophe leroy
2019-12-24 11:12       ` christophe leroy
2019-12-24 11:12       ` christophe leroy
2019-12-24 12:04       ` Andy Lutomirski
2019-12-24 12:04         ` Andy Lutomirski
2019-12-24 12:04         ` Andy Lutomirski
2020-01-10 21:12   ` Thomas Gleixner
2020-01-10 21:12     ` Thomas Gleixner
2020-01-10 21:12     ` Thomas Gleixner
2020-01-11  8:05     ` Christophe Leroy
2020-01-11  8:05       ` Christophe Leroy
2020-01-11  8:05       ` Christophe Leroy
2020-01-11 11:07       ` Thomas Gleixner
2020-01-11 11:07         ` Thomas Gleixner
2020-01-11 11:07         ` Thomas Gleixner
2020-01-13  6:52         ` Christophe Leroy
2020-01-13  6:52           ` Christophe Leroy
2020-01-13  6:52           ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 08/10] lib: vdso: Avoid duplication in __cvdso_clock_getres() Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-24  1:59   ` Andy Lutomirski
2019-12-24  1:59     ` Andy Lutomirski
2019-12-24  1:59     ` Andy Lutomirski
2019-12-23 14:31 ` [RFC PATCH v2 09/10] powerpc/vdso32: inline __get_datapage() Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31 ` [RFC PATCH v2 10/10] powerpc/32: Switch VDSO to C implementation Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-23 14:31   ` Christophe Leroy
2019-12-25  6:54   ` kbuild test robot
2020-01-09 17:52 ` Surprising code generated for vdso_read_begin() Christophe Leroy
2020-01-09 20:07   ` Segher Boessenkool
2020-01-09 20:07     ` Segher Boessenkool
2020-01-09 20:07     ` Segher Boessenkool
2020-01-10  6:45     ` Christophe Leroy
2020-01-10  6:45       ` Christophe Leroy
2020-01-10  6:45       ` Christophe Leroy
2020-01-11 11:33       ` Segher Boessenkool
2020-01-11 11:33         ` Segher Boessenkool
2020-01-11 11:33         ` Segher Boessenkool
2020-02-16 18:10         ` Arnd Bergmann
2020-02-16 18:10           ` Arnd Bergmann
2020-02-16 18:10           ` Arnd Bergmann
2020-02-19  8:45           ` Christophe Leroy
2020-02-19  8:45             ` Christophe Leroy
2020-02-19  8:45             ` Christophe Leroy
2020-02-19  9:52             ` Arnd Bergmann
2020-02-19  9:52               ` Arnd Bergmann
2020-02-19  9:52               ` Arnd Bergmann
2020-02-19 13:08               ` Segher Boessenkool
2020-02-19 13:08                 ` Segher Boessenkool
2020-02-19 13:08                 ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgknrpxy.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=luto@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=vincenzo.frascino@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.